* [Cluster-devel] [PATCH] GFS2: Add calls to gfs2_holder_uninit in two error handlers
@ 2016-04-15 20:56 Daniel DeFreez
2016-04-19 14:31 ` Bob Peterson
2016-04-20 0:10 ` Bob Peterson
0 siblings, 2 replies; 3+ messages in thread
From: Daniel DeFreez @ 2016-04-15 20:56 UTC (permalink / raw)
To: cluster-devel.redhat.com
This is a follow-up patch to the question I asked yesterday. These are
the two locations I am aware of that do not call gfs2_holder_uninit if
gfs2_glock_nq returns an error.
Signed-off-by: Daniel DeFreez <dcdefreez@ucdavis.edu>
---
fs/gfs2/aops.c | 3 ++-
fs/gfs2/file.c | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/fs/gfs2/aops.c b/fs/gfs2/aops.c
index 1bbbee9..68100df 100644
--- a/fs/gfs2/aops.c
+++ b/fs/gfs2/aops.c
@@ -1063,7 +1063,7 @@ static ssize_t gfs2_direct_IO(struct kiocb *iocb, struct iov_iter *iter,
gfs2_holder_init(ip->i_gl, LM_ST_DEFERRED, 0, &gh);
rv = gfs2_glock_nq(&gh);
if (rv)
- return rv;
+ goto out_uninit;
rv = gfs2_ok_for_dio(ip, offset);
if (rv != 1)
goto out; /* dio not valid, fall back to buffered i/o */
@@ -1102,6 +1102,7 @@ static ssize_t gfs2_direct_IO(struct kiocb *iocb, struct iov_iter *iter,
offset, gfs2_get_block_direct, NULL, NULL, 0);
out:
gfs2_glock_dq(&gh);
+out_uninit:
gfs2_holder_uninit(&gh);
return rv;
}
diff --git a/fs/gfs2/file.c b/fs/gfs2/file.c
index 208efc7..97443fc 100644
--- a/fs/gfs2/file.c
+++ b/fs/gfs2/file.c
@@ -160,7 +160,7 @@ static int gfs2_get_flags(struct file *filp, u32 __user *ptr)
gfs2_holder_init(ip->i_gl, LM_ST_SHARED, 0, &gh);
error = gfs2_glock_nq(&gh);
if (error)
- return error;
+ goto out_uninit;
fsflags = fsflags_cvt(gfs2_to_fsflags, ip->i_diskflags);
if (!S_ISDIR(inode->i_mode) && ip->i_diskflags & GFS2_DIF_JDATA)
@@ -169,6 +169,7 @@ static int gfs2_get_flags(struct file *filp, u32 __user *ptr)
error = -EFAULT;
gfs2_glock_dq(&gh);
+out_uninit:
gfs2_holder_uninit(&gh);
return error;
}
--
2.7.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-04-20 0:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-15 20:56 [Cluster-devel] [PATCH] GFS2: Add calls to gfs2_holder_uninit in two error handlers Daniel DeFreez
2016-04-19 14:31 ` Bob Peterson
2016-04-20 0:10 ` Bob Peterson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.