From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
Richard Weinberger <richard@nod.at>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Chen-Yu Tsai <wens@csie.org>,
open list <linux-kernel@vger.kernel.org>,
"moderated list:ARM/Allwinner sunXi SoC support"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 12/12] mtd: mtd: drop NAND_ECC_SOFT_BCH enum value
Date: Sun, 17 Apr 2016 21:01:14 +0200 [thread overview]
Message-ID: <20160417210114.7895ae16@bbrezillon> (raw)
In-Reply-To: <CACna6rzjXrjrx1Wq3cngYmKgSFAME7ZYNoPBpbyO3VWnHgMBAg@mail.gmail.com>
On Sun, 17 Apr 2016 19:10:11 +0200
Rafał Miłecki <zajec5@gmail.com> wrote:
> On 17 April 2016 at 19:05, Boris Brezillon
> <boris.brezillon@free-electrons.com> wrote:
> > On Fri, 15 Apr 2016 21:54:12 +0200
> > Rafał Miłecki <zajec5@gmail.com> wrote:
> >
> >> This value should not be part of nand_ecc_modes_t as it specifies
> >> algorithm not a mode. We successfully managed to introduce new "algo"
> >> field which is respected now.
> >>
> >> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
> >> ---
> >> drivers/mtd/nand/fsmc_nand.c | 3 +--
> >> drivers/mtd/nand/jz4780_nand.c | 1 -
> >> drivers/mtd/nand/nand_base.c | 2 --
> >> drivers/mtd/nand/nandsim.c | 2 +-
> >> drivers/mtd/nand/sunxi_nand.c | 2 --
> >> include/linux/mtd/nand.h | 1 -
> >> 6 files changed, 2 insertions(+), 9 deletions(-)
> >>
> >> diff --git a/drivers/mtd/nand/fsmc_nand.c b/drivers/mtd/nand/fsmc_nand.c
> >> index 0f8c63f..d4f454a 100644
> >> --- a/drivers/mtd/nand/fsmc_nand.c
> >> +++ b/drivers/mtd/nand/fsmc_nand.c
> >> @@ -959,7 +959,6 @@ static int __init fsmc_nand_probe(struct platform_device *pdev)
> >> break;
> >>
> >> case NAND_ECC_SOFT:
> >> - case NAND_ECC_SOFT_BCH:
> >> if (nand->ecc.algo == NAND_ECC_BCH) {
> >> dev_info(&pdev->dev, "Using 4-bit SW BCH ECC scheme\n");
> >> break;
> >> @@ -974,7 +973,7 @@ static int __init fsmc_nand_probe(struct platform_device *pdev)
> >> * Don't set layout for BCH4 SW ECC. This will be
> >> * generated later in nand_bch_init() later.
> >> */
> >> - if (nand->ecc.mode != NAND_ECC_SOFT_BCH) {
> >> + if (nand->ecc.mode == NAND_ECC_HW) {
> >
> > This test is wrong, it should be
> >
> > if (nand->ecc.mode != NAND_ECC_SOFT ||
> > nand->ecc.algo != NAND_ECC_BCH)
> >
> > or
> > if (!(nand->ecc.mode == NAND_ECC_SOFT &&
> > nand->ecc.algo == NAND_ECC_BCH)
>
> This driver supports only 2 modes (see switch above).
Indeed. Sorry, I didn't read the full context.
Thanks for the clarification.
Boris
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: boris.brezillon@free-electrons.com (Boris Brezillon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 12/12] mtd: mtd: drop NAND_ECC_SOFT_BCH enum value
Date: Sun, 17 Apr 2016 21:01:14 +0200 [thread overview]
Message-ID: <20160417210114.7895ae16@bbrezillon> (raw)
In-Reply-To: <CACna6rzjXrjrx1Wq3cngYmKgSFAME7ZYNoPBpbyO3VWnHgMBAg@mail.gmail.com>
On Sun, 17 Apr 2016 19:10:11 +0200
Rafa? Mi?ecki <zajec5@gmail.com> wrote:
> On 17 April 2016 at 19:05, Boris Brezillon
> <boris.brezillon@free-electrons.com> wrote:
> > On Fri, 15 Apr 2016 21:54:12 +0200
> > Rafa? Mi?ecki <zajec5@gmail.com> wrote:
> >
> >> This value should not be part of nand_ecc_modes_t as it specifies
> >> algorithm not a mode. We successfully managed to introduce new "algo"
> >> field which is respected now.
> >>
> >> Signed-off-by: Rafa? Mi?ecki <zajec5@gmail.com>
> >> ---
> >> drivers/mtd/nand/fsmc_nand.c | 3 +--
> >> drivers/mtd/nand/jz4780_nand.c | 1 -
> >> drivers/mtd/nand/nand_base.c | 2 --
> >> drivers/mtd/nand/nandsim.c | 2 +-
> >> drivers/mtd/nand/sunxi_nand.c | 2 --
> >> include/linux/mtd/nand.h | 1 -
> >> 6 files changed, 2 insertions(+), 9 deletions(-)
> >>
> >> diff --git a/drivers/mtd/nand/fsmc_nand.c b/drivers/mtd/nand/fsmc_nand.c
> >> index 0f8c63f..d4f454a 100644
> >> --- a/drivers/mtd/nand/fsmc_nand.c
> >> +++ b/drivers/mtd/nand/fsmc_nand.c
> >> @@ -959,7 +959,6 @@ static int __init fsmc_nand_probe(struct platform_device *pdev)
> >> break;
> >>
> >> case NAND_ECC_SOFT:
> >> - case NAND_ECC_SOFT_BCH:
> >> if (nand->ecc.algo == NAND_ECC_BCH) {
> >> dev_info(&pdev->dev, "Using 4-bit SW BCH ECC scheme\n");
> >> break;
> >> @@ -974,7 +973,7 @@ static int __init fsmc_nand_probe(struct platform_device *pdev)
> >> * Don't set layout for BCH4 SW ECC. This will be
> >> * generated later in nand_bch_init() later.
> >> */
> >> - if (nand->ecc.mode != NAND_ECC_SOFT_BCH) {
> >> + if (nand->ecc.mode == NAND_ECC_HW) {
> >
> > This test is wrong, it should be
> >
> > if (nand->ecc.mode != NAND_ECC_SOFT ||
> > nand->ecc.algo != NAND_ECC_BCH)
> >
> > or
> > if (!(nand->ecc.mode == NAND_ECC_SOFT &&
> > nand->ecc.algo == NAND_ECC_BCH)
>
> This driver supports only 2 modes (see switch above).
Indeed. Sorry, I didn't read the full context.
Thanks for the clarification.
Boris
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-04-17 19:01 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-15 19:54 [PATCH 00/12] mtd: nand: get rid of NAND_ECC_SOFT_BCH Rafał Miłecki
2016-04-15 19:54 ` [PATCH 01/12] mtd: nand: bf5xx: set ECC algorithm explicitly Rafał Miłecki
2016-04-15 19:54 ` [PATCH 02/12] mtd: nand: davinci: " Rafał Miłecki
2016-04-15 19:54 ` [PATCH 03/12] avr32: set Atmel NAND " Rafał Miłecki
2016-04-16 7:38 ` Boris Brezillon
2016-04-16 12:58 ` Hans-Christian Noren Egtvedt
2016-04-15 19:54 ` [PATCH 04/12] mtd: nand: atmel: set " Rafał Miłecki
2016-04-16 7:40 ` Boris Brezillon
2016-04-15 19:54 ` [PATCH 05/12] CRIS v32: nand: " Rafał Miłecki
2016-04-15 19:54 ` [PATCH 06/12] staging: mt29f_spinand: " Rafał Miłecki
2016-04-15 19:54 ` [PATCH 07/12] mtd: nand: set ECC algorithm to Hamming on fallback Rafał Miłecki
2016-04-15 19:54 ` [PATCH 08/12] mtd: nand: hisi504: set ECC algorithm based on DT info Rafał Miłecki
2016-04-16 7:48 ` Boris Brezillon
2016-04-15 19:54 ` [PATCH 09/12] mtd: nand: fsmc: validate ECC setup by checking algorithm directly Rafał Miłecki
2016-04-15 20:23 ` Joe Perches
2016-04-15 20:24 ` Joe Perches
2016-04-15 20:43 ` Rafał Miłecki
2016-04-15 19:54 ` [PATCH 10/12] mtd: nand: read ECC algorithm from the new field Rafał Miłecki
2016-04-16 7:58 ` Boris Brezillon
2016-04-16 8:11 ` Boris Brezillon
2016-04-17 16:27 ` Rafał Miłecki
2016-04-17 16:50 ` Boris Brezillon
2016-04-17 16:57 ` Boris Brezillon
2016-04-17 16:57 ` Rafał Miłecki
2016-04-15 19:54 ` [PATCH 11/12] of: mtd: drop support for NAND_ECC_SOFT_BCH as "soft_bch" mapping Rafał Miłecki
2016-04-15 19:54 ` Rafał Miłecki
2016-04-16 8:00 ` Boris Brezillon
2016-04-16 8:00 ` Boris Brezillon
2016-04-16 8:01 ` Boris Brezillon
2016-04-16 8:01 ` Boris Brezillon
2016-04-15 19:54 ` [PATCH 12/12] mtd: mtd: drop NAND_ECC_SOFT_BCH enum value Rafał Miłecki
2016-04-15 19:54 ` Rafał Miłecki
2016-04-17 17:05 ` Boris Brezillon
2016-04-17 17:05 ` Boris Brezillon
2016-04-17 17:10 ` Rafał Miłecki
2016-04-17 17:10 ` Rafał Miłecki
2016-04-17 19:01 ` Boris Brezillon [this message]
2016-04-17 19:01 ` Boris Brezillon
2016-04-17 17:11 ` [PATCH V2 00/11] mtd: nand: get rid of NAND_ECC_SOFT_BCH Rafał Miłecki
2016-04-17 17:11 ` [PATCH V2 01/11] mtd: nand: bf5xx: set ECC algorithm explicitly Rafał Miłecki
2016-04-17 17:11 ` [PATCH V2 02/11] mtd: nand: davinci: " Rafał Miłecki
2016-04-17 17:11 ` [PATCH V2 03/11] mtd: nand: atmel: " Rafał Miłecki
2016-04-17 17:11 ` [PATCH V2 04/11] CRIS v32: nand: " Rafał Miłecki
2016-04-17 17:11 ` [PATCH V2 05/11] staging: mt29f_spinand: " Rafał Miłecki
2016-04-17 17:11 ` [PATCH V2 06/11] mtd: nand: set ECC algorithm to Hamming on fallback Rafał Miłecki
2016-04-17 17:11 ` [PATCH V2 07/11] mtd: nand: hisi504: set ECC algorithm based on DT info Rafał Miłecki
2016-04-17 17:11 ` [PATCH V2 08/11] mtd: nand: fsmc: validate ECC setup by checking algorithm directly Rafał Miłecki
2016-04-17 17:11 ` [PATCH V2 09/11] mtd: nand: read ECC algorithm from the new field Rafał Miłecki
2016-04-17 18:59 ` Boris Brezillon
2016-04-17 17:11 ` [PATCH V2 10/11] of: mtd: drop support for NAND_ECC_SOFT_BCH as "soft_bch" mapping Rafał Miłecki
2016-04-17 17:11 ` Rafał Miłecki
2016-04-17 17:11 ` [PATCH V2 11/11] mtd: mtd: drop NAND_ECC_SOFT_BCH enum value Rafał Miłecki
2016-04-17 17:11 ` Rafał Miłecki
2016-04-17 20:52 ` [PATCH V3 00/11] mtd: nand: get rid of NAND_ECC_SOFT_BCH Rafał Miłecki
2016-04-17 20:52 ` [PATCH V3 01/11] mtd: nand: bf5xx: set ECC algorithm explicitly Rafał Miłecki
2016-04-17 20:52 ` [PATCH V3 02/11] mtd: nand: davinci: " Rafał Miłecki
2016-04-17 20:52 ` [PATCH V3 03/11] mtd: nand: atmel: " Rafał Miłecki
2016-04-17 20:53 ` [PATCH V3 04/11] CRIS v32: nand: " Rafał Miłecki
2016-04-21 20:18 ` Boris Brezillon
2016-04-21 20:44 ` Mikael Starvik
2016-04-22 7:26 ` Jesper Nilsson
2016-04-17 20:53 ` [PATCH V3 05/11] staging: mt29f_spinand: " Rafał Miłecki
2016-04-21 20:20 ` Boris Brezillon
2016-04-22 2:32 ` Greg Kroah-Hartman
2016-04-17 20:53 ` [PATCH V3 06/11] mtd: nand: set ECC algorithm to Hamming on fallback Rafał Miłecki
2016-04-17 20:53 ` [PATCH V3 07/11] mtd: nand: hisi504: set ECC algorithm based on DT info Rafał Miłecki
2016-04-17 20:53 ` [PATCH V3 08/11] mtd: nand: fsmc: validate ECC setup by checking algorithm directly Rafał Miłecki
2016-04-17 20:53 ` [PATCH V3 09/11] mtd: nand: read ECC algorithm from the new field Rafał Miłecki
2016-04-17 20:53 ` [PATCH V3 10/11] of: mtd: drop support for NAND_ECC_SOFT_BCH as "soft_bch" mapping Rafał Miłecki
2016-04-17 20:53 ` Rafał Miłecki
2016-04-17 20:53 ` [PATCH V3 11/11] mtd: mtd: drop NAND_ECC_SOFT_BCH enum value Rafał Miłecki
2016-04-17 20:53 ` Rafał Miłecki
2016-04-22 9:11 ` [PATCH V3 00/11] mtd: nand: get rid of NAND_ECC_SOFT_BCH Boris Brezillon
2016-04-22 9:39 ` Rafał Miłecki
2016-04-22 9:42 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160417210114.7895ae16@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=maxime.ripard@free-electrons.com \
--cc=richard@nod.at \
--cc=wens@csie.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.