All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serge-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org>
To: "Serge E. Hallyn" <serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org,
	ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org,
	gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
	tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
	serge-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org
Subject: [PATCH 3/2] cgroup_show_path: use a new helper to get current cgns css_set
Date: Mon, 18 Apr 2016 00:29:05 -0500	[thread overview]
Message-ID: <20160418052905.GA3848@mail.hallyn.com> (raw)
In-Reply-To: <20160418041126.GA424-7LNsyQBKDXoIagZqoN9o3w@public.gmane.org>

Since we're getting current's cgroup namespace info, and are not
modifying it, we can use rcu_read_lock() instead of cgroup_mutex.

Signed-off-by: Serge Hallyn <serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org>
---
 kernel/cgroup.c | 40 ++++++++++++++++++++++++++++++++++++----
 1 file changed, 36 insertions(+), 4 deletions(-)

diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 9a0d7b3..cd8269e 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -1215,6 +1215,41 @@ static void cgroup_destroy_root(struct cgroup_root *root)
 	cgroup_free_root(root);
 }
 
+/*
+ * look up cgroup associated with current task's cgroup namespace on the
+ * specified hierarchy
+ */
+static struct cgroup *
+current_cgns_cgroup_from_root(struct cgroup_root *root)
+{
+	struct cgroup *res = NULL;
+	struct css_set *css;
+
+	lockdep_assert_held(&css_set_lock);
+
+	rcu_read_lock();
+
+	css = current->nsproxy->cgroup_ns->root_cset;
+	if (cset == &init_css_set) {
+		res = &root->cgrp;
+	} else {
+		struct cgrp_cset_link *link;
+
+		list_for_each_entry(link, &cset->cgrp_links, cgrp_link) {
+			struct cgroup *c = link->cgrp;
+
+			if (c->root == root) {
+				res = c;
+				break;
+			}
+		}
+	}
+	rcu_read_unlock();
+
+	BUG_ON(!res);
+	return res;
+}
+
 /* look up cgroup associated with given css_set on the specified hierarchy */
 static struct cgroup *cset_cgroup_from_root(struct css_set *cset,
 					    struct cgroup_root *root)
@@ -1598,13 +1633,11 @@ static int cgroup_show_path(struct seq_file *sf, struct kernfs_node *kf_node,
 {
 	int len = 0, ret = 0;
 	char *buf = NULL;
-	struct cgroup_namespace *ns = current->nsproxy->cgroup_ns;
 	struct cgroup_root *kf_cgroot = cgroup_root_from_kf(kf_root);
 	struct cgroup *ns_cgroup;
 
-	mutex_lock(&cgroup_mutex);
 	spin_lock_bh(&css_set_lock);
-	ns_cgroup = cset_cgroup_from_root(ns->root_cset, kf_cgroot);
+	ns_cgroup = current_cgns_cgroup_from_root(kf_cgroot);
 	len = kernfs_path_from_node(kf_node, ns_cgroup->kn, NULL, 0);
 	if (len > 0)
 		buf = kmalloc(len + 1, GFP_ATOMIC);
@@ -1612,7 +1645,6 @@ static int cgroup_show_path(struct seq_file *sf, struct kernfs_node *kf_node,
 		ret = kernfs_path_from_node(kf_node, ns_cgroup->kn, buf, len + 1);
 
 	spin_unlock_bh(&css_set_lock);
-	mutex_unlock(&cgroup_mutex);
 
 	if (len <= 0)
 		return len;
-- 
2.7.4

WARNING: multiple messages have this Message-ID (diff)
From: "Serge E. Hallyn" <serge@hallyn.com>
To: "Serge E. Hallyn" <serge.hallyn@ubuntu.com>
Cc: linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
	containers@lists.linux-foundation.org, hannes@cmpxchg.org,
	ebiederm@xmission.com, gregkh@linuxfoundation.org, tj@kernel.org,
	cgroups@vger.kernel.org, akpm@linux-foundation.org,
	serge@hallyn.com
Subject: [PATCH 3/2] cgroup_show_path: use a new helper to get current cgns css_set
Date: Mon, 18 Apr 2016 00:29:05 -0500	[thread overview]
Message-ID: <20160418052905.GA3848@mail.hallyn.com> (raw)
In-Reply-To: <20160418041126.GA424@mail.hallyn.com>

Since we're getting current's cgroup namespace info, and are not
modifying it, we can use rcu_read_lock() instead of cgroup_mutex.

Signed-off-by: Serge Hallyn <serge.hallyn@ubuntu.com>
---
 kernel/cgroup.c | 40 ++++++++++++++++++++++++++++++++++++----
 1 file changed, 36 insertions(+), 4 deletions(-)

diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 9a0d7b3..cd8269e 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -1215,6 +1215,41 @@ static void cgroup_destroy_root(struct cgroup_root *root)
 	cgroup_free_root(root);
 }
 
+/*
+ * look up cgroup associated with current task's cgroup namespace on the
+ * specified hierarchy
+ */
+static struct cgroup *
+current_cgns_cgroup_from_root(struct cgroup_root *root)
+{
+	struct cgroup *res = NULL;
+	struct css_set *css;
+
+	lockdep_assert_held(&css_set_lock);
+
+	rcu_read_lock();
+
+	css = current->nsproxy->cgroup_ns->root_cset;
+	if (cset == &init_css_set) {
+		res = &root->cgrp;
+	} else {
+		struct cgrp_cset_link *link;
+
+		list_for_each_entry(link, &cset->cgrp_links, cgrp_link) {
+			struct cgroup *c = link->cgrp;
+
+			if (c->root == root) {
+				res = c;
+				break;
+			}
+		}
+	}
+	rcu_read_unlock();
+
+	BUG_ON(!res);
+	return res;
+}
+
 /* look up cgroup associated with given css_set on the specified hierarchy */
 static struct cgroup *cset_cgroup_from_root(struct css_set *cset,
 					    struct cgroup_root *root)
@@ -1598,13 +1633,11 @@ static int cgroup_show_path(struct seq_file *sf, struct kernfs_node *kf_node,
 {
 	int len = 0, ret = 0;
 	char *buf = NULL;
-	struct cgroup_namespace *ns = current->nsproxy->cgroup_ns;
 	struct cgroup_root *kf_cgroot = cgroup_root_from_kf(kf_root);
 	struct cgroup *ns_cgroup;
 
-	mutex_lock(&cgroup_mutex);
 	spin_lock_bh(&css_set_lock);
-	ns_cgroup = cset_cgroup_from_root(ns->root_cset, kf_cgroot);
+	ns_cgroup = current_cgns_cgroup_from_root(kf_cgroot);
 	len = kernfs_path_from_node(kf_node, ns_cgroup->kn, NULL, 0);
 	if (len > 0)
 		buf = kmalloc(len + 1, GFP_ATOMIC);
@@ -1612,7 +1645,6 @@ static int cgroup_show_path(struct seq_file *sf, struct kernfs_node *kf_node,
 		ret = kernfs_path_from_node(kf_node, ns_cgroup->kn, buf, len + 1);
 
 	spin_unlock_bh(&css_set_lock);
-	mutex_unlock(&cgroup_mutex);
 
 	if (len <= 0)
 		return len;
-- 
2.7.4

  parent reply	other threads:[~2016-04-18  5:29 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-17 20:04 Show virtualized dentry root in mountinfo for cgroupfs serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA
2016-04-17 20:04 ` serge.hallyn
     [not found] ` <1460923472-29370-1-git-send-email-serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org>
2016-04-17 20:04   ` [PATCH 1/2] kernfs_path_from_node_locked: don't overwrite nlen serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA
2016-04-17 20:04     ` serge.hallyn
     [not found]     ` <1460923472-29370-2-git-send-email-serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org>
2016-04-20 19:43       ` Tejun Heo
2016-04-20 19:43         ` Tejun Heo
     [not found]         ` <20160420194313.GA4775-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
2016-05-02 16:32           ` Tejun Heo
2016-05-02 16:32           ` Tejun Heo
2016-05-02 16:32             ` Tejun Heo
     [not found]             ` <20160502163256.GT7822-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2016-05-02 16:41               ` Greg KH
2016-05-02 16:41                 ` Greg KH
2016-04-17 20:04   ` [PATCH 2/2] mountinfo: implement show_path for kernfs and cgroup serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA
2016-04-17 20:04     ` serge.hallyn
     [not found]     ` <1460923472-29370-3-git-send-email-serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org>
2016-04-18  4:11       ` Serge E. Hallyn
2016-04-18  4:11         ` Serge E. Hallyn
     [not found]         ` <20160418041126.GA424-7LNsyQBKDXoIagZqoN9o3w@public.gmane.org>
2016-04-18  5:29           ` Serge E. Hallyn [this message]
2016-04-18  5:29             ` [PATCH 3/2] cgroup_show_path: use a new helper to get current cgns css_set Serge E. Hallyn
     [not found]             ` <20160418052905.GA3848-7LNsyQBKDXoIagZqoN9o3w@public.gmane.org>
2016-04-29 21:42               ` Serge E. Hallyn
2016-04-29 21:42                 ` Serge E. Hallyn
     [not found]                 ` <20160429214254.GA13615-7LNsyQBKDXoIagZqoN9o3w@public.gmane.org>
2016-05-02 16:35                   ` Tejun Heo
2016-05-02 16:35                   ` Tejun Heo
2016-05-02 16:35                     ` Tejun Heo
     [not found]                     ` <20160502163526.GW7822-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2016-05-03 14:26                       ` Serge E. Hallyn
2016-05-03 14:26                       ` Serge E. Hallyn
2016-05-03 14:26                         ` Serge E. Hallyn
2016-04-29 21:42               ` Serge E. Hallyn
2016-04-18  5:29           ` Serge E. Hallyn
2016-04-19  1:12           ` [PATCH 2/2] mountinfo: implement show_path for kernfs and cgroup Eric W. Biederman
2016-04-19  1:12           ` Eric W. Biederman
2016-04-19  1:12             ` Eric W. Biederman
     [not found]             ` <87mvoqqu48.fsf-JOvCrm2gF+uungPnsOpG7nhyD016LWXt@public.gmane.org>
2016-04-19  1:44               ` Serge E. Hallyn
2016-04-19  1:44               ` Serge E. Hallyn
2016-04-19  1:44                 ` Serge E. Hallyn
     [not found]                 ` <20160419014419.GA19080-7LNsyQBKDXoIagZqoN9o3w@public.gmane.org>
2016-04-19  4:05                   ` Serge E. Hallyn
2016-04-19  4:05                     ` Serge E. Hallyn
     [not found]                     ` <20160419040546.GA20350-7LNsyQBKDXoIagZqoN9o3w@public.gmane.org>
2016-04-26  2:42                       ` Serge E. Hallyn
2016-04-26  2:42                         ` Serge E. Hallyn
     [not found]                         ` <20160426024207.GA2783-7LNsyQBKDXoIagZqoN9o3w@public.gmane.org>
2016-04-26 10:29                           ` Karel Zak
2016-04-26 10:29                           ` Karel Zak
2016-04-26 10:29                             ` Karel Zak
     [not found]                             ` <20160426102925.vkydkjtrsnibuc7c-xkT7n84Rsxv/9pzu0YdTqQ@public.gmane.org>
2016-04-26 14:36                               ` Serge E. Hallyn
2016-04-26 14:36                               ` Serge E. Hallyn
2016-04-26 14:36                                 ` Serge E. Hallyn
     [not found]                                 ` <20160426143622.GA11021-7LNsyQBKDXoIagZqoN9o3w@public.gmane.org>
2016-05-02 16:33                                   ` Tejun Heo
2016-05-02 16:33                                     ` Tejun Heo
2016-04-19  4:05                   ` Serge E. Hallyn
2016-04-18  4:11       ` Serge E. Hallyn
2016-05-02 16:34       ` Tejun Heo
2016-05-02 16:34         ` Tejun Heo
2016-04-17 20:04   ` serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160418052905.GA3848@mail.hallyn.com \
    --to=serge-a9i7lubdfnhqt0dzr+alfa@public.gmane.org \
    --cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org \
    --cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
    --cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
    --cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org \
    --cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.