From: Stephen Boyd <sboyd@codeaurora.org>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Michael Turquette <mturquette@baylibre.com>,
kernel-janitors@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Luis R . Rodriguez" <mcgrof@kernel.org>,
Josh Triplett <josh@joshtriplett.org>
Subject: Re: [PATCH 1/5] clk: qoriq: add __init attribute
Date: Mon, 18 Apr 2016 18:53:39 +0000 [thread overview]
Message-ID: <20160418185339.GC15324@codeaurora.org> (raw)
In-Reply-To: <1460991338-9845-2-git-send-email-Julia.Lawall@lip6.fr>
On 04/18, Julia Lawall wrote:
> Add __init attribute on a function that is only called from other __init
> functions and that is not inlined, at least with gcc version 4.8.4 on an
> x86 machine with allyesconfig. Currently, the function is put in the
> .text.unlikely segment. Declaring it as __init will cause it to be put in
> the .init.text and to disappear after initialization.
>
> The result of objdump -x on the function before the change is as follows:
>
> 0000000000000000 l F .text.unlikely 0000000000000071 sysclk_from_fixed.constprop.5
>
> And after the change it is as follows:
>
> 0000000000000480 l F .init.text 000000000000006c sysclk_from_fixed.constprop.5
>
> Done with the help of Coccinelle. The semantic patch checks for local
> static non-init functions that are called from an __init function and are
> not called from any other function.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
Applied to clk-next
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@codeaurora.org>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Michael Turquette <mturquette@baylibre.com>,
kernel-janitors@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Luis R . Rodriguez" <mcgrof@kernel.org>,
Josh Triplett <josh@joshtriplett.org>
Subject: Re: [PATCH 1/5] clk: qoriq: add __init attribute
Date: Mon, 18 Apr 2016 11:53:39 -0700 [thread overview]
Message-ID: <20160418185339.GC15324@codeaurora.org> (raw)
In-Reply-To: <1460991338-9845-2-git-send-email-Julia.Lawall@lip6.fr>
On 04/18, Julia Lawall wrote:
> Add __init attribute on a function that is only called from other __init
> functions and that is not inlined, at least with gcc version 4.8.4 on an
> x86 machine with allyesconfig. Currently, the function is put in the
> .text.unlikely segment. Declaring it as __init will cause it to be put in
> the .init.text and to disappear after initialization.
>
> The result of objdump -x on the function before the change is as follows:
>
> 0000000000000000 l F .text.unlikely 0000000000000071 sysclk_from_fixed.constprop.5
>
> And after the change it is as follows:
>
> 0000000000000480 l F .init.text 000000000000006c sysclk_from_fixed.constprop.5
>
> Done with the help of Coccinelle. The semantic patch checks for local
> static non-init functions that are called from an __init function and are
> not called from any other function.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
Applied to clk-next
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-04-18 18:53 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 14:55 [PATCH 0/5] add __init attribute Julia Lawall
2016-04-18 14:55 ` Julia Lawall
2016-04-18 14:55 ` Julia Lawall
2016-04-18 14:55 ` [PATCH 1/5] clk: qoriq: " Julia Lawall
2016-04-18 14:55 ` Julia Lawall
2016-04-18 18:53 ` Stephen Boyd [this message]
2016-04-18 18:53 ` Stephen Boyd
2016-04-18 14:55 ` [PATCH 2/5] arcnet: com90xx: " Julia Lawall
2016-04-18 14:55 ` Julia Lawall
2016-04-19 6:56 ` Michael Grzeschik
2016-04-19 6:56 ` Michael Grzeschik
2016-04-20 0:18 ` David Miller
2016-04-20 0:18 ` David Miller
2016-04-18 14:55 ` [PATCH 3/5] clocksource/drivers/mtk_timer: " Julia Lawall
2016-04-18 14:55 ` Julia Lawall
2016-04-18 14:55 ` Julia Lawall
2016-04-18 15:51 ` Matthias Brugger
2016-04-18 15:51 ` Matthias Brugger
2016-04-18 15:51 ` Matthias Brugger
2016-04-18 16:44 ` Daniel Lezcano
2016-04-18 16:44 ` Daniel Lezcano
2016-04-18 16:44 ` Daniel Lezcano
2016-04-18 14:55 ` [PATCH 4/5] TTY: " Julia Lawall
2016-04-18 14:55 ` Julia Lawall
2016-04-18 14:55 ` [PATCH 5/5] cmd640: " Julia Lawall
2016-04-18 14:55 ` Julia Lawall
2016-07-26 22:26 ` David Miller
2016-07-26 22:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160418185339.GC15324@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=Julia.Lawall@lip6.fr \
--cc=josh@joshtriplett.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.