From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Joshua Kinard <kumba@gentoo.org>,
Alessandro Zummo <a.zummo@towertech.it>,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org
Subject: [rtc-linux] Re: [PATCH] rtc: ds1685: actually spin forever in poweroff path, part 2
Date: Tue, 19 Apr 2016 00:34:31 +0200 [thread overview]
Message-ID: <20160418223431.GC25196@piout.net> (raw)
In-Reply-To: <97e46f7b50b413d01be4189159c0611515ef7502.1460729962.git.jpoimboe@redhat.com>
On 15/04/2016 at 09:21:10 -0500, Josh Poimboeuf wrote :
> objtool reports the following warning:
>
> drivers/rtc/rtc-ds1685.o: warning: objtool: ds1685_rtc_poweroff() falls through to next function ds1685_rtc_work_queue()
>
> Similar to commit 361c6ed6b153 ("rtc: ds1685: actually spin forever in
> poweroff error path"), there's another unreachable() annotation which is
> actually reachable, which we missed the first time.
>
> Actually spin forever to be consistent with the comment and to make the
> unreachable() annotation guaranteed to be unreachable.
>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Joshua Kinard <kumba@gentoo.org>,
Alessandro Zummo <a.zummo@towertech.it>,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtc: ds1685: actually spin forever in poweroff path, part 2
Date: Tue, 19 Apr 2016 00:34:31 +0200 [thread overview]
Message-ID: <20160418223431.GC25196@piout.net> (raw)
In-Reply-To: <97e46f7b50b413d01be4189159c0611515ef7502.1460729962.git.jpoimboe@redhat.com>
On 15/04/2016 at 09:21:10 -0500, Josh Poimboeuf wrote :
> objtool reports the following warning:
>
> drivers/rtc/rtc-ds1685.o: warning: objtool: ds1685_rtc_poweroff() falls through to next function ds1685_rtc_work_queue()
>
> Similar to commit 361c6ed6b153 ("rtc: ds1685: actually spin forever in
> poweroff error path"), there's another unreachable() annotation which is
> actually reachable, which we missed the first time.
>
> Actually spin forever to be consistent with the comment and to make the
> unreachable() annotation guaranteed to be unreachable.
>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-04-18 22:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-15 14:21 [rtc-linux] [PATCH] rtc: ds1685: actually spin forever in poweroff path, part 2 Josh Poimboeuf
2016-04-15 14:21 ` Josh Poimboeuf
2016-04-18 22:34 ` Alexandre Belloni [this message]
2016-04-18 22:34 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160418223431.GC25196@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=jpoimboe@redhat.com \
--cc=kumba@gentoo.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.