All of lore.kernel.org
 help / color / mirror / Atom feed
From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 0/3] dmaengine: bcm2835: support dma channel 11 to 14
Date: Tue, 19 Apr 2016 21:03:20 +0530	[thread overview]
Message-ID: <20160419153320.GT2274@localhost> (raw)
In-Reply-To: <1460381349-14408-1-git-send-email-kernel@martin.sperl.org>

On Mon, Apr 11, 2016 at 01:29:06PM +0000, kernel at martin.sperl.org wrote:
> From: Martin Sperl <kernel@martin.sperl.org>
> 
> Right now the dma engine officially supports dma channel 11 and 12.
> But the use of dma channel 12 immediately stalls the system.
> 
> The reason is that the interrupt assigned right now to dma channel 11
> is actually a shared interrupt for dma channels 11 to 12.
> So whenever the dma channel 12, 13 or 14 is used, it triggers the interrupt
> for dma 11 which only clears the interrupt flag for dma channel 11.
> This results in the interrupt 11 is triggered all the time.
> 
> On top the requesting dma channel12 (and the corresponding irq) triggers
> an immeditate stall of the system, because for the 12th interrupt
> any dma channel will trigger also this interrupt - even if the dma channel
> is controlled by the firmware.
> 
> As the description in the default device-tree is (for the above reasons)
> wrong a new means had to get devised that allows correct representation
> of the mapping between interrupts and dma channels.
> 
> For this the existing (but unused) device-tree property "interrupt-names"
> is used to define the mapping.
> 
> Implementing shared interrupts is another necessity when using dma channel
> 11 to 14, so it is a part of this patch.

Applied, thanks

-- 
~Vinod

WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
	Lee Jones <lee-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Eric Anholt <eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org>,
	Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH V2 0/3] dmaengine: bcm2835: support dma channel 11 to 14
Date: Tue, 19 Apr 2016 21:03:20 +0530	[thread overview]
Message-ID: <20160419153320.GT2274@localhost> (raw)
In-Reply-To: <1460381349-14408-1-git-send-email-kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>

On Mon, Apr 11, 2016 at 01:29:06PM +0000, kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org wrote:
> From: Martin Sperl <kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>
> 
> Right now the dma engine officially supports dma channel 11 and 12.
> But the use of dma channel 12 immediately stalls the system.
> 
> The reason is that the interrupt assigned right now to dma channel 11
> is actually a shared interrupt for dma channels 11 to 12.
> So whenever the dma channel 12, 13 or 14 is used, it triggers the interrupt
> for dma 11 which only clears the interrupt flag for dma channel 11.
> This results in the interrupt 11 is triggered all the time.
> 
> On top the requesting dma channel12 (and the corresponding irq) triggers
> an immeditate stall of the system, because for the 12th interrupt
> any dma channel will trigger also this interrupt - even if the dma channel
> is controlled by the firmware.
> 
> As the description in the default device-tree is (for the above reasons)
> wrong a new means had to get devised that allows correct representation
> of the mapping between interrupts and dma channels.
> 
> For this the existing (but unused) device-tree property "interrupt-names"
> is used to define the mapping.
> 
> Implementing shared interrupts is another necessity when using dma channel
> 11 to 14, so it is a part of this patch.

Applied, thanks

-- 
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2016-04-19 15:33 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-11 13:29 [PATCH V2 0/3] dmaengine: bcm2835: support dma channel 11 to 14 kernel at martin.sperl.org
2016-04-11 13:29 ` kernel-TqfNSX0MhmxHKSADF0wUEw
2016-04-11 13:29 ` [PATCH V2 1/3] dt/bindings: bcm2835: add interrupt-names property kernel at martin.sperl.org
2016-04-11 13:29   ` kernel-TqfNSX0MhmxHKSADF0wUEw
2016-04-11 13:29 ` [PATCH V2 2/3] dmaengine: bcm2835: use platform_get_irq_byname kernel at martin.sperl.org
2016-04-11 13:29   ` kernel-TqfNSX0MhmxHKSADF0wUEw
2016-04-20  6:51   ` Geert Uytterhoeven
2016-04-20  6:51     ` Geert Uytterhoeven
2016-04-20 11:06     ` Martin Sperl
2016-04-20 11:06       ` Martin Sperl
2016-04-20 11:12       ` Geert Uytterhoeven
2016-04-20 11:12         ` Geert Uytterhoeven
2016-04-20 13:11         ` Vinod Koul
2016-04-20 13:11           ` Vinod Koul
2016-04-11 13:29 ` [PATCH V2 3/3] ARM: bcm2835: add interrupt-names and apply correct mapping kernel at martin.sperl.org
2016-04-11 13:29   ` kernel-TqfNSX0MhmxHKSADF0wUEw
2016-04-19 15:33 ` Vinod Koul [this message]
2016-04-19 15:33   ` [PATCH V2 0/3] dmaengine: bcm2835: support dma channel 11 to 14 Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160419153320.GT2274@localhost \
    --to=vinod.koul@intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.