From: lorenzo.pieralisi@arm.com (Lorenzo Pieralisi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drivers: firmware: psci: add __init mark to psci_dt_cpu_init_idle
Date: Tue, 19 Apr 2016 18:15:12 +0100 [thread overview]
Message-ID: <20160419171511.GA2939@red-moon> (raw)
In-Reply-To: <57164CC6.1010201@arm.com>
On Tue, Apr 19, 2016 at 04:20:38PM +0100, Sudeep Holla wrote:
>
>
> On 19/04/16 16:05, Lorenzo Pieralisi wrote:
> >Hi Jisheng,
> >
> >On Tue, Mar 22, 2016 at 10:35:29PM +0800, Jisheng Zhang wrote:
> >>psci_dt_cpu_init_idle() and psci_cpu_init_idle() are not needed after
> >>booting, so mark them as __init.
> >>
>
> On the other hand, when I was trying to reuse arm_cpuidle_init to
> support ACPI LPIs, I found that we may need to remove __init tag on it
> as it gets called by hotplug notifiers in ACPI context.
>
> I am not objecting this change, just mentioning with the hope to get
> solution to the above issue.
Yep, good point, it is not strictly necessary to merge it either
and I would avoid churning out changes given that we know we will
require to remove those __init tags anyway, so patch dropped.
Lorenzo
WARNING: multiple messages have this Message-ID (diff)
From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: Jisheng Zhang <jszhang@marvell.com>,
mark.rutland@arm.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drivers: firmware: psci: add __init mark to psci_dt_cpu_init_idle
Date: Tue, 19 Apr 2016 18:15:12 +0100 [thread overview]
Message-ID: <20160419171511.GA2939@red-moon> (raw)
In-Reply-To: <57164CC6.1010201@arm.com>
On Tue, Apr 19, 2016 at 04:20:38PM +0100, Sudeep Holla wrote:
>
>
> On 19/04/16 16:05, Lorenzo Pieralisi wrote:
> >Hi Jisheng,
> >
> >On Tue, Mar 22, 2016 at 10:35:29PM +0800, Jisheng Zhang wrote:
> >>psci_dt_cpu_init_idle() and psci_cpu_init_idle() are not needed after
> >>booting, so mark them as __init.
> >>
>
> On the other hand, when I was trying to reuse arm_cpuidle_init to
> support ACPI LPIs, I found that we may need to remove __init tag on it
> as it gets called by hotplug notifiers in ACPI context.
>
> I am not objecting this change, just mentioning with the hope to get
> solution to the above issue.
Yep, good point, it is not strictly necessary to merge it either
and I would avoid churning out changes given that we know we will
require to remove those __init tags anyway, so patch dropped.
Lorenzo
next prev parent reply other threads:[~2016-04-19 17:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 14:35 [PATCH] drivers: firmware: psci: add __init mark to psci_dt_cpu_init_idle Jisheng Zhang
2016-03-22 14:35 ` Jisheng Zhang
2016-04-19 15:05 ` Lorenzo Pieralisi
2016-04-19 15:05 ` Lorenzo Pieralisi
2016-04-19 15:20 ` Sudeep Holla
2016-04-19 15:20 ` Sudeep Holla
2016-04-19 17:15 ` Lorenzo Pieralisi [this message]
2016-04-19 17:15 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160419171511.GA2939@red-moon \
--to=lorenzo.pieralisi@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.