From: "Michael S. Tsirkin" <mst@redhat.com>
To: Liang Li <liang.z.li@intel.com>
Cc: quintela@redhat.com, amit.shah@redhat.com, pbonzini@redhat.com,
lcapitulino@redhat.com, armbru@redhat.com,
peter.maydell@linaro.org, rth@twiddle.net, ehabkost@redhat.com,
james.hogan@imgtec.com, aurelien@aurel32.net,
leon.alrae@imgtec.com, agraf@suse.de, borntraeger@de.ibm.com,
cornelia.huck@de.ibm.com, qemu-devel@nongnu.org,
kvm@vger.kernel.org
Subject: Re: [PATCH QEMU 3/5] virtio-balloon: Add a new feature to balloon device
Date: Tue, 19 Apr 2016 19:32:33 +0300 [thread overview]
Message-ID: <20160419192925-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <1461075643-3668-4-git-send-email-liang.z.li@intel.com>
On Tue, Apr 19, 2016 at 10:20:41PM +0800, Liang Li wrote:
> + if (s->req_status == REQ_INIT) {
> + s->free_page_bmap = bitmap;
> + if (elem == NULL || !elem->in_num) {
> + elem = virtqueue_pop(s->fvq, sizeof(VirtQueueElement));
> + if (!elem) {
> + return FREE_PAGE_ERROR;
> + }
> + s->free_page_vq_elem = elem;
> + }
> + s->free_page_req.param = drop_cache_ctl;
Dropping cache should probably be a separate request -
seems independently useful.
--
MST
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Liang Li <liang.z.li@intel.com>
Cc: quintela@redhat.com, amit.shah@redhat.com, pbonzini@redhat.com,
lcapitulino@redhat.com, armbru@redhat.com,
peter.maydell@linaro.org, rth@twiddle.net, ehabkost@redhat.com,
james.hogan@imgtec.com, aurelien@aurel32.net,
leon.alrae@imgtec.com, agraf@suse.de, borntraeger@de.ibm.com,
cornelia.huck@de.ibm.com, qemu-devel@nongnu.org,
kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH QEMU 3/5] virtio-balloon: Add a new feature to balloon device
Date: Tue, 19 Apr 2016 19:32:33 +0300 [thread overview]
Message-ID: <20160419192925-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <1461075643-3668-4-git-send-email-liang.z.li@intel.com>
On Tue, Apr 19, 2016 at 10:20:41PM +0800, Liang Li wrote:
> + if (s->req_status == REQ_INIT) {
> + s->free_page_bmap = bitmap;
> + if (elem == NULL || !elem->in_num) {
> + elem = virtqueue_pop(s->fvq, sizeof(VirtQueueElement));
> + if (!elem) {
> + return FREE_PAGE_ERROR;
> + }
> + s->free_page_vq_elem = elem;
> + }
> + s->free_page_req.param = drop_cache_ctl;
Dropping cache should probably be a separate request -
seems independently useful.
--
MST
next prev parent reply other threads:[~2016-04-19 16:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-19 14:20 [PATCH QEMU 0/5] spee up live migration by skipping free pages Liang Li
2016-04-19 14:20 ` [Qemu-devel] " Liang Li
2016-04-19 14:20 ` [PATCH QEMU 1/5] bitmap: Add a new bitmap_move function Liang Li
2016-04-19 14:20 ` [Qemu-devel] " Liang Li
2016-04-19 14:20 ` [PATCH QEMU 2/5] kvm: Add two new arch specific functions Liang Li
2016-04-19 14:20 ` [Qemu-devel] " Liang Li
2016-04-19 14:20 ` [PATCH QEMU 3/5] virtio-balloon: Add a new feature to balloon device Liang Li
2016-04-19 14:20 ` [Qemu-devel] " Liang Li
2016-04-19 16:32 ` Michael S. Tsirkin [this message]
2016-04-19 16:32 ` Michael S. Tsirkin
2016-04-19 14:20 ` [PATCH QEMU 4/5] migration: filter out free pages during live migration Liang Li
2016-04-19 14:20 ` [Qemu-devel] " Liang Li
2016-04-19 14:20 ` [PATCH QEMU 5/5] migration: Add the interface for cache drop control Liang Li
2016-04-19 14:20 ` [Qemu-devel] " Liang Li
2016-04-19 14:52 ` Eric Blake
2016-04-19 14:59 ` Li, Liang Z
2016-04-19 14:59 ` Li, Liang Z
2016-04-19 14:37 ` [PATCH QEMU 0/5] spee up live migration by skipping free pages Alexander Graf
2016-04-19 14:37 ` [Qemu-devel] " Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160419192925-mutt-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=agraf@suse.de \
--cc=amit.shah@redhat.com \
--cc=armbru@redhat.com \
--cc=aurelien@aurel32.net \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=ehabkost@redhat.com \
--cc=james.hogan@imgtec.com \
--cc=kvm@vger.kernel.org \
--cc=lcapitulino@redhat.com \
--cc=leon.alrae@imgtec.com \
--cc=liang.z.li@intel.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.