From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3] c-icap: bump to version 0.4.2
Date: Tue, 19 Apr 2016 21:16:02 +0200 [thread overview]
Message-ID: <20160419211602.7bca70f5@free-electrons.com> (raw)
In-Reply-To: <3280a03616963d1b2a5bfa3120390bcd59bee470.1461089746.git.baruch@tkos.co.il>
Hello,
On Tue, 19 Apr 2016 21:15:45 +0300, Baruch Siach wrote:
> +C_ICAP_CONF_ENV = ac_cv_10031b_ipc_sem=yes ac_cv_fcntl=yes
These look a bit special/weird, especially ac_cv_fcntl=yes. Normally
for functions, the cache variable is named ac_cv_func_<function>, and
the checks don't need to pre-seed cache variable values.
Can you add a comment on top of this line that explains why those two
values need to be passed? Or at least, it should be explained in the
commit log (but a comment in the code is better IMO).
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-04-19 19:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-19 18:15 [Buildroot] [PATCH 1/3] c-icap: avoid host library search path Baruch Siach
2016-04-19 18:15 ` [Buildroot] [PATCH 2/3] c-icap: bump to version 0.4.2 Baruch Siach
2016-04-19 19:16 ` Thomas Petazzoni [this message]
2016-04-20 4:28 ` Baruch Siach
2016-04-20 8:06 ` Thomas Petazzoni
2016-04-19 18:15 ` [Buildroot] [PATCH 3/3] c-icap-modules: " Baruch Siach
2016-04-19 19:14 ` [Buildroot] [PATCH 1/3] c-icap: avoid host library search path Thomas Petazzoni
2016-04-20 4:31 ` Baruch Siach
2016-04-20 18:04 ` Baruch Siach
2016-04-20 19:20 ` Thomas Petazzoni
2016-04-20 19:37 ` Baruch Siach
2016-04-20 21:35 ` Arnout Vandecappelle
2016-04-21 6:58 ` Baruch Siach
2016-04-21 13:17 ` Arnout Vandecappelle
2016-04-19 21:53 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160419211602.7bca70f5@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.