From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Jisheng Zhang <jszhang@marvell.com>
Cc: linux@arm.linux.org.uk, mark.rutland@arm.com,
andy.gross@linaro.org, david.brown@linaro.org,
daniel.lezcano@linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-soc@vger.kernel.org
Subject: Re: [PATCH 4/4] drivers: firmware: psci: use const and __initconst for psci_cpuidle_ops
Date: Wed, 20 Apr 2016 09:40:10 +0100 [thread overview]
Message-ID: <20160420084010.GB3824@red-moon> (raw)
In-Reply-To: <1458657763-2561-5-git-send-email-jszhang@marvell.com>
On Tue, Mar 22, 2016 at 10:42:43PM +0800, Jisheng Zhang wrote:
> The psci_cpuidle_ops structures is not over-written, so add "const"
> qualifier and replace __initdata with __initconst.
>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> ---
> drivers/firmware/psci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> diff --git a/drivers/firmware/psci.c b/drivers/firmware/psci.c
> index 6d86881..7d52186 100644
> --- a/drivers/firmware/psci.c
> +++ b/drivers/firmware/psci.c
> @@ -355,7 +355,7 @@ int psci_cpu_suspend_enter(unsigned long index)
>
> /* ARM specific CPU idle operations */
> #ifdef CONFIG_ARM
> -static struct cpuidle_ops psci_cpuidle_ops __initdata = {
> +static const struct cpuidle_ops psci_cpuidle_ops __initconst = {
> .suspend = psci_cpu_suspend_enter,
> .init = psci_dt_cpu_init_idle,
> };
> --
> 2.8.0.rc3
>
WARNING: multiple messages have this Message-ID (diff)
From: lorenzo.pieralisi@arm.com (Lorenzo Pieralisi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] drivers: firmware: psci: use const and __initconst for psci_cpuidle_ops
Date: Wed, 20 Apr 2016 09:40:10 +0100 [thread overview]
Message-ID: <20160420084010.GB3824@red-moon> (raw)
In-Reply-To: <1458657763-2561-5-git-send-email-jszhang@marvell.com>
On Tue, Mar 22, 2016 at 10:42:43PM +0800, Jisheng Zhang wrote:
> The psci_cpuidle_ops structures is not over-written, so add "const"
> qualifier and replace __initdata with __initconst.
>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> ---
> drivers/firmware/psci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> diff --git a/drivers/firmware/psci.c b/drivers/firmware/psci.c
> index 6d86881..7d52186 100644
> --- a/drivers/firmware/psci.c
> +++ b/drivers/firmware/psci.c
> @@ -355,7 +355,7 @@ int psci_cpu_suspend_enter(unsigned long index)
>
> /* ARM specific CPU idle operations */
> #ifdef CONFIG_ARM
> -static struct cpuidle_ops psci_cpuidle_ops __initdata = {
> +static const struct cpuidle_ops psci_cpuidle_ops __initconst = {
> .suspend = psci_cpu_suspend_enter,
> .init = psci_dt_cpu_init_idle,
> };
> --
> 2.8.0.rc3
>
next prev parent reply other threads:[~2016-04-20 8:40 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 14:42 [PATCH 0/4] ARM: cpuidle: use const and __initconst for cpuidle_ops Jisheng Zhang
2016-03-22 14:42 ` Jisheng Zhang
2016-03-22 14:42 ` Jisheng Zhang
2016-03-22 14:42 ` [PATCH 1/4] ARM: cpuidle: add const qualifier to cpuidle_ops member in structures Jisheng Zhang
2016-03-22 14:42 ` Jisheng Zhang
2016-03-22 14:42 ` Jisheng Zhang
2016-03-22 14:42 ` [PATCH 2/4] ARM: cpuidle: constify return value of arm_cpuidle_get_ops() Jisheng Zhang
2016-03-22 14:42 ` Jisheng Zhang
2016-03-22 14:42 ` Jisheng Zhang
2016-03-22 14:42 ` [PATCH 3/4] soc: qcom: spm: use const and __initconst for qcom_cpuidle_ops Jisheng Zhang
2016-03-22 14:42 ` Jisheng Zhang
2016-03-22 14:42 ` Jisheng Zhang
2016-04-19 18:52 ` Andy Gross
2016-04-19 18:52 ` Andy Gross
2016-03-22 14:42 ` [PATCH 4/4] drivers: firmware: psci: use const and __initconst for psci_cpuidle_ops Jisheng Zhang
2016-03-22 14:42 ` Jisheng Zhang
2016-03-22 14:42 ` Jisheng Zhang
2016-04-20 8:40 ` Lorenzo Pieralisi [this message]
2016-04-20 8:40 ` Lorenzo Pieralisi
2016-03-25 11:26 ` [PATCH 0/4] ARM: cpuidle: use const and __initconst for cpuidle_ops Daniel Lezcano
2016-03-25 11:26 ` Daniel Lezcano
2016-04-19 17:31 ` Lorenzo Pieralisi
2016-04-19 17:31 ` Lorenzo Pieralisi
2016-04-19 17:33 ` Daniel Lezcano
2016-04-19 17:33 ` Daniel Lezcano
2016-04-20 5:01 ` Daniel Lezcano
2016-04-20 5:01 ` Daniel Lezcano
-- strict thread matches above, loose matches on Subject: below --
2016-04-22 8:30 [PULL] ARM: cpuidle: changes for 4.7 Daniel Lezcano
2016-04-22 8:31 ` [PATCH 1/4] ARM: cpuidle: add const qualifier to cpuidle_ops member in structures Daniel Lezcano
2016-04-22 8:31 ` [PATCH 4/4] drivers: firmware: psci: use const and __initconst for psci_cpuidle_ops Daniel Lezcano
2016-04-22 8:31 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160420084010.GB3824@red-moon \
--to=lorenzo.pieralisi@arm.com \
--cc=andy.gross@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=david.brown@linaro.org \
--cc=jszhang@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.