All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Saitz <ingo@stud.uni-hannover.de>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: Ingo Saitz <ingo@stud.uni-hannover.de>, netdev@vger.kernel.org
Subject: Re: skb_at_tc_ingress helper breaks compilation of oot modules
Date: Wed, 20 Apr 2016 12:53:54 +0200	[thread overview]
Message-ID: <20160420105354.GA12348@pinguin.zoo> (raw)
In-Reply-To: <57175C13.8080109@iogearbox.net>

On Wed, Apr 20, 2016 at 12:38:11PM +0200, Daniel Borkmann wrote:
> Hmm, your fail.c test case only contains '#include <net/ipv6.h>'?

No, only when building oot modules (virtualbox, and I found batman-adv
having the same issue), so I reduced it to the most simple test case. This
actually builds a fail.ko on 4.4.7 with CONFIG_NET_CLS_ACT=y without
errors.

> Note, upstream kernel never cared about out-of-tree modules, only
> in-tree code. ;) Did you run into an issue with any in-tree code?

A current fix for oot modules would be to add:

#include <uapi/linux/pkt_cls.h>

in front of that include for kernel >= 4.5…

    Ingo
-- 
Kennedy's Lemma:
    If you can parse Perl, you can solve the Halting Problem.

http://www.perlmonks.org/?node_id=663393

  reply	other threads:[~2016-04-20 10:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-20 10:21 skb_at_tc_ingress helper breaks compilation of oot modules Ingo Saitz
2016-04-20 10:38 ` Daniel Borkmann
2016-04-20 10:53   ` Ingo Saitz [this message]
2016-04-20 17:33   ` Alexei Starovoitov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160420105354.GA12348@pinguin.zoo \
    --to=ingo@stud.uni-hannover.de \
    --cc=daniel@iogearbox.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.