All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Borkmann <daniel@iogearbox.net>
To: Ingo Saitz <ingo@stud.uni-hannover.de>
Cc: netdev@vger.kernel.org
Subject: Re: skb_at_tc_ingress helper breaks compilation of oot modules
Date: Wed, 20 Apr 2016 12:38:11 +0200	[thread overview]
Message-ID: <57175C13.8080109@iogearbox.net> (raw)
In-Reply-To: <20160420102148.GA18615@echse.zoo>

On 04/20/2016 12:21 PM, Ingo Saitz wrote:
> In Linux 4.5, when CONFIG_NET_CLS_ACT is defined, compilation of out of
> tree modules breaks with undeclared functions/constants. The culprit is:
>
> commit fdc5432a7b44ab7de17141beec19d946b9344e91
> Author: Daniel Borkmann <daniel@iogearbox.net>
> Date:   Thu Jan 7 15:50:22 2016 +0100
>
>      net, sched: add skb_at_tc_ingress helper
>
> which uses G_TC_AT and AT_INGRESS but only includes linux/pkt_cls.h,
> which does not include these #defines for oot builds. Unfortunately I'm
> not sure what the correct fix is, maybe the uapi folks could help, but i
> attached a simple testcase and build log (Makefile is straight from
> kernelnewbies).

Hmm, your fail.c test case only contains '#include <net/ipv6.h>'?

Note, upstream kernel never cared about out-of-tree modules, only
in-tree code. ;) Did you run into an issue with any in-tree code?

Thanks,
Daniel

  reply	other threads:[~2016-04-20 10:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-20 10:21 skb_at_tc_ingress helper breaks compilation of oot modules Ingo Saitz
2016-04-20 10:38 ` Daniel Borkmann [this message]
2016-04-20 10:53   ` Ingo Saitz
2016-04-20 17:33   ` Alexei Starovoitov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57175C13.8080109@iogearbox.net \
    --to=daniel@iogearbox.net \
    --cc=ingo@stud.uni-hannover.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.