[PATCH] ne10: use bb.debug for debug messages

[PATCH] ne10: use bb.debug for debug messages

[Denys Dmytriyenko]

From: Denys Dmytriyenko <denys@ti.com>

Moreover, the messages are misleading, saying "Building for arch blah",
even when this recipe is not being built. It merely checks if the recipe
is cmaptible with the currently used architecture.

Signed-off-by: Denys Dmytriyenko <denys@ti.com>
---
 meta-oe/recipes-support/ne10/ne10_1.2.1.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta-oe/recipes-support/ne10/ne10_1.2.1.bb b/meta-oe/recipes-support/ne10/ne10_1.2.1.bb
index 4d753a0..de97982 100644
--- a/meta-oe/recipes-support/ne10/ne10_1.2.1.bb
+++ b/meta-oe/recipes-support/ne10/ne10_1.2.1.bb
@@ -20,10 +20,10 @@ COMPATIBLE_MACHINE_armv7a = "(.*)"
 python () {
     if any(t.startswith('armv7') for t in d.getVar('TUNE_FEATURES', True).split()):
         d.setVar('NE10_TARGET_ARCH', 'armv7')
-        bb.note('Building Ne10 for armv7')
+        bb.debug(2, 'Building Ne10 for armv7')
     elif any(t.startswith('aarch64') for t in d.getVar('TUNE_FEATURES', True).split()):
         d.setVar('NE10_TARGET_ARCH', 'aarch64')
-        bb.note('Building Ne10 for aarch64')
+        bb.debug(2, 'Building Ne10 for aarch64')
     else:
         raise bb.parse.SkipPackage("Incompatible with archs other than armv7 and aarch64")
 }
-- 
2.2.0

Re: [PATCH] ne10: use bb.debug for debug messages

[Khem Raj]

On Thu, Apr 7, 2016 at 1:40 PM, Denys Dmytriyenko <denis@denix.org> wrote:
> From: Denys Dmytriyenko <denys@ti.com>
>
> Moreover, the messages are misleading, saying "Building for arch blah",
> even when this recipe is not being built. It merely checks if the recipe
> is cmaptible with the currently used architecture.
>

LGTM, I have been seeing these notes too.

> Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> ---
>  meta-oe/recipes-support/ne10/ne10_1.2.1.bb | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta-oe/recipes-support/ne10/ne10_1.2.1.bb b/meta-oe/recipes-support/ne10/ne10_1.2.1.bb
> index 4d753a0..de97982 100644
> --- a/meta-oe/recipes-support/ne10/ne10_1.2.1.bb
> +++ b/meta-oe/recipes-support/ne10/ne10_1.2.1.bb
> @@ -20,10 +20,10 @@ COMPATIBLE_MACHINE_armv7a = "(.*)"
>  python () {
>      if any(t.startswith('armv7') for t in d.getVar('TUNE_FEATURES', True).split()):
>          d.setVar('NE10_TARGET_ARCH', 'armv7')
> -        bb.note('Building Ne10 for armv7')
> +        bb.debug(2, 'Building Ne10 for armv7')
>      elif any(t.startswith('aarch64') for t in d.getVar('TUNE_FEATURES', True).split()):
>          d.setVar('NE10_TARGET_ARCH', 'aarch64')
> -        bb.note('Building Ne10 for aarch64')
> +        bb.debug(2, 'Building Ne10 for aarch64')
>      else:
>          raise bb.parse.SkipPackage("Incompatible with archs other than armv7 and aarch64")
>  }
> --
> 2.2.0
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [PATCH] ne10: use bb.debug for debug messages

[Denys Dmytriyenko]

Ping. Also in master-next for over a week - how often does it get merged to 
master?


On Thu, Apr 07, 2016 at 04:40:00PM -0400, Denys Dmytriyenko wrote:
> From: Denys Dmytriyenko <denys@ti.com>
> 
> Moreover, the messages are misleading, saying "Building for arch blah",
> even when this recipe is not being built. It merely checks if the recipe
> is cmaptible with the currently used architecture.
> 
> Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> ---
>  meta-oe/recipes-support/ne10/ne10_1.2.1.bb | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta-oe/recipes-support/ne10/ne10_1.2.1.bb b/meta-oe/recipes-support/ne10/ne10_1.2.1.bb
> index 4d753a0..de97982 100644
> --- a/meta-oe/recipes-support/ne10/ne10_1.2.1.bb
> +++ b/meta-oe/recipes-support/ne10/ne10_1.2.1.bb
> @@ -20,10 +20,10 @@ COMPATIBLE_MACHINE_armv7a = "(.*)"
>  python () {
>      if any(t.startswith('armv7') for t in d.getVar('TUNE_FEATURES', True).split()):
>          d.setVar('NE10_TARGET_ARCH', 'armv7')
> -        bb.note('Building Ne10 for armv7')
> +        bb.debug(2, 'Building Ne10 for armv7')
>      elif any(t.startswith('aarch64') for t in d.getVar('TUNE_FEATURES', True).split()):
>          d.setVar('NE10_TARGET_ARCH', 'aarch64')
> -        bb.note('Building Ne10 for aarch64')
> +        bb.debug(2, 'Building Ne10 for aarch64')
>      else:
>          raise bb.parse.SkipPackage("Incompatible with archs other than armv7 and aarch64")
>  }
> -- 
> 2.2.0
> 
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [PATCH] ne10: use bb.debug for debug messages

[Martin Jansa]

When everything is at least once tested in my jenkins builds and I've time
to go through the list of pending changes.

I was away from computers almost whole previous week, so there is longer
delay now.

On Wed, Apr 20, 2016 at 8:25 PM, Denys Dmytriyenko <denis@denix.org> wrote:

> Ping. Also in master-next for over a week - how often does it get merged to
> master?
>
>
> On Thu, Apr 07, 2016 at 04:40:00PM -0400, Denys Dmytriyenko wrote:
> > From: Denys Dmytriyenko <denys@ti.com>
> >
> > Moreover, the messages are misleading, saying "Building for arch blah",
> > even when this recipe is not being built. It merely checks if the recipe
> > is cmaptible with the currently used architecture.
> >
> > Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> > ---
> >  meta-oe/recipes-support/ne10/ne10_1.2.1.bb | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/meta-oe/recipes-support/ne10/ne10_1.2.1.bb
> b/meta-oe/recipes-support/ne10/ne10_1.2.1.bb
> > index 4d753a0..de97982 100644
> > --- a/meta-oe/recipes-support/ne10/ne10_1.2.1.bb
> > +++ b/meta-oe/recipes-support/ne10/ne10_1.2.1.bb
> > @@ -20,10 +20,10 @@ COMPATIBLE_MACHINE_armv7a = "(.*)"
> >  python () {
> >      if any(t.startswith('armv7') for t in d.getVar('TUNE_FEATURES',
> True).split()):
> >          d.setVar('NE10_TARGET_ARCH', 'armv7')
> > -        bb.note('Building Ne10 for armv7')
> > +        bb.debug(2, 'Building Ne10 for armv7')
> >      elif any(t.startswith('aarch64') for t in d.getVar('TUNE_FEATURES',
> True).split()):
> >          d.setVar('NE10_TARGET_ARCH', 'aarch64')
> > -        bb.note('Building Ne10 for aarch64')
> > +        bb.debug(2, 'Building Ne10 for aarch64')
> >      else:
> >          raise bb.parse.SkipPackage("Incompatible with archs other than
> armv7 and aarch64")
> >  }
> > --
> > 2.2.0
> >
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>

Re: [PATCH] ne10: use bb.debug for debug messages

[Denys Dmytriyenko]

On Wed, Apr 20, 2016 at 10:44:04PM +0200, Martin Jansa wrote:
> When everything is at least once tested in my jenkins builds and I've time
> to go through the list of pending changes.
> 
> I was away from computers almost whole previous week, so there is longer
> delay now.

Thanks, no problem and congrats!


> On Wed, Apr 20, 2016 at 8:25 PM, Denys Dmytriyenko <denis@denix.org> wrote:
> 
> > Ping. Also in master-next for over a week - how often does it get merged to
> > master?
> >
> >
> > On Thu, Apr 07, 2016 at 04:40:00PM -0400, Denys Dmytriyenko wrote:
> > > From: Denys Dmytriyenko <denys@ti.com>
> > >
> > > Moreover, the messages are misleading, saying "Building for arch blah",
> > > even when this recipe is not being built. It merely checks if the recipe
> > > is cmaptible with the currently used architecture.
> > >
> > > Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> > > ---
> > >  meta-oe/recipes-support/ne10/ne10_1.2.1.bb | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/meta-oe/recipes-support/ne10/ne10_1.2.1.bb
> > b/meta-oe/recipes-support/ne10/ne10_1.2.1.bb
> > > index 4d753a0..de97982 100644
> > > --- a/meta-oe/recipes-support/ne10/ne10_1.2.1.bb
> > > +++ b/meta-oe/recipes-support/ne10/ne10_1.2.1.bb
> > > @@ -20,10 +20,10 @@ COMPATIBLE_MACHINE_armv7a = "(.*)"
> > >  python () {
> > >      if any(t.startswith('armv7') for t in d.getVar('TUNE_FEATURES',
> > True).split()):
> > >          d.setVar('NE10_TARGET_ARCH', 'armv7')
> > > -        bb.note('Building Ne10 for armv7')
> > > +        bb.debug(2, 'Building Ne10 for armv7')
> > >      elif any(t.startswith('aarch64') for t in d.getVar('TUNE_FEATURES',
> > True).split()):
> > >          d.setVar('NE10_TARGET_ARCH', 'aarch64')
> > > -        bb.note('Building Ne10 for aarch64')
> > > +        bb.debug(2, 'Building Ne10 for aarch64')
> > >      else:
> > >          raise bb.parse.SkipPackage("Incompatible with archs other than
> > armv7 and aarch64")
> > >  }
> > > --
> > > 2.2.0
> > >
> > > --
> > > _______________________________________________
> > > Openembedded-devel mailing list
> > > Openembedded-devel@lists.openembedded.org
> > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel