Re: [master/fido][PATCH 1/2] ipc-transport: Clean up recipe

[Denys Dmytriyenko <denys@ti.com>]

On Wed, Apr 20, 2016 at 07:30:33PM +0000, Sobota, Justin wrote:
> 
> 
> -----Original Message-----
> From: Stiffler, Jacob 
> Sent: Wednesday, April 20, 2016 3:00 PM
> To: Sobota, Justin; meta-ti@yoctoproject.org
> Subject: Re: [meta-ti] [master/fido][PATCH 1/2] ipc-transport: Clean up recipe
> 
> 
> 
> On 4/20/2016 2:46 PM, Justin Sobota wrote:
> > Signed-off-by: Justin Sobota <jsobota@ti.com>
> > ---
> >   recipes-ti/ipc/ipc-transport-qmss.inc |    4 +++-
> >   recipes-ti/ipc/ipc-transport-srio.inc |    4 +++-
> >   recipes-ti/ipc/ipc-transport.inc      |   14 ++++++++------
> >   3 files changed, 14 insertions(+), 8 deletions(-)
> >
> > diff --git a/recipes-ti/ipc/ipc-transport-qmss.inc 
> > b/recipes-ti/ipc/ipc-transport-qmss.inc
> > index a5c8dc4..7539ef5 100644
> > --- a/recipes-ti/ipc/ipc-transport-qmss.inc
> > +++ b/recipes-ti/ipc/ipc-transport-qmss.inc
> > @@ -3,7 +3,9 @@ LICENSE = "BSD-3-Clause"
> >   
> >   require ipc-transport.inc
> >   
> > -INC_PR_append = ".0"
> > +PR = "${INC_PR}.1"
> 
> PR should be specified in the recipe file.
> 
> [JS] I'll revert this change and bump to ".1" 
> 
> > +
> > +LIC_FILES_CHKSUM = "file://COPYING.txt;md5=27bb0deb260c60120a8d7b91da7c3b02"
> >   
> >   COMPATIBLE_MACHINE = "keystone"
> >   
> > diff --git a/recipes-ti/ipc/ipc-transport-srio.inc 
> > b/recipes-ti/ipc/ipc-transport-srio.inc
> > index 4b5c305..18b94d1 100644
> > --- a/recipes-ti/ipc/ipc-transport-srio.inc
> > +++ b/recipes-ti/ipc/ipc-transport-srio.inc
> > @@ -3,7 +3,9 @@ LICENSE = "BSD-3-Clause"
> >   
> >   require ipc-transport.inc
> >   
> > -INC_PR_append = ".0"
> > +PR = "${INC_PR}.1"
> > +
> > +LIC_FILES_CHKSUM = "file://COPYING.txt;md5=27bb0deb260c60120a8d7b91da7c3b02"
> 
> Why not keep this in the original location? This appears to be duplicated in these intermediate .inc files.
> 
> [JS] checksum against COPYING.txt only applies to Linux recipes.  RTOS 
> recipe checksum is calculated against RTOS-specific files.  Two options: In 
> current patch, move checksum calculation out of top-level include into 
> individual Linux/RTOS recipes OR keep checksum against COPYING.txt in top 
> level include and override it in RTOS recipes.  Which do you prefer?

Separate LIC_FILES_CHKSUM in .bb recipes is preferred if cannot be shared in .inc


> >   COMPATIBLE_MACHINE = "k2hk-evm"
> >   
> > diff --git a/recipes-ti/ipc/ipc-transport.inc 
> > b/recipes-ti/ipc/ipc-transport.inc
> > index 4ba3670..705dfb4 100644
> > --- a/recipes-ti/ipc/ipc-transport.inc
> > +++ b/recipes-ti/ipc/ipc-transport.inc
> > @@ -1,15 +1,17 @@
> > -LIC_FILES_CHKSUM = "file://COPYING.txt;md5=27bb0deb260c60120a8d7b91da7c3b02"
> > +LICENSE = "BSD-3-Clause"
> > +
> > +PACKAGE_ARCH = "${MACHINE_ARCH}"
> 
> What makes these .inc file machine-specific?
> 
> [JS] I'll back this out.  Doesn't make sense being here.
> 
> >   
> >   IPC_TRANSPORT_GIT_URI = "git://git.ti.com/keystone-linux/ipc-transport.git"
> > -IPC_TRANSPORT_GIT_BRANCH = "master"
> >   IPC_TRANSPORT_GIT_PROTOCOL = "git"
> > +IPC_TRANSPORT_GIT_BRANCH = "master"
> >   
> > -# Below commit ID corresponds to DEV.IPC-TRANSPORT.02.00.00.01
> > +# Below commit ID corresponds to "DEV.IPC-TRANSPORT.02.00.00.01"
> >   IPC_TRANSPORT_SRCREV = "88ea336c584ccec4b2c281cd7f75df9dff6d4edf"
> >   
> > -BRANCH="${IPC_TRANSPORT_GIT_BRANCH}"
> > +BRANCH = "${IPC_TRANSPORT_GIT_BRANCH}"
> >   SRC_URI = "${IPC_TRANSPORT_GIT_URI};protocol=${IPC_TRANSPORT_GIT_PROTOCOL};branch=${BRANCH}"
> > +
> >   SRCREV = "${IPC_TRANSPORT_SRCREV}"
> >   PV = "02.00.00.01"
> > -
> > -INC_PR = "r1"
> > +INC_PR = "r2"
> 
> -- 
> _______________________________________________
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti