From: Jacob Stiffler <j-stiffler@ti.com>
To: Justin Sobota <jsobota@ti.com>, <meta-ti@yoctoproject.org>
Subject: Re: [master/fido][PATCH 1/2] ipc-transport: Clean up recipe
Date: Wed, 20 Apr 2016 15:00:08 -0400 [thread overview]
Message-ID: <5717D1B8.9050709@ti.com> (raw)
In-Reply-To: <1461177987-495-1-git-send-email-jsobota@ti.com>
On 4/20/2016 2:46 PM, Justin Sobota wrote:
> Signed-off-by: Justin Sobota <jsobota@ti.com>
> ---
> recipes-ti/ipc/ipc-transport-qmss.inc | 4 +++-
> recipes-ti/ipc/ipc-transport-srio.inc | 4 +++-
> recipes-ti/ipc/ipc-transport.inc | 14 ++++++++------
> 3 files changed, 14 insertions(+), 8 deletions(-)
>
> diff --git a/recipes-ti/ipc/ipc-transport-qmss.inc b/recipes-ti/ipc/ipc-transport-qmss.inc
> index a5c8dc4..7539ef5 100644
> --- a/recipes-ti/ipc/ipc-transport-qmss.inc
> +++ b/recipes-ti/ipc/ipc-transport-qmss.inc
> @@ -3,7 +3,9 @@ LICENSE = "BSD-3-Clause"
>
> require ipc-transport.inc
>
> -INC_PR_append = ".0"
> +PR = "${INC_PR}.1"
PR should be specified in the recipe file.
> +
> +LIC_FILES_CHKSUM = "file://COPYING.txt;md5=27bb0deb260c60120a8d7b91da7c3b02"
>
> COMPATIBLE_MACHINE = "keystone"
>
> diff --git a/recipes-ti/ipc/ipc-transport-srio.inc b/recipes-ti/ipc/ipc-transport-srio.inc
> index 4b5c305..18b94d1 100644
> --- a/recipes-ti/ipc/ipc-transport-srio.inc
> +++ b/recipes-ti/ipc/ipc-transport-srio.inc
> @@ -3,7 +3,9 @@ LICENSE = "BSD-3-Clause"
>
> require ipc-transport.inc
>
> -INC_PR_append = ".0"
> +PR = "${INC_PR}.1"
> +
> +LIC_FILES_CHKSUM = "file://COPYING.txt;md5=27bb0deb260c60120a8d7b91da7c3b02"
Why not keep this in the original location? This appears to be
duplicated in these intermediate .inc files.
>
> COMPATIBLE_MACHINE = "k2hk-evm"
>
> diff --git a/recipes-ti/ipc/ipc-transport.inc b/recipes-ti/ipc/ipc-transport.inc
> index 4ba3670..705dfb4 100644
> --- a/recipes-ti/ipc/ipc-transport.inc
> +++ b/recipes-ti/ipc/ipc-transport.inc
> @@ -1,15 +1,17 @@
> -LIC_FILES_CHKSUM = "file://COPYING.txt;md5=27bb0deb260c60120a8d7b91da7c3b02"
> +LICENSE = "BSD-3-Clause"
> +
> +PACKAGE_ARCH = "${MACHINE_ARCH}"
What makes these .inc file machine-specific?
>
> IPC_TRANSPORT_GIT_URI = "git://git.ti.com/keystone-linux/ipc-transport.git"
> -IPC_TRANSPORT_GIT_BRANCH = "master"
> IPC_TRANSPORT_GIT_PROTOCOL = "git"
> +IPC_TRANSPORT_GIT_BRANCH = "master"
>
> -# Below commit ID corresponds to DEV.IPC-TRANSPORT.02.00.00.01
> +# Below commit ID corresponds to "DEV.IPC-TRANSPORT.02.00.00.01"
> IPC_TRANSPORT_SRCREV = "88ea336c584ccec4b2c281cd7f75df9dff6d4edf"
>
> -BRANCH="${IPC_TRANSPORT_GIT_BRANCH}"
> +BRANCH = "${IPC_TRANSPORT_GIT_BRANCH}"
> SRC_URI = "${IPC_TRANSPORT_GIT_URI};protocol=${IPC_TRANSPORT_GIT_PROTOCOL};branch=${BRANCH}"
> +
> SRCREV = "${IPC_TRANSPORT_SRCREV}"
> PV = "02.00.00.01"
> -
> -INC_PR = "r1"
> +INC_PR = "r2"
next prev parent reply other threads:[~2016-04-20 19:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-20 18:46 [master/fido][PATCH 1/2] ipc-transport: Clean up recipe Justin Sobota
2016-04-20 18:46 ` [master/fido][PATCH 2/2] ipc-transport-rtos: Add RTOS packages for IPC transports Justin Sobota
2016-04-20 19:00 ` Jacob Stiffler [this message]
2016-04-20 19:30 ` [master/fido][PATCH 1/2] ipc-transport: Clean up recipe Sobota, Justin
2016-04-20 19:35 ` Denys Dmytriyenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5717D1B8.9050709@ti.com \
--to=j-stiffler@ti.com \
--cc=jsobota@ti.com \
--cc=meta-ti@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.