From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Dennis Dalessandro
<dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Jubin John <jubin.john-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Brian Welty <brian.welty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH 1/3] IB/rdmavt,hfi1,qib: Fix memory leak
Date: Thu, 21 Apr 2016 12:38:27 +0300 [thread overview]
Message-ID: <20160421093827.GA26951@leon.nu> (raw)
In-Reply-To: <20160420130523.28231.90454.stgit-9QXIwq+3FY+1XWohqUldA0EOCMrvLtNR@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 849 bytes --]
On Wed, Apr 20, 2016 at 06:05:24AM -0700, Dennis Dalessandro wrote:
> From: Jubin John <jubin.john-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>
> rdi->ports has memory allocated in rvt_alloc_device(), but does not get
> freed because the hfi1 and qib drivers drivers call ib_dealloc_device()
> directly instead of going through rdmavt. Add a rvt_dealloc_device()
> that frees rdi->ports and then calls ib_dealloc_device(). Switch hfi1
> and qib drivers to calling rvt_dealloc_device() instead of
> ib_dealloc_device() directly.
>
> Reviewed-by: Dennis Dalessandro <dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Dennis,
You posted Fixes line in two other patches, please do in this one two.
It is needed for proper tracking.
Except this,
Reviewed-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-04-21 9:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-20 13:05 [PATCH 0/3] IB/hfi1, rdmavt: Additional bug fixes for 4.6 RC Dennis Dalessandro
[not found] ` <20160420125205.28231.86818.stgit-9QXIwq+3FY+1XWohqUldA0EOCMrvLtNR@public.gmane.org>
2016-04-20 13:05 ` [PATCH 1/3] IB/rdmavt,hfi1,qib: Fix memory leak Dennis Dalessandro
[not found] ` <20160420130523.28231.90454.stgit-9QXIwq+3FY+1XWohqUldA0EOCMrvLtNR@public.gmane.org>
2016-04-21 9:38 ` Leon Romanovsky [this message]
[not found] ` <20160421093827.GA26951-2ukJVAZIZ/Y@public.gmane.org>
2016-04-21 12:22 ` Dennis Dalessandro
[not found] ` <20160421122216.GA13471-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>
2016-04-21 12:50 ` Leon Romanovsky
[not found] ` <20160421125042.GH26951-2ukJVAZIZ/Y@public.gmane.org>
2016-04-21 13:42 ` Dennis Dalessandro
2016-04-20 13:05 ` [PATCH 2/3] IB/hfi1: Fix missing lock/unlock in verbs drain callback Dennis Dalessandro
[not found] ` <20160420130529.28231.58580.stgit-9QXIwq+3FY+1XWohqUldA0EOCMrvLtNR@public.gmane.org>
2016-04-21 9:39 ` Leon Romanovsky
2016-04-20 13:05 ` [PATCH 3/3] IB/hfi1: Don't attempt to free resources if initialization failed Dennis Dalessandro
[not found] ` <20160420130535.28231.36344.stgit-9QXIwq+3FY+1XWohqUldA0EOCMrvLtNR@public.gmane.org>
2016-04-21 9:40 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160421093827.GA26951@leon.nu \
--to=leon-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=brian.welty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=jubin.john-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.