Re: [PATCH 1/3] IB/rdmavt,hfi1,qib: Fix memory leak

[Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1377 bytes --]

On Thu, Apr 21, 2016 at 08:22:17AM -0400, Dennis Dalessandro wrote:
> On Thu, Apr 21, 2016 at 12:38:27PM +0300, Leon Romanovsky wrote:
> >On Wed, Apr 20, 2016 at 06:05:24AM -0700, Dennis Dalessandro wrote:
> >>From: Jubin John <jubin.john-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> >>
> >>rdi->ports has memory allocated in rvt_alloc_device(), but does not get
> >>freed because the hfi1 and qib drivers drivers call ib_dealloc_device()
> >>directly instead of going through rdmavt. Add a rvt_dealloc_device()
> >>that frees rdi->ports and then calls ib_dealloc_device(). Switch hfi1
> >>and qib drivers to calling rvt_dealloc_device() instead of
> >>ib_dealloc_device() directly.
> >>
> >>Reviewed-by: Dennis Dalessandro <dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> >
> >Dennis,
> >You posted Fixes line in two other patches, please do in this one two.
> >It is needed for proper tracking.
> >
> >Except this,
> >Reviewed-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> 
> Hi Leon, I don't think that a fixes line is warranted in this case. There
> isn't a single commit that causes this issue. It is a missed code path being
> moved to rdmavt.

So, it fixed the initial commit.
You can easily send an appropriate Fixes line as a response to this
email without need to resubmit the patches.

> 
> -Denny

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]