[meta-raspberrypi][PATCH 1/5] SERIAL_CONSOLE definition split

[meta-raspberrypi][PATCH 1/5] SERIAL_CONSOLE definition split

[Theodor Gherzan]

From: Trevor Woerner <twoerner@gmail.com>

The latest raspberrypi3 puts its console on ttyS0 instead of ttyAMA0 (like all
the preceding boards). Therefore pull this definition out of the common
include file and add it separately for each MACHINE.

Signed-off-by: Trevor Woerner <twoerner@gmail.com>
Signed-off-by: Theodor Gherzan <theodor@resin.io>
---
 conf/machine/include/rpi-base.inc | 2 --
 conf/machine/raspberrypi.conf     | 2 ++
 conf/machine/raspberrypi0.conf    | 2 ++
 conf/machine/raspberrypi2.conf    | 2 ++
 conf/machine/raspberrypi3.conf    | 2 ++
 5 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/conf/machine/include/rpi-base.inc b/conf/machine/include/rpi-base.inc
index 792150e..b125506 100644
--- a/conf/machine/include/rpi-base.inc
+++ b/conf/machine/include/rpi-base.inc
@@ -7,8 +7,6 @@ include conf/machine/include/soc-family.inc
 
 IMAGE_FSTYPES ?= "tar.bz2 ext3 rpi-sdimg"
 
-SERIAL_CONSOLE = "115200 ttyAMA0"
-
 XSERVER = " \
     xserver-xorg \
     xf86-input-evdev \
diff --git a/conf/machine/raspberrypi.conf b/conf/machine/raspberrypi.conf
index e8516e7..0f95f1a 100644
--- a/conf/machine/raspberrypi.conf
+++ b/conf/machine/raspberrypi.conf
@@ -6,3 +6,5 @@ DEFAULTTUNE ?= "arm1176jzfshf"
 
 require conf/machine/include/tune-arm1176jzf-s.inc
 include conf/machine/include/rpi-base.inc
+
+SERIAL_CONSOLE = "115200 ttyAMA0"
diff --git a/conf/machine/raspberrypi0.conf b/conf/machine/raspberrypi0.conf
index 58468ed..ccf9ae7 100644
--- a/conf/machine/raspberrypi0.conf
+++ b/conf/machine/raspberrypi0.conf
@@ -4,3 +4,5 @@
 
 MACHINEOVERRIDES = "raspberrypi:${MACHINE}"
 include conf/machine/raspberrypi.conf
+
+SERIAL_CONSOLE = "115200 ttyAMA0"
diff --git a/conf/machine/raspberrypi2.conf b/conf/machine/raspberrypi2.conf
index 30edae3..b6346e6 100644
--- a/conf/machine/raspberrypi2.conf
+++ b/conf/machine/raspberrypi2.conf
@@ -6,3 +6,5 @@ DEFAULTTUNE ?= "cortexa7thf-neon-vfpv4"
 
 require conf/machine/include/tune-cortexa7.inc
 include conf/machine/include/rpi-base.inc
+
+SERIAL_CONSOLE = "115200 ttyAMA0"
diff --git a/conf/machine/raspberrypi3.conf b/conf/machine/raspberrypi3.conf
index 1b73f2f..cb6056e 100644
--- a/conf/machine/raspberrypi3.conf
+++ b/conf/machine/raspberrypi3.conf
@@ -7,3 +7,5 @@ MACHINEOVERRIDES = "raspberrypi2:${MACHINE}"
 MACHINE_EXTRA_RRECOMMENDS += "linux-firmware-brcm43430"
 
 include conf/machine/raspberrypi2.conf
+
+SERIAL_CONSOLE = "115200 ttyS0"
-- 
2.1.4

[meta-raspberrypi][PATCH 2/5] firmware.inc: Update firmware to include various serial fixes

[Theodor Gherzan]

From: Theodor Gherzan <theodor@resin.io>

Signed-off-by: Theodor Gherzan <theodor@resin.io>
---
 recipes-bsp/common/firmware.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/recipes-bsp/common/firmware.inc b/recipes-bsp/common/firmware.inc
index 2c4f497..abc7d06 100644
--- a/recipes-bsp/common/firmware.inc
+++ b/recipes-bsp/common/firmware.inc
@@ -1,4 +1,4 @@
-RPIFW_SRCREV ?= "028b1f6585280bd0a21885973589c4b101355597"
+RPIFW_SRCREV ?= "c5e131971c323f5658c7c5d4b1dd105d37903a99"
 RPIFW_DATE ?= "20160303"
 RPIFW_SRC_URI ?= "git://github.com/raspberrypi/firmware.git;protocol=git;branch=master"
 RPIFW_S ?= "${WORKDIR}/git"
-- 
2.1.4

[meta-raspberrypi][PATCH 3/5] rpi-config: Add UART enabler

[Theodor Gherzan]

From: Theodor Gherzan <theodor@resin.io>

Signed-off-by: Theodor Gherzan <theodor@resin.io>
---
 recipes-bsp/bootfiles/rpi-config_git.bb | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/recipes-bsp/bootfiles/rpi-config_git.bb b/recipes-bsp/bootfiles/rpi-config_git.bb
index 4d41723..6ddf843 100644
--- a/recipes-bsp/bootfiles/rpi-config_git.bb
+++ b/recipes-bsp/bootfiles/rpi-config_git.bb
@@ -90,6 +90,12 @@ do_deploy() {
         echo "# Enable PITFT22 display" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
         echo "dtoverlay=pitft22,rotate=270,speed=32000000,txbuflen=32768" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
     fi
+
+    # UART support
+    if [ "${ENABLE_UART}" = "1" ]; then
+        echo "# Enable UART" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
+        echo "enable_uart=1" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
+    fi
 }
 
 addtask deploy before do_package after do_install
-- 
2.1.4

[meta-raspberrypi][PATCH 4/5] linux-raspberrypi: Make use of serial aliases

[Theodor Gherzan]

From: Theodor Gherzan <theodor@resin.io>

The firmware will parse cmdline and replace serial aliases with the
actual serial console port.

Signed-off-by: Theodor Gherzan <theodor@resin.io>
---
 recipes-kernel/linux/linux-raspberrypi.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/recipes-kernel/linux/linux-raspberrypi.inc b/recipes-kernel/linux/linux-raspberrypi.inc
index 24e7fe2..2dcab94 100644
--- a/recipes-kernel/linux/linux-raspberrypi.inc
+++ b/recipes-kernel/linux/linux-raspberrypi.inc
@@ -20,7 +20,7 @@ KERNEL_DEFCONFIG_raspberrypi ?= "bcmrpi_defconfig"
 KERNEL_DEFCONFIG_raspberrypi2 ?= "bcm2709_defconfig"
 
 # CMDLINE for raspberrypi
-CMDLINE = "dwc_otg.lpm_enable=0 console=ttyAMA0,115200 root=/dev/mmcblk0p2 rootfstype=ext4 rootwait"
+CMDLINE = "dwc_otg.lpm_enable=0 console=serial0 root=/dev/mmcblk0p2 rootfstype=ext4 rootwait"
 
 # Add the kernel debugger over console kernel command line option if enabled
 CMDLINE_append = ' ${@base_conditional("ENABLE_KGDB", "1", "kgdboc=ttyAMA0,115200", "", d)}'
-- 
2.1.4

[meta-raspberrypi][PATCH 5/5] README: Document new variable configuration

[Theodor Gherzan]

From: Theodor Gherzan <theodor@resin.io>

Signed-off-by: Theodor Gherzan <theodor@resin.io>
---
 README | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/README b/README
index 536926b..cbc7a92 100644
--- a/README
+++ b/README
@@ -233,6 +233,10 @@ the modelname should be added as a MACHINE_FEATURES in local.conf like below:
 List of currently supported models:
     - pitft22
 
+3.O. Enable UART
+===============
+Set this variable to enable UART:
+ENABLE_UART = "1"
 
 4. Extra apps
 =============
-- 
2.1.4

Re: [meta-raspberrypi][PATCH 3/5] rpi-config: Add UART enabler

[Andrei Gherzan]

[-- Attachment #1: Type: text/plain, Size: 1051 bytes --]

Hi,

On Thu, Apr 21, 2016 at 06:32:11PM +0100, Theodor Gherzan wrote:
> From: Theodor Gherzan <theodor@resin.io>
>
> Signed-off-by: Theodor Gherzan <theodor@resin.io>
> ---
>  recipes-bsp/bootfiles/rpi-config_git.bb | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/recipes-bsp/bootfiles/rpi-config_git.bb b/recipes-bsp/bootfiles/rpi-config_git.bb
> index 4d41723..6ddf843 100644
> --- a/recipes-bsp/bootfiles/rpi-config_git.bb
> +++ b/recipes-bsp/bootfiles/rpi-config_git.bb
> @@ -90,6 +90,12 @@ do_deploy() {
>          echo "# Enable PITFT22 display" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
>          echo "dtoverlay=pitft22,rotate=270,speed=32000000,txbuflen=32768" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
>      fi
> +
> +    # UART support
> +    if [ "${ENABLE_UART}" = "1" ]; then
> +        echo "# Enable UART" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
> +        echo "enable_uart=1" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
What is the default value of enable_uart?

--
Andrei Gherzan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [meta-raspberrypi][PATCH 3/5] rpi-config: Add UART enabler

[Theodor Gherzan]

Here is a full explination of this:


On Thu, Apr 21, 2016 at 6:43 PM, Andrei Gherzan <andrei@gherzan.ro> wrote:
> Hi,
>
> On Thu, Apr 21, 2016 at 06:32:11PM +0100, Theodor Gherzan wrote:
>> From: Theodor Gherzan <theodor@resin.io>
>>
>> Signed-off-by: Theodor Gherzan <theodor@resin.io>
>> ---
>>  recipes-bsp/bootfiles/rpi-config_git.bb | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/recipes-bsp/bootfiles/rpi-config_git.bb b/recipes-bsp/bootfiles/rpi-config_git.bb
>> index 4d41723..6ddf843 100644
>> --- a/recipes-bsp/bootfiles/rpi-config_git.bb
>> +++ b/recipes-bsp/bootfiles/rpi-config_git.bb
>> @@ -90,6 +90,12 @@ do_deploy() {
>>          echo "# Enable PITFT22 display" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
>>          echo "dtoverlay=pitft22,rotate=270,speed=32000000,txbuflen=32768" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
>>      fi
>> +
>> +    # UART support
>> +    if [ "${ENABLE_UART}" = "1" ]; then
>> +        echo "# Enable UART" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
>> +        echo "enable_uart=1" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
> What is the default value of enable_uart?
>
> --
> Andrei Gherzan

Re: [meta-raspberrypi][PATCH 3/5] rpi-config: Add UART enabler

[Theodor Gherzan]

A new config.txt setting has been introduced - enable_uart - the
purpose of which is to control the initialisation of the UART(*). The
default value varies according to the primary UART on the platform -
if the PL011 is the primary UART (that used for the console and boot
messages) then enable_uart defaults to 1, and if the mini-UART is the
primary then it defaults to 0.

The reason for the additional setting is that making use of the
mini-UART requires the core frequency to be fixed, so setting
enable_uart will limit the core to the minimum (unless force_turbo is
set, since that will fix the core frequency to the maximum, provided
the Pi is adequately powered and cooled). The previous default
behaviour, which rendered much of the output illegible, was not
useful, but we didn't want to restrict all users (even those who don't
care about the UART) to the minimum core frequency. We also wanted to
be able to remove the restriction when the PL011 is chosen on a Pi3,
hence the need for a dedicated setting indicating the reason for the
frequency limit.

On Thu, Apr 21, 2016 at 6:46 PM, Theodor Gherzan <theodor@gherzan.ro> wrote:
> Here is a full explination of this:
>
>
> On Thu, Apr 21, 2016 at 6:43 PM, Andrei Gherzan <andrei@gherzan.ro> wrote:
>> Hi,
>>
>> On Thu, Apr 21, 2016 at 06:32:11PM +0100, Theodor Gherzan wrote:
>>> From: Theodor Gherzan <theodor@resin.io>
>>>
>>> Signed-off-by: Theodor Gherzan <theodor@resin.io>
>>> ---
>>>  recipes-bsp/bootfiles/rpi-config_git.bb | 6 ++++++
>>>  1 file changed, 6 insertions(+)
>>>
>>> diff --git a/recipes-bsp/bootfiles/rpi-config_git.bb b/recipes-bsp/bootfiles/rpi-config_git.bb
>>> index 4d41723..6ddf843 100644
>>> --- a/recipes-bsp/bootfiles/rpi-config_git.bb
>>> +++ b/recipes-bsp/bootfiles/rpi-config_git.bb
>>> @@ -90,6 +90,12 @@ do_deploy() {
>>>          echo "# Enable PITFT22 display" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
>>>          echo "dtoverlay=pitft22,rotate=270,speed=32000000,txbuflen=32768" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
>>>      fi
>>> +
>>> +    # UART support
>>> +    if [ "${ENABLE_UART}" = "1" ]; then
>>> +        echo "# Enable UART" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
>>> +        echo "enable_uart=1" >>${DEPLOYDIR}/bcm2835-bootfiles/config.txt
>> What is the default value of enable_uart?
>>
>> --
>> Andrei Gherzan

Re: [meta-raspberrypi][PATCH 3/5] rpi-config: Add UART enabler

[Andrei Gherzan]

[-- Attachment #1: Type: text/plain, Size: 643 bytes --]

On Thu, Apr 21, 2016 at 06:47:29PM +0100, Theodor Gherzan wrote:
> A new config.txt setting has been introduced - enable_uart - the
> purpose of which is to control the initialisation of the UART(*). The
> default value varies according to the primary UART on the platform -
> if the PL011 is the primary UART (that used for the console and boot
> messages) then enable_uart defaults to 1, and if the mini-UART is the
> primary then it defaults to 0.
>

Got it now. So people with rpi3 will need to set this to get serial
enabled but rpi1-2 will get it by default. Can you please add a summary
in README too?

--
Andrei Gherzan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [meta-raspberrypi][PATCH 5/5] README: Document new variable configuration

[Andrei Gherzan]

[-- Attachment #1: Type: text/plain, Size: 1030 bytes --]

On Thu, Apr 21, 2016 at 06:32:13PM +0100, Theodor Gherzan wrote:
> From: Theodor Gherzan <theodor@resin.io>
>
> Signed-off-by: Theodor Gherzan <theodor@resin.io>
> ---
>  README | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/README b/README
> index 536926b..cbc7a92 100644
> --- a/README
> +++ b/README
> @@ -233,6 +233,10 @@ the modelname should be added as a MACHINE_FEATURES in local.conf like below:
>  List of currently supported models:
>      - pitft22
>
> +3.O. Enable UART
> +===============
> +Set this variable to enable UART:
> +ENABLE_UART = "1"

Based on the explaination about enable_uart this is not quite right.
Cause on rpi1, rpi2 and cm it will get enabled without this variable by
default. So this needs a little additional information.

>
>  4. Extra apps
>  =============
> --
> 2.1.4
>
> --
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto

--
Andrei Gherzan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [meta-raspberrypi][PATCH 5/5] README: Document new variable configuration

[Theodor Gherzan]

From: Theodor Gherzan <theodor@resin.io>

Signed-off-by: Theodor Gherzan <theodor@resin.io>
---
 README | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/README b/README
index 536926b..326b0bd 100644
--- a/README
+++ b/README
@@ -29,6 +29,7 @@ Contents:
     3.L. Enable SPI bus
     3.M. Enable I2C
     3.N. Enable PiTFT support
+    3.O. Enable UART support
 4. Extra apps
     4.A. omxplayer
 5. Board Configuration
@@ -233,6 +234,12 @@ the modelname should be added as a
MACHINE_FEATURES in local.conf like below:
 List of currently supported models:
     - pitft22

+3.O. Enable UART
+===============
+Set this variable to enable UART on raspberypi3:
+ENABLE_UART = "1"
+
+Note: The value of enable_uart would be set to 1 by default on raspberrypi 1/2.

 4. Extra apps
 =============
-- 
2.1.4

On Thu, Apr 21, 2016 at 6:55 PM, Andrei Gherzan <andrei@gherzan.ro> wrote:
> On Thu, Apr 21, 2016 at 06:32:13PM +0100, Theodor Gherzan wrote:
>> From: Theodor Gherzan <theodor@resin.io>
>>
>> Signed-off-by: Theodor Gherzan <theodor@resin.io>
>> ---
>>  README | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/README b/README
>> index 536926b..cbc7a92 100644
>> --- a/README
>> +++ b/README
>> @@ -233,6 +233,10 @@ the modelname should be added as a MACHINE_FEATURES in local.conf like below:
>>  List of currently supported models:
>>      - pitft22
>>
>> +3.O. Enable UART
>> +===============
>> +Set this variable to enable UART:
>> +ENABLE_UART = "1"
>
> Based on the explaination about enable_uart this is not quite right.
> Cause on rpi1, rpi2 and cm it will get enabled without this variable by
> default. So this needs a little additional information.
>
>>
>>  4. Extra apps
>>  =============
>> --
>> 2.1.4
>>
>> --
>> _______________________________________________
>> yocto mailing list
>> yocto@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/yocto
>
> --
> Andrei Gherzan

Re: [meta-raspberrypi][PATCH 2/5] firmware.inc: Update firmware to include various serial fixes

[Andrei Gherzan]

[-- Attachment #1: Type: text/plain, Size: 310 bytes --]

On Thu, Apr 21, 2016 at 06:32:10PM +0100, Theodor Gherzan wrote:
> From: Theodor Gherzan <theodor@resin.io>
>
> Signed-off-by: Theodor Gherzan <theodor@resin.io>

Doesn't apply over over current master. Can you send a v2 without
Trevor's patch and with the updated one for README?

--
Andrei Gherzan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]