Re: [PATCH 3/3] powerpc/eeh: Drop unnecessary label in eeh_pe_change_owner()

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1146 bytes --]

On Thu, Apr 21, 2016 at 09:53:07PM +1000, Gavin Shan wrote:
> The label "reset" in eeh_pe_change_owner() is used only for once.
> No need to keep it and just drop it. No logicial changes introduced.
> 
> Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  arch/powerpc/kernel/eeh.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/arch/powerpc/kernel/eeh.c b/arch/powerpc/kernel/eeh.c
> index 6544017..4b40d56 100644
> --- a/arch/powerpc/kernel/eeh.c
> +++ b/arch/powerpc/kernel/eeh.c
> @@ -1336,14 +1336,11 @@ static int eeh_pe_change_owner(struct eeh_pe *pe)
>  			    id->subdevice != pdev->subsystem_device)
>  				continue;
>  
> -			goto reset;
> +			return eeh_pe_reset_and_recover(pe);
>  		}
>  	}
>  
>  	return eeh_unfreeze_pe(pe, true);
> -
> -reset:
> -	return eeh_pe_reset_and_recover(pe);
>  }
>  
>  /**

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]