Re: [PATCH 2/3] powerpc/eeh: Restore config from edev in eeh_pe_reset_and_recover()

[Gavin Shan <gwshan@linux.vnet.ibm.com>]

On Fri, Apr 22, 2016 at 04:37:52PM +1000, Russell Currey wrote:
>On Thu, 2016-04-21 at 21:53 +1000, Gavin Shan wrote:
>> The function eeh_pe_reset_and_recover() is used to recover EEH
>> error when the passthrou device are transferred to guest and
>> backwords. The content in the device's config space will be lost
>
>Spelling, as before :)
>
>> on PE reset issued in the middle of the recovery. The function
>> saves/restores it before/after the reset. However, config access
>> to some adapters like Broadcom BCM5719 at this point will causes
>> fended PHB. The config space is always blocked and we save 0xFF's
>
>"fended" should be "fenced"
>

Thanks, Russell. I'll fix it in next revision ;-)

>> that are restored at late point. The memory BARs are totally
>> corrupted, causing another EEH error upon access to one of the
>> memory BARs.
>> 
>> This restores the config space from the content saved to the
>> EEH device when it's populated, to resolve above issue.
>> 
>> Fixes: 5cfb20b9 ("powerpc/eeh: Emulate EEH recovery for VFIO devices")
>> Cc: stable@vger.kernel.org #v3.18+
>> Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
>> ---
>
>Reviewed-by: Russell Currey <ruscur@russell.cc>
>