All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Patrick McHardy <kaber@trash.net>
Cc: pablo@netfilter.org, fw@strlen.de, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft 0/6] ruleset tracing
Date: Mon, 25 Apr 2016 00:22:13 +0200	[thread overview]
Message-ID: <20160424222213.GA28797@breakpoint.cc> (raw)
In-Reply-To: <1461533440-10605-1-git-send-email-kaber@trash.net>

Patrick McHardy <kaber@trash.net> wrote:
> The following patches contain the latest version of the ruleset tracing
> functionality.
> I consider this patchset complete. Testing and comments welcome.

Seems it doesn't work with inet table, I get segfault in expr_print
(EXPR_VALUE expr with expr->dtype == NULL).

Callchain that produces this expression is:

trace_gen_stmts -> payload_expr_expand -> payload_expr_alloc

desc argument to payload_expr_alloc is the inet one, which
has no template for types != 0, so tmpl->dtype that gets passed
to expr_alloc is NULL.

Works fine without inet table. Only "problem" I found is that
nft displays the ether addr reversed vs. what 'ip link' shows,
i.e. if ip link says 1:2:3:4:5:6 nft shows 6:5:4:3:2:1.

I'll do more tests tomorrow and will double check that its not
a kernel bug.

Thanks for working on this!

  parent reply	other threads:[~2016-04-24 22:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-24 21:30 [PATCH nft 0/6] ruleset tracing Patrick McHardy
2016-04-24 21:30 ` [PATCH nft 1/6] payload: fix stacked headers protocol context tracking Patrick McHardy
2016-04-24 21:30 ` [PATCH nft 2/6] nft: resync kernel header files Patrick McHardy
2016-04-24 21:30 ` [PATCH nft 3/6] payload: move payload depedency tracking to payload.c Patrick McHardy
2016-04-24 21:30 ` [PATCH nft 4/6] payload: add payload_is_stacked() Patrick McHardy
2016-04-24 21:30 ` [PATCH nft 5/6] proto: add protocol header fields filter and ordering for packet decoding Patrick McHardy
2016-04-24 21:30 ` [PATCH nft 6/6] nft monitor [ trace ] Patrick McHardy
2016-04-24 22:22 ` Florian Westphal [this message]
2016-04-24 22:57   ` [PATCH nft 0/6] ruleset tracing Patrick McHardy
2016-04-25  0:23     ` Patrick McHardy
2016-04-25  9:49       ` Florian Westphal
2016-04-25 10:28         ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160424222213.GA28797@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.