Re: [PATCH nft 0/6] ruleset tracing

[Patrick McHardy <kaber@trash.net>]

On 25.04, Florian Westphal wrote:
> Patrick McHardy <kaber@trash.net> wrote:
> > The following patches contain the latest version of the ruleset tracing
> > functionality.
> > I consider this patchset complete. Testing and comments welcome.
> 
> Seems it doesn't work with inet table, I get segfault in expr_print
> (EXPR_VALUE expr with expr->dtype == NULL).
> 
> Callchain that produces this expression is:
> 
> trace_gen_stmts -> payload_expr_expand -> payload_expr_alloc
> 
> desc argument to payload_expr_alloc is the inet one, which
> has no template for types != 0, so tmpl->dtype that gets passed
> to expr_alloc is NULL.

Thanks, I'll look into that.

> Works fine without inet table. Only "problem" I found is that
> nft displays the ether addr reversed vs. what 'ip link' shows,
> i.e. if ip link says 1:2:3:4:5:6 nft shows 6:5:4:3:2:1.
> 
> I'll do more tests tomorrow and will double check that its not
> a kernel bug.

That's just a missing byte order conversion, I've fixed it locally.