From: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: "Michael Kerrisk (man-pages)"
<mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>,
viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org,
axboe-b10kYP2dOMg@public.gmane.org,
milosz-B5zB6C1i6pkAvxtiuMwx3w@public.gmane.org,
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/6] vfs: vfs: Define new syscalls preadv2,pwritev2
Date: Mon, 25 Apr 2016 01:47:15 -0700 [thread overview]
Message-ID: <20160425084715.GA29255@infradead.org> (raw)
In-Reply-To: <5714E676.4090007-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Mon, Apr 18, 2016 at 02:51:50PM +0100, Michael Kerrisk (man-pages) wrote:
> Thanks. I applied the patch, but I see one point where the doc
> and code differ, and I suspect that the code needs to be fixed.
> See below.
> > .TP
> > .B EINVAL
> > The vector count \fIiovcnt\fP is less than zero or greater than the
> > -permitted maximum.
> > +permitted maximum. Or, an unknown flag is specified in \fIflags\fP.
>
> In the case described in the last sentence, the code currently appears
> to be returning EOPNOTSUPP. EINVAL is more usual here, so I think the
> code needs adjusting. Your thoughts?
I'd rather update the man page - EOPNOTSUPP is a much more descriptive
error code for this case. I'll send you a patch.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>,
viro@zeniv.linux.org.uk, axboe@fb.com, milosz@adfin.com,
linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
linux-api@vger.kernel.org
Subject: Re: [PATCH 2/6] vfs: vfs: Define new syscalls preadv2,pwritev2
Date: Mon, 25 Apr 2016 01:47:15 -0700 [thread overview]
Message-ID: <20160425084715.GA29255@infradead.org> (raw)
In-Reply-To: <5714E676.4090007@gmail.com>
On Mon, Apr 18, 2016 at 02:51:50PM +0100, Michael Kerrisk (man-pages) wrote:
> Thanks. I applied the patch, but I see one point where the doc
> and code differ, and I suspect that the code needs to be fixed.
> See below.
> > .TP
> > .B EINVAL
> > The vector count \fIiovcnt\fP is less than zero or greater than the
> > -permitted maximum.
> > +permitted maximum. Or, an unknown flag is specified in \fIflags\fP.
>
> In the case described in the last sentence, the code currently appears
> to be returning EOPNOTSUPP. EINVAL is more usual here, so I think the
> code needs adjusting. Your thoughts?
I'd rather update the man page - EOPNOTSUPP is a much more descriptive
error code for this case. I'll send you a patch.
next prev parent reply other threads:[~2016-04-25 8:47 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 15:03 generic RDMA READ/WRITE API V2 Christoph Hellwig
2016-03-03 15:03 ` Christoph Hellwig
[not found] ` <1457017443-17662-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-03-03 15:03 ` [PATCH 1/6] vfs: pass a flags argument to vfs_readv/vfs_writev Christoph Hellwig
2016-03-03 15:03 ` Christoph Hellwig
2016-03-03 15:04 ` [PATCH 3/6] x86: wire up preadv2 and pwritev2 Christoph Hellwig
2016-03-03 15:04 ` Christoph Hellwig
2016-03-03 15:04 ` [PATCH 4/6] vfs: add the RWF_HIPRI flag for preadv2/pwritev2 Christoph Hellwig
2016-03-03 15:04 ` Christoph Hellwig
[not found] ` <1457017443-17662-5-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-05-08 21:47 ` NeilBrown
2016-05-08 21:47 ` NeilBrown
[not found] ` <874ma8usrr.fsf-wvvUuzkyo1HefUI2i7LXDhCRmIWqnp/j@public.gmane.org>
2016-05-11 8:55 ` Christoph Hellwig
2016-05-11 8:55 ` Christoph Hellwig
2016-03-03 15:04 ` [PATCH 5/6] direct-io: only use block polling if explicitly requested Christoph Hellwig
2016-03-03 15:04 ` Christoph Hellwig
2016-03-03 15:03 ` [PATCH 2/6] vfs: vfs: Define new syscalls preadv2,pwritev2 Christoph Hellwig
2016-03-10 18:15 ` Michael Kerrisk (man-pages)
[not found] ` <56E1B9A8.3070904-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-03-11 9:53 ` Christoph Hellwig
2016-03-11 9:53 ` Christoph Hellwig
[not found] ` <20160311095357.GA29350-jcswGhMUV9g@public.gmane.org>
2016-04-18 13:51 ` Michael Kerrisk (man-pages)
2016-04-18 13:51 ` Michael Kerrisk (man-pages)
[not found] ` <5714E676.4090007-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-04-25 8:47 ` Christoph Hellwig [this message]
2016-04-25 8:47 ` Christoph Hellwig
[not found] ` <20160425084715.GA29255-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-04-25 17:35 ` Michael Kerrisk (man-pages)
2016-04-25 17:35 ` Michael Kerrisk (man-pages)
2016-05-08 9:29 ` Christoph Hellwig
2016-03-03 15:04 ` [PATCH 6/6] blk-mq: enable polling support by default Christoph Hellwig
2016-03-03 15:09 ` generic RDMA READ/WRITE API V2 Sagi Grimberg
2016-03-03 15:09 ` Sagi Grimberg
2016-03-03 15:11 ` selective block polling and preadv2/pwritev2 revisited V3 Christoph Hellwig
2016-03-03 15:16 ` Jens Axboe
2016-03-03 15:16 ` Jens Axboe
[not found] ` <20160303151116.GA24614-jcswGhMUV9g@public.gmane.org>
2016-03-03 15:52 ` Arnd Bergmann
2016-03-03 15:52 ` Arnd Bergmann
2016-03-03 16:11 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2015-12-24 14:14 selective block polling and preadv2/pwritev2 revisited Christoph Hellwig
[not found] ` <1450966464-6847-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2015-12-24 14:14 ` [PATCH 2/6] vfs: vfs: Define new syscalls preadv2,pwritev2 Christoph Hellwig
2015-12-24 14:14 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160425084715.GA29255@infradead.org \
--to=hch-wegcikhe2lqwvfeawa7xhq@public.gmane.org \
--cc=axboe-b10kYP2dOMg@public.gmane.org \
--cc=hch-jcswGhMUV9g@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=milosz-B5zB6C1i6pkAvxtiuMwx3w@public.gmane.org \
--cc=mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.