From: Wei Liu <wei.liu2@citrix.com>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>
Cc: minios-devel@lists.xenproject.org, srn@prgmr.com,
wei.liu2@citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH] Mini-OS: netfront: fix off-by-one error introduced in 7c8f3483
Date: Mon, 25 Apr 2016 12:14:01 +0100 [thread overview]
Message-ID: <20160425111400.GA11686@citrix.com> (raw)
In-Reply-To: <20160404102800.GB25710@citrix.com>
On Mon, Apr 04, 2016 at 11:28:00AM +0100, Wei Liu wrote:
> On Fri, Apr 01, 2016 at 08:26:16PM +0200, Samuel Thibault wrote:
> > 7c8f3483 introduced a break within a loop in netfront.c such that
> > cons and nr_consumed were no longer always being incremented. The
> > offset at cons will be processed multiple times with the break in
> > place.
> >
> > This commit reverts to using the "some" variable in the loop condition,
> > but avoids ifdefs for the non-libc case. It also renames it to dobreak
> > to make its usage clearer.
> >
> > Suggested-by: Sarah Newman <srn@prgmr.com>
> > Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> > Tested-by: Sarah Newman <srn@prgmr.com>
>
> Queued. Thank you both!
This is now backported to mini-os.git xen-stable-4.6 branch.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-25 11:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 18:26 [PATCH] Mini-OS: netfront: fix off-by-one error introduced in 7c8f3483 Samuel Thibault
2016-04-04 10:28 ` Wei Liu
2016-04-25 11:14 ` Wei Liu [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-04-01 18:17 Samuel Thibault
2016-04-01 18:26 ` Samuel Thibault
2016-03-23 21:26 Sarah Newman
2016-03-25 13:09 ` Wei Liu
2016-03-25 18:33 ` Samuel Thibault
2016-03-25 19:19 ` Sarah Newman
2016-03-25 19:32 ` Samuel Thibault
2016-03-25 19:56 ` Sarah Newman
2016-03-26 20:53 ` Sarah Newman
2016-03-30 13:46 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160425111400.GA11686@citrix.com \
--to=wei.liu2@citrix.com \
--cc=minios-devel@lists.xenproject.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=srn@prgmr.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.