From: Sarah Newman <srn@prgmr.com>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
Wei Liu <wei.liu2@citrix.com>,
xen-devel@lists.xen.org, minios-devel@lists.xenproject.org
Cc: martin@lucina.net
Subject: Re: [PATCH] Mini-OS: netfront: fix off-by-one error introduced in 7c8f3483
Date: Fri, 25 Mar 2016 12:19:23 -0700 [thread overview]
Message-ID: <56F58F3B.5030105@prgmr.com> (raw)
In-Reply-To: <20160325183320.GB2792@var>
On 03/25/2016 11:33 AM, Samuel Thibault wrote:
> Wei Liu, on Fri 25 Mar 2016 13:09:07 +0000, wrote:
>> CC Samuel
>
> Thanks.
>
>> On Wed, Mar 23, 2016 at 02:26:51PM -0700, Sarah Newman wrote:
>>> 7c8f3483 introduced a break within a loop in netfront.c such that
>>> cons and nr_consumed were no longer always being incremented. The
>>> offset at cons will be processed multiple times with the break in
>>> place.
>>>
>>> Remove the break and re-add "some !=0" in the loop for HAVE_LIBC.
>
> Mmm, right.
>
> That ifdef makes things even more difficult to understand then. That
> however makes me think: how about the attached patch, which actually
> simplifies the rest.
>
> Thanks!
> Samuel
>
I have no objections to backing out additional changes made in 7c8f3483, but I wasn't the person who submitted that patch.
The patch tests OK with GNT_DEBUG enabled.
--Sarah
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-25 19:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 21:26 [PATCH] Mini-OS: netfront: fix off-by-one error introduced in 7c8f3483 Sarah Newman
2016-03-25 13:09 ` Wei Liu
2016-03-25 18:33 ` Samuel Thibault
2016-03-25 19:19 ` Sarah Newman [this message]
2016-03-25 19:32 ` Samuel Thibault
2016-03-25 19:56 ` Sarah Newman
2016-03-26 20:53 ` Sarah Newman
2016-03-30 13:46 ` Wei Liu
-- strict thread matches above, loose matches on Subject: below --
2016-04-01 18:17 Samuel Thibault
2016-04-01 18:26 ` Samuel Thibault
2016-04-01 18:26 Samuel Thibault
2016-04-04 10:28 ` Wei Liu
2016-04-25 11:14 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F58F3B.5030105@prgmr.com \
--to=srn@prgmr.com \
--cc=martin@lucina.net \
--cc=minios-devel@lists.xenproject.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.