From: Mark Brown <broonie@kernel.org>
To: Jeremy McDermond <mcdermj@xenotropic.com>
Cc: Mark Rutland <mark.rutland@arm.com>, Andrew Lunn <andrew@lunn.ch>,
alsa-devel@alsa-project.org,
Mengdong Lin <mengdong.lin@linux.intel.com>,
heiko@sntech.de, Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh@kernel.org>,
Xing Zheng <zhengxing@rock-chips.com>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
Takashi Iwai <tiwai@suse.com>,
sugar.zhang@rock-chips.com, linux-rockchip@lists.infradead.org,
jay.xu@rock-chips.com, devicetree@vger.kernel.org,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Jyri Sarha <jsarha@ti.com>,
Arnaud Pouliquen <arnaud.pouliquen@st.com>,
linux-kernel@vger.kernel.org, Adam.Thomson@diasemi.com,
Kumar Gala <galak@codeaurora.org>, Jun Nie <jun.nie@linaro.org>
Subject: Re: [PATCH 2/3] ASoC: simple-card: Add support jack detection via codec
Date: Mon, 25 Apr 2016 13:55:04 +0100 [thread overview]
Message-ID: <20160425125504.GL3217@sirena.org.uk> (raw)
In-Reply-To: <3C927D46-BC52-4B5C-B5B4-CCBA3AAE6F87@xenotropic.com>
[-- Attachment #1.1: Type: text/plain, Size: 713 bytes --]
On Fri, Apr 22, 2016 at 09:37:39AM -0700, Jeremy McDermond wrote:
> components fairly well. I’m just trying to wrap my head around
> where this all would fit in. Should the codec driver just register
> a bunch of clock components in its initialization somewhere?
> I’m thinking that it can’t have its own CCF driver separate from
> the codec driver because you won’t have proper access to the
> registers over I2C or SPI. I don’t find a lot of examples in the
> codec drivers, and there aren’t very many other drivers in the tree
> that seem to register clocks with CCF that I can find.
If the clock code is worth splitting off into a separate driver that's
what drivers/mfd is for.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Jeremy McDermond <mcdermj@xenotropic.com>
Cc: Xing Zheng <zhengxing@rock-chips.com>,
Mark Rutland <mark.rutland@arm.com>, Andrew Lunn <andrew@lunn.ch>,
alsa-devel@alsa-project.org,
Mengdong Lin <mengdong.lin@linux.intel.com>,
heiko@sntech.de, Liam Girdwood <lgirdwood@gmail.com>,
Takashi Iwai <tiwai@suse.com>, Rob Herring <robh@kernel.org>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
sugar.zhang@rock-chips.com, linux-rockchip@lists.infradead.org,
jay.xu@rock-chips.com, devicetree@vger.kernel.org,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Jyri Sarha <jsarha@ti.com>,
Arnaud Pouliquen <arnaud.pouliquen@st.com>,
linux-kernel@vger.kernel.org, Adam.Thomson@diasemi.com,
Kumar Gala <galak@codeaurora.org>, Jun Nie <jun.nie@linaro.org>
Subject: Re: [alsa-devel] [PATCH 2/3] ASoC: simple-card: Add support jack detection via codec
Date: Mon, 25 Apr 2016 13:55:04 +0100 [thread overview]
Message-ID: <20160425125504.GL3217@sirena.org.uk> (raw)
In-Reply-To: <3C927D46-BC52-4B5C-B5B4-CCBA3AAE6F87@xenotropic.com>
[-- Attachment #1: Type: text/plain, Size: 713 bytes --]
On Fri, Apr 22, 2016 at 09:37:39AM -0700, Jeremy McDermond wrote:
> components fairly well. I’m just trying to wrap my head around
> where this all would fit in. Should the codec driver just register
> a bunch of clock components in its initialization somewhere?
> I’m thinking that it can’t have its own CCF driver separate from
> the codec driver because you won’t have proper access to the
> registers over I2C or SPI. I don’t find a lot of examples in the
> codec drivers, and there aren’t very many other drivers in the tree
> that seem to register clocks with CCF that I can find.
If the clock code is worth splitting off into a separate driver that's
what drivers/mfd is for.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-04-25 12:55 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 8:17 [PATCH 0/3] Add support simple-card parse jack detection via external codec Xing Zheng
2016-04-18 8:17 ` Xing Zheng
2016-04-18 8:17 ` [PATCH 1/3] ASoC: jack: Add a jack detect callback via codec Xing Zheng
[not found] ` <1460967452-24574-2-git-send-email-zhengxing-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-04-18 9:22 ` Mark Brown
2016-04-18 9:22 ` Mark Brown
2016-04-18 9:43 ` Xing Zheng
[not found] ` <5714AC57.2070901-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-04-18 9:53 ` Mark Brown
2016-04-18 9:53 ` Mark Brown
2016-04-18 10:03 ` Xing Zheng
2016-04-18 10:03 ` Xing Zheng
2016-04-18 10:20 ` Xing Zheng
2016-04-18 10:20 ` Xing Zheng
[not found] ` <5714B4D0.90406-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-04-18 11:46 ` Mark Brown
2016-04-18 11:46 ` Mark Brown
2016-04-18 16:40 ` Dylan Reid
2016-04-18 8:17 ` [PATCH 2/3] ASoC: simple-card: Add support jack detection " Xing Zheng
2016-04-21 14:19 ` Rob Herring
2016-04-22 1:17 ` Xing Zheng
2016-04-22 1:17 ` Xing Zheng
[not found] ` <57197BBA.50304-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-04-22 9:22 ` Mark Brown
2016-04-22 9:22 ` Mark Brown
[not found] ` <20160422092250.GA3217-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-04-22 16:37 ` [alsa-devel] " Jeremy McDermond
2016-04-22 16:37 ` Jeremy McDermond
2016-04-25 12:55 ` Mark Brown [this message]
2016-04-25 12:55 ` Mark Brown
[not found] ` <20160425125504.GL3217-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-04-25 18:17 ` Jeremy McDermond
2016-04-25 18:17 ` Jeremy McDermond
2016-04-22 16:40 ` Jeremy McDermond
2016-04-22 16:40 ` [alsa-devel] " Jeremy McDermond
2016-04-18 8:17 ` [PATCH 3/3] ASoC: da7219: Add detect_jack callback in the snd_soc_codec_driver Xing Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160425125504.GL3217@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Adam.Thomson@diasemi.com \
--cc=aaro.koskinen@iki.fi \
--cc=alsa-devel@alsa-project.org \
--cc=andrew@lunn.ch \
--cc=arnaud.pouliquen@st.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jay.xu@rock-chips.com \
--cc=jsarha@ti.com \
--cc=jun.nie@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mcdermj@xenotropic.com \
--cc=mengdong.lin@linux.intel.com \
--cc=pawel.moll@arm.com \
--cc=robh@kernel.org \
--cc=sugar.zhang@rock-chips.com \
--cc=tiwai@suse.com \
--cc=zhengxing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.