From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Shardar Shariff Md <smohammed-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org,
thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH v7 1/4] i2c: tegra: disable clock before returning error
Date: Mon, 25 Apr 2016 15:54:48 +0200 [thread overview]
Message-ID: <20160425135448.GA5897@katana> (raw)
In-Reply-To: <1461591519-24602-1-git-send-email-smohammed-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 721 bytes --]
On Mon, Apr 25, 2016 at 07:08:36PM +0530, Shardar Shariff Md wrote:
> Disable clock before returning error in tegra_i2c_init() as its leaves
> i2c clock ON in case of error and never turns off again as it will have
> unbalanced clock enable/disable
>
> Signed-off-by: Shardar Shariff Md <smohammed-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>
> ---
> Changes in v5:
> - Move current patch as separate patch
>
> Changes in v6:
> - Remove unnecessary line
>
> Changes in v7
> - Updated commit message with description of issue
I know 'release often' but maybe you could wait like a day and collect
review responses before submitting a new version? That would make my
life as a maintainer easier...
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Shardar Shariff Md <smohammed@nvidia.com>
Cc: ldewangan@nvidia.com, swarren@wwwdotorg.org,
thierry.reding@gmail.com, gnurou@gmail.com,
linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org, jonathanh@nvidia.com
Subject: Re: [PATCH v7 1/4] i2c: tegra: disable clock before returning error
Date: Mon, 25 Apr 2016 15:54:48 +0200 [thread overview]
Message-ID: <20160425135448.GA5897@katana> (raw)
In-Reply-To: <1461591519-24602-1-git-send-email-smohammed@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 692 bytes --]
On Mon, Apr 25, 2016 at 07:08:36PM +0530, Shardar Shariff Md wrote:
> Disable clock before returning error in tegra_i2c_init() as its leaves
> i2c clock ON in case of error and never turns off again as it will have
> unbalanced clock enable/disable
>
> Signed-off-by: Shardar Shariff Md <smohammed@nvidia.com>
>
> ---
> Changes in v5:
> - Move current patch as separate patch
>
> Changes in v6:
> - Remove unnecessary line
>
> Changes in v7
> - Updated commit message with description of issue
I know 'release often' but maybe you could wait like a day and collect
review responses before submitting a new version? That would make my
life as a maintainer easier...
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-04-25 13:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 13:38 [PATCH v7 1/4] i2c: tegra: disable clock before returning error Shardar Shariff Md
2016-04-25 13:38 ` Shardar Shariff Md
[not found] ` <1461591519-24602-1-git-send-email-smohammed-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-04-25 13:38 ` [PATCH v7 2/4] i2c: tegra: calculate timeout for config load when needed Shardar Shariff Md
2016-04-25 13:38 ` Shardar Shariff Md
[not found] ` <1461591519-24602-2-git-send-email-smohammed-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-05-11 14:42 ` Wolfram Sang
2016-05-11 14:42 ` Wolfram Sang
2016-04-25 13:38 ` [PATCH v7 4/4] i2c: tegra: proper handling of error cases Shardar Shariff Md
2016-04-25 13:38 ` Shardar Shariff Md
2016-05-11 14:47 ` Wolfram Sang
2016-04-25 13:54 ` Wolfram Sang [this message]
2016-04-25 13:54 ` [PATCH v7 1/4] i2c: tegra: disable clock before returning error Wolfram Sang
2016-04-25 13:38 ` [PATCH v7 3/4] i2c: tegra: add separate function for config_load Shardar Shariff Md
2016-04-25 13:38 ` Shardar Shariff Md
2016-05-11 14:33 ` [PATCH v7 1/4] i2c: tegra: disable clock before returning error Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160425135448.GA5897@katana \
--to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
--cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=smohammed-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.