From: Stephen Boyd <sboyd@codeaurora.org>
To: Frank Rowand <frowand.list@gmail.com>
Cc: Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
linux-soc@vger.kernel.org, linux-serial@vger.kernel.org,
Linux Kernel list <linux-kernel@vger.kernel.org>,
ivan.ivanov@linaro.org
Subject: Re: [PATCH 2/2] tty: serial: msm_serial add info message
Date: Mon, 25 Apr 2016 14:35:27 -0700 [thread overview]
Message-ID: <20160425213527.GH13149@codeaurora.org> (raw)
In-Reply-To: <571E8CAF.4060601@gmail.com>
On 04/25, Frank Rowand wrote:
>
> This is in msm_request_tx_dma(). I should have made the message
> "msm_serial: TX DMA not enabled\n" and added a similar message
> to msm_request_rx_dma().
>
> Then it could print twice, once for TX and once for RX. :-)
> For my board it would print twice because both requests would
> fail for the same reason.
Ah right, the 3 line diff window caught me here.
>
> Should I add it to msm_request_rx_dma() also, but make both
> locations dev_debug() instead of dev_info()?
Honestly I don't see much point in having this at all. Why does
the user care if DMA is used or not? Don't they just want the
hardware to work? Maybe dev_dbg(), but again, debug junk. I'll
leave it up to you and Greg.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-04-25 21:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-23 17:10 [PATCH 0/2] tty: serial: msm_serial regression and add info message Frank Rowand
2016-04-23 17:14 ` [PATCH 1/2] tty: serial: msm_serial regression fix data corruption Frank Rowand
2016-04-25 20:47 ` Stephen Boyd
2016-04-25 22:31 ` Bjorn Andersson
2016-05-05 23:52 ` Andy Gross
2016-04-23 17:17 ` [PATCH 2/2] tty: serial: msm_serial add info message Frank Rowand
2016-04-25 20:48 ` Stephen Boyd
2016-04-25 21:31 ` Frank Rowand
2016-04-25 21:35 ` Stephen Boyd [this message]
2016-04-26 0:44 ` Frank Rowand
2016-04-28 20:51 ` Greg Kroah-Hartman
2016-04-28 22:15 ` Frank Rowand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160425213527.GH13149@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=ivan.ivanov@linaro.org \
--cc=jslaby@suse.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.