From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Frank Rowand <frowand.list@gmail.com>
Cc: Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Jiri Slaby <jslaby@suse.com>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
linux-soc@vger.kernel.org, linux-serial@vger.kernel.org,
Linux Kernel list <linux-kernel@vger.kernel.org>,
ivan.ivanov@linaro.org
Subject: Re: [PATCH 2/2] tty: serial: msm_serial add info message
Date: Thu, 28 Apr 2016 13:51:32 -0700 [thread overview]
Message-ID: <20160428205132.GA22117@kroah.com> (raw)
In-Reply-To: <571BAE11.3020706@gmail.com>
On Sat, Apr 23, 2016 at 10:17:05AM -0700, Frank Rowand wrote:
> From: Frank Rowand <frank.rowand@am.sony.com>
>
> Failure to enable DMA by the msm_serial driver is silent.
> Add a message to report the failure.
>
> Signed-off-by: Frank Rowand <frank.rowand@am.sony.com>
> ---
> drivers/tty/serial/msm_serial.c | 1 +
> 1 file changed, 1 insertion(+)
>
> Index: b/drivers/tty/serial/msm_serial.c
> ===================================================================
> --- a/drivers/tty/serial/msm_serial.c
> +++ b/drivers/tty/serial/msm_serial.c
> @@ -170,6 +170,7 @@ rel_tx:
> dma_release_channel(dma->chan);
> no_tx:
> memset(dma, 0, sizeof(*dma));
> + dev_info(dev, "msm_serial: DMA not enabled\n");
Don't print out messages that a user can't do something with :(
So I agree, this is not needed, sorry.
greg k-h
next prev parent reply other threads:[~2016-04-28 20:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-23 17:10 [PATCH 0/2] tty: serial: msm_serial regression and add info message Frank Rowand
2016-04-23 17:14 ` [PATCH 1/2] tty: serial: msm_serial regression fix data corruption Frank Rowand
2016-04-25 20:47 ` Stephen Boyd
2016-04-25 22:31 ` Bjorn Andersson
2016-05-05 23:52 ` Andy Gross
2016-04-23 17:17 ` [PATCH 2/2] tty: serial: msm_serial add info message Frank Rowand
2016-04-25 20:48 ` Stephen Boyd
2016-04-25 21:31 ` Frank Rowand
2016-04-25 21:35 ` Stephen Boyd
2016-04-26 0:44 ` Frank Rowand
2016-04-28 20:51 ` Greg Kroah-Hartman [this message]
2016-04-28 22:15 ` Frank Rowand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160428205132.GA22117@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=frowand.list@gmail.com \
--cc=ivan.ivanov@linaro.org \
--cc=jslaby@suse.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.