All of lore.kernel.org
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 0/5] arm64: Fix behavior of maxcpus=n
Date: Tue, 26 Apr 2016 15:50:46 +0100	[thread overview]
Message-ID: <20160426145046.GB1793@arm.com> (raw)
In-Reply-To: <1461682140-7131-1-git-send-email-suzuki.poulose@arm.com>

On Tue, Apr 26, 2016 at 03:48:55PM +0100, Suzuki K Poulose wrote:
> This series is an attempt at fixing the maxcpus=n behavior
> on arm64. So far we have disabled hotplugging a CPU > n,
> when maxcpus=n is in effect, due to following reasons.
> 
>  1) Possible cpu feature incompatibilities with the new CPU
>     in heterogeneous systems.
>  2) New CPU requiring an errata work around which was not detected
>     (and the code patched in) at boot time.
>  3) Failure to initialise the PMU in case the supported CPUs are
>     not online while probing the PMU.
> 
> (1) has been mostly solved with our early CPU feature verification
> support. This series tries to address (2) & (3).
> 
> (2) is solved by iterating over the known erratas and checking if
> the new CPU requires an errata not set in the cpu_hwcaps, failing
> which, we kill the CPU. We plan to fix this properly by retaining
> the CPU errata work arounds and apply the required at runtime.
> 
> (3) is ignored and will not be fixed as there is no reliable way of
> knowing if there would be a CPU that will be online to support the
> PMU.
> 
> In the process, also restores the capability to check GIC interface settings
> by the firmware on individual CPUs.
> 
> Tested on Juno with maxcpus=2 (enables A57 cores and A57-PMU) and
> maxcpus=1 (disables both A57 cores and A57-PMU).
> 
> This series applies on aarch64/for-next/core :
> 
> The tree is available here :
> 	git://linux-arm.org/linux-skp.git maxcpus/v5
> 
> Changes since V4:
>  - Address Catalin's comments
>  - Rebased to aarch64 for-next/core
>  - Add Reviewed/Acked bys.

I merged this yesterday onto for-next/core. Please can you check that
I fixed everything up that you expected?

Will

WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: linux-arm-kernel@lists.infradead.org, mark.rutland@arm.com,
	marc.zyngier@arm.com, linux-kernel@vger.kernel.org,
	catalin.marinas@arm.com, Vadim.Lomovtsev@caviumnetworks.com
Subject: Re: [PATCH v5 0/5] arm64: Fix behavior of maxcpus=n
Date: Tue, 26 Apr 2016 15:50:46 +0100	[thread overview]
Message-ID: <20160426145046.GB1793@arm.com> (raw)
In-Reply-To: <1461682140-7131-1-git-send-email-suzuki.poulose@arm.com>

On Tue, Apr 26, 2016 at 03:48:55PM +0100, Suzuki K Poulose wrote:
> This series is an attempt at fixing the maxcpus=n behavior
> on arm64. So far we have disabled hotplugging a CPU > n,
> when maxcpus=n is in effect, due to following reasons.
> 
>  1) Possible cpu feature incompatibilities with the new CPU
>     in heterogeneous systems.
>  2) New CPU requiring an errata work around which was not detected
>     (and the code patched in) at boot time.
>  3) Failure to initialise the PMU in case the supported CPUs are
>     not online while probing the PMU.
> 
> (1) has been mostly solved with our early CPU feature verification
> support. This series tries to address (2) & (3).
> 
> (2) is solved by iterating over the known erratas and checking if
> the new CPU requires an errata not set in the cpu_hwcaps, failing
> which, we kill the CPU. We plan to fix this properly by retaining
> the CPU errata work arounds and apply the required at runtime.
> 
> (3) is ignored and will not be fixed as there is no reliable way of
> knowing if there would be a CPU that will be online to support the
> PMU.
> 
> In the process, also restores the capability to check GIC interface settings
> by the firmware on individual CPUs.
> 
> Tested on Juno with maxcpus=2 (enables A57 cores and A57-PMU) and
> maxcpus=1 (disables both A57 cores and A57-PMU).
> 
> This series applies on aarch64/for-next/core :
> 
> The tree is available here :
> 	git://linux-arm.org/linux-skp.git maxcpus/v5
> 
> Changes since V4:
>  - Address Catalin's comments
>  - Rebased to aarch64 for-next/core
>  - Add Reviewed/Acked bys.

I merged this yesterday onto for-next/core. Please can you check that
I fixed everything up that you expected?

Will

  parent reply	other threads:[~2016-04-26 14:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-26 14:48 [PATCH v5 0/5] arm64: Fix behavior of maxcpus=n Suzuki K Poulose
2016-04-26 14:48 ` Suzuki K Poulose
2016-04-26 14:48 ` [PATCH v5 1/5] arm64: cpufeature: Add scope for capability check Suzuki K Poulose
2016-04-26 14:48   ` Suzuki K Poulose
2016-04-26 14:48 ` [PATCH v5 2/5] arm64: Allow a capability to be checked on a single CPU Suzuki K Poulose
2016-04-26 14:48   ` Suzuki K Poulose
2016-04-26 14:48 ` [PATCH v5 3/5] irqchip/gic: Restore CPU interface checking Suzuki K Poulose
2016-04-26 14:48   ` Suzuki K Poulose
2016-04-26 14:48 ` [PATCH v5 4/5] arm64: Verify CPU errata work arounds on hotplugged CPU Suzuki K Poulose
2016-04-26 14:48   ` Suzuki K Poulose
2016-04-26 14:49 ` [PATCH v5 5/5] arm64: Fix behavior of maxcpus=N Suzuki K Poulose
2016-04-26 14:49   ` Suzuki K Poulose
2016-04-26 14:50 ` Will Deacon [this message]
2016-04-26 14:50   ` [PATCH v5 0/5] arm64: Fix behavior of maxcpus=n Will Deacon
2016-04-26 14:56   ` Suzuki K Poulose
2016-04-26 14:56     ` Suzuki K Poulose

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160426145046.GB1793@arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.