From: Andreas Dannenberg <dannenberg@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Kumar Gala <galak@codeaurora.org>
Subject: Re: [PATCH v3 1/2] ASoC: codecs: add TA5720 digital amplifier DT bindings
Date: Tue, 26 Apr 2016 11:14:25 -0500 [thread overview]
Message-ID: <20160426161425.GA2885@borg.dal.design.ti.com> (raw)
In-Reply-To: <20160426153707.GZ3217@sirena.org.uk>
On Tue, Apr 26, 2016 at 04:37:07PM +0100, Mark Brown wrote:
> On Mon, Apr 25, 2016 at 03:17:35PM -0500, Andreas Dannenberg wrote:
>
> > +Optional properties:
> > +
> > +- dvdd-supply : phandle to a 3.3-V supply for the digital circuitry
> > +- pvdd-supply : phandle to a supply used for the Class-D amp and the analog
>
> This suggests that the device doesn't need power...
Hi Mark,
no power, now that would be nice! :) What this was supposed to mean is
that the properties are optional, the power of course is not. The DT has
really no control over how I wire up my HW and I'd argue most folks just
permanently power the TAS5720 since the shutdown current is just a few
uAs IIRC in order to save some BOM cost. But I suppose the DT description
is such that the Kernel can more intelligently handle things based on
what the driver is doing if somebody choses and implements additional
regulator/power switch HW. Or did I misunderstand your point?
Thanks,
Andreas
WARNING: multiple messages have this Message-ID (diff)
From: Andreas Dannenberg <dannenberg@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: <alsa-devel@alsa-project.org>, <devicetree@vger.kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/2] ASoC: codecs: add TA5720 digital amplifier DT bindings
Date: Tue, 26 Apr 2016 11:14:25 -0500 [thread overview]
Message-ID: <20160426161425.GA2885@borg.dal.design.ti.com> (raw)
In-Reply-To: <20160426153707.GZ3217@sirena.org.uk>
On Tue, Apr 26, 2016 at 04:37:07PM +0100, Mark Brown wrote:
> On Mon, Apr 25, 2016 at 03:17:35PM -0500, Andreas Dannenberg wrote:
>
> > +Optional properties:
> > +
> > +- dvdd-supply : phandle to a 3.3-V supply for the digital circuitry
> > +- pvdd-supply : phandle to a supply used for the Class-D amp and the analog
>
> This suggests that the device doesn't need power...
Hi Mark,
no power, now that would be nice! :) What this was supposed to mean is
that the properties are optional, the power of course is not. The DT has
really no control over how I wire up my HW and I'd argue most folks just
permanently power the TAS5720 since the shutdown current is just a few
uAs IIRC in order to save some BOM cost. But I suppose the DT description
is such that the Kernel can more intelligently handle things based on
what the driver is doing if somebody choses and implements additional
regulator/power switch HW. Or did I misunderstand your point?
Thanks,
Andreas
next prev parent reply other threads:[~2016-04-26 16:14 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 20:17 [PATCH v3 0/2] ASoC: codecs: add support for TAS5720 digital amplifier Andreas Dannenberg
2016-04-25 20:17 ` Andreas Dannenberg
2016-04-25 20:17 ` [PATCH v3 1/2] ASoC: codecs: add TA5720 digital amplifier DT bindings Andreas Dannenberg
2016-04-25 20:17 ` Andreas Dannenberg
[not found] ` <1461615456-19510-2-git-send-email-dannenberg-l0cyMroinI0@public.gmane.org>
2016-04-26 15:37 ` Mark Brown
2016-04-26 15:37 ` Mark Brown
2016-04-26 16:14 ` Andreas Dannenberg [this message]
2016-04-26 16:14 ` Andreas Dannenberg
2016-04-26 16:50 ` Mark Brown
2016-04-26 16:50 ` Mark Brown
2016-04-26 17:00 ` Andreas Dannenberg
2016-04-26 17:00 ` Andreas Dannenberg
2016-04-25 20:17 ` [PATCH v3 2/2] ASoC: codecs: add support for TAS5720 digital amplifier Andreas Dannenberg
2016-04-25 20:17 ` Andreas Dannenberg
[not found] ` <1461615456-19510-3-git-send-email-dannenberg-l0cyMroinI0@public.gmane.org>
2016-04-26 15:43 ` Mark Brown
2016-04-26 15:43 ` Mark Brown
2016-04-26 16:22 ` Andreas Dannenberg
2016-04-26 16:22 ` Andreas Dannenberg
2016-04-26 17:29 ` Mark Brown
2016-04-26 17:29 ` Mark Brown
2016-04-26 18:01 ` Andreas Dannenberg
2016-04-26 18:01 ` Andreas Dannenberg
2016-05-13 11:55 ` Mark Brown
2016-05-13 14:04 ` Andreas Dannenberg
2016-05-13 14:04 ` Andreas Dannenberg
2016-04-26 17:19 ` Andrew F. Davis
2016-04-26 17:19 ` Andrew F. Davis
2016-04-26 17:37 ` Andreas Dannenberg
2016-04-26 17:37 ` Andreas Dannenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160426161425.GA2885@borg.dal.design.ti.com \
--to=dannenberg@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.