* [PATCH 1/2] SMPdesign: add missing tildes
2016-04-26 23:33 [PATCH 0/2] SMPdesign: fixup trivial nitpicks SeongJae Park
@ 2016-04-26 23:33 ` SeongJae Park
2016-04-26 23:33 ` [PATCH 2/2] SMPdesign: keep consistent expression SeongJae Park
2016-04-26 23:47 ` [PATCH 0/2] SMPdesign: fixup trivial nitpicks Paul E. McKenney
2 siblings, 0 replies; 4+ messages in thread
From: SeongJae Park @ 2016-04-26 23:33 UTC (permalink / raw)
To: paulmck; +Cc: perfbook, SeongJae Park
Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
SMPdesign/SMPdesign.tex | 2 +-
SMPdesign/partexercises.tex | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/SMPdesign/SMPdesign.tex b/SMPdesign/SMPdesign.tex
index 72ea870..d2b092d 100644
--- a/SMPdesign/SMPdesign.tex
+++ b/SMPdesign/SMPdesign.tex
@@ -954,7 +954,7 @@ We could simply assign each CPU one gigabyte of memory, and allow
each CPU to access its own private chunk of memory, without the
need for locking and its complexities and overheads.
Unfortunately, this simple scheme breaks down if an algorithm happens
-to have CPU 0 allocate all of the memory and CPU 1 the free it, as
+to have CPU~0 allocate all of the memory and CPU~1 the free it, as
would happen in a simple producer-consumer workload.
The other extreme, code locking, suffers from excessive lock contention
diff --git a/SMPdesign/partexercises.tex b/SMPdesign/partexercises.tex
index 5d46e70..8b3aa18 100644
--- a/SMPdesign/partexercises.tex
+++ b/SMPdesign/partexercises.tex
@@ -597,7 +597,7 @@ and \co{pdeq_pop_r()} implementations separately.
The \co{pdeq_pop_l()} implementation is shown on lines~1-16
of the figure.
-Line 5 acquires the left-hand lock, which line~14 releases.
+Line~5 acquires the left-hand lock, which line~14 releases.
Line~6 attempts to left-dequeue an element from the left-hand underlying
double-ended queue, and, if successful, skips lines~8-13 to simply
return this element.
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] SMPdesign: keep consistent expression
2016-04-26 23:33 [PATCH 0/2] SMPdesign: fixup trivial nitpicks SeongJae Park
2016-04-26 23:33 ` [PATCH 1/2] SMPdesign: add missing tildes SeongJae Park
@ 2016-04-26 23:33 ` SeongJae Park
2016-04-26 23:47 ` [PATCH 0/2] SMPdesign: fixup trivial nitpicks Paul E. McKenney
2 siblings, 0 replies; 4+ messages in thread
From: SeongJae Park @ 2016-04-26 23:33 UTC (permalink / raw)
To: paulmck; +Cc: perfbook, SeongJae Park
There are few inconsistent expressions for code / type mentioning and
reference to figure / source file. This commit polishes the expressions
to be more consistent with other expressions.
Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
SMPdesign/SMPdesign.tex | 4 ++--
SMPdesign/beyond.tex | 6 ++++--
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/SMPdesign/SMPdesign.tex b/SMPdesign/SMPdesign.tex
index d2b092d..f609e7e 100644
--- a/SMPdesign/SMPdesign.tex
+++ b/SMPdesign/SMPdesign.tex
@@ -991,11 +991,11 @@ Figure~\ref{fig:SMPdesign:Allocator-Cache Data Structures}.
The ``Global Pool'' of Figure~\ref{fig:SMPdesign:Allocator Cache Schematic}
is implemented by \co{globalmem} of type \co{struct globalmempool},
and the two CPU pools by the per-CPU variable \co{percpumem} of
-type \co{percpumempool}.
+type \co{struct percpumempool}.
Both of these data structures have arrays of pointers to blocks
in their \co{pool} fields, which are filled from index zero upwards.
Thus, if \co{globalmem.pool[3]} is \co{NULL}, then the remainder of
-the array from index 4 up must also be NULL.
+the array from index 4 up must also be \co{NULL}.
The \co{cur} fields contain the index of the highest-numbered full
element of the \co{pool} array, or -1 if all elements are empty.
All elements from \co{globalmem.pool[0]} through
diff --git a/SMPdesign/beyond.tex b/SMPdesign/beyond.tex
index f4035cd..e52980b 100644
--- a/SMPdesign/beyond.tex
+++ b/SMPdesign/beyond.tex
@@ -135,7 +135,8 @@ Line~20 initializes for the next pass through the outer loop.
\end{figure}
The pseudocode for \co{maze_try_visit_cell()} is shown on lines~1-12
-of Figure~\ref{fig:SMPdesign:SEQ Helper Pseudocode}.
+of Figure~\ref{fig:SMPdesign:SEQ Helper Pseudocode}
+(\co{maze.c}).
Line~4 checks to see if cells \co{c} and \co{n} are adjacent and connected,
while line~5 checks to see if cell \co{n} has not yet been visited.
The \co{celladdr()} function returns the address of the specified cell.
@@ -146,7 +147,8 @@ is now full, and line~10 marks this cell as visited and also records
the distance from the maze start. Line~11 then returns success.
The pseudocode for \co{maze_find_any_next_cell()} is shown on lines~14-28
-of the figure (\co{maze.c}).
+of Figure~\ref{fig:SMPdesign:SEQ Helper Pseudocode}
+(\co{maze.c}).
Line~17 picks up the current cell's distance plus 1,
while lines~19, 21, 23, and~25
check the cell in each direction, and lines~20, 22, 24, and~26
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 0/2] SMPdesign: fixup trivial nitpicks
2016-04-26 23:33 [PATCH 0/2] SMPdesign: fixup trivial nitpicks SeongJae Park
2016-04-26 23:33 ` [PATCH 1/2] SMPdesign: add missing tildes SeongJae Park
2016-04-26 23:33 ` [PATCH 2/2] SMPdesign: keep consistent expression SeongJae Park
@ 2016-04-26 23:47 ` Paul E. McKenney
2 siblings, 0 replies; 4+ messages in thread
From: Paul E. McKenney @ 2016-04-26 23:47 UTC (permalink / raw)
To: SeongJae Park; +Cc: perfbook
On Wed, Apr 27, 2016 at 08:33:13AM +0900, SeongJae Park wrote:
> This patchset contains fixup of trivial nitpicks that found during translation
> of SMPdesign/ directory.
Good eyes, queued and pushed them both.
Thanx, Paul
> SeongJae Park (2):
> SMPdesign: add missing tildes
> SMPdesign: keep consistent expression
>
> SMPdesign/SMPdesign.tex | 6 +++---
> SMPdesign/beyond.tex | 6 ++++--
> SMPdesign/partexercises.tex | 2 +-
> 3 files changed, 8 insertions(+), 6 deletions(-)
>
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread