All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Petr Mladek <pmladek@suse.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Russell King <rmk+kernel@arm.linux.org.uk>,
	Daniel Thompson <daniel.thompson@linaro.org>,
	Jiri Kosina <jkosina@suse.com>, Ingo Molnar <mingo@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Chris Metcalf <cmetcalf@ezchip.com>,
	linux-kernel@vger.kernel.org, x86@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	adi-buildroot-devel@lists.sourceforge.net,
	linux-cris-kernel@axis.com, linux-mips@linux-mips.org,
	linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org,
	linux-sh@vger.kernel.org, sparclinux@vger.kernel.org
Subject: Re: [PATCH v5 4/4] printk/nmi: flush NMI messages on the system panic
Date: Wed, 27 Apr 2016 09:34:09 +0900	[thread overview]
Message-ID: <20160427003409.GA4782@swordfish> (raw)
In-Reply-To: <20160426142157.GK2749@pathway.suse.cz>

On (04/26/16 16:21), Petr Mladek wrote:
[..]
> > move printk_nmi_flush_on_panic() to printk.c, and place it next to
> > printk_flush_on_panic() (so we will have two printk "flush-on-panic"
> > functions sitting together). /* printk_nmi_flush() is in printk.h,
> > so it's visible to printk anyway */
> > 
> > it also will let us keep logbuf_lock static, it's a bit too internal
> > to printk to expose it, I think.
> > 
> > IOW, something like this?
> 
> It is rather cosmetic change. I 

oh yes, it is. just to keep similar functionality (flush, zap locks)
in one place (printk).

	-ss

WARNING: multiple messages have this Message-ID (diff)
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 4/4] printk/nmi: flush NMI messages on the system panic
Date: Wed, 27 Apr 2016 00:34:09 +0000	[thread overview]
Message-ID: <20160427003409.GA4782@swordfish> (raw)
In-Reply-To: <20160426142157.GK2749@pathway.suse.cz>

On (04/26/16 16:21), Petr Mladek wrote:
[..]
> > move printk_nmi_flush_on_panic() to printk.c, and place it next to
> > printk_flush_on_panic() (so we will have two printk "flush-on-panic"
> > functions sitting together). /* printk_nmi_flush() is in printk.h,
> > so it's visible to printk anyway */
> > 
> > it also will let us keep logbuf_lock static, it's a bit too internal
> > to printk to expose it, I think.
> > 
> > IOW, something like this?
> 
> It is rather cosmetic change. I 

oh yes, it is. just to keep similar functionality (flush, zap locks)
in one place (printk).

	-ss

WARNING: multiple messages have this Message-ID (diff)
From: sergey.senozhatsky.work@gmail.com (Sergey Senozhatsky)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 4/4] printk/nmi: flush NMI messages on the system panic
Date: Wed, 27 Apr 2016 09:34:09 +0900	[thread overview]
Message-ID: <20160427003409.GA4782@swordfish> (raw)
In-Reply-To: <20160426142157.GK2749@pathway.suse.cz>

On (04/26/16 16:21), Petr Mladek wrote:
[..]
> > move printk_nmi_flush_on_panic() to printk.c, and place it next to
> > printk_flush_on_panic() (so we will have two printk "flush-on-panic"
> > functions sitting together). /* printk_nmi_flush() is in printk.h,
> > so it's visible to printk anyway */
> > 
> > it also will let us keep logbuf_lock static, it's a bit too internal
> > to printk to expose it, I think.
> > 
> > IOW, something like this?
> 
> It is rather cosmetic change. I 

oh yes, it is. just to keep similar functionality (flush, zap locks)
in one place (printk).

	-ss

  reply	other threads:[~2016-04-27  0:32 UTC|newest]

Thread overview: 97+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-21 11:48 [PATCH v5 0/4] Cleaning printk stuff in NMI context Petr Mladek
2016-04-21 11:48 ` Petr Mladek
2016-04-21 11:48 ` Petr Mladek
2016-04-21 11:48 ` [PATCH v5 1/4] printk/nmi: generic solution for safe printk in NMI Petr Mladek
2016-04-21 11:48   ` Petr Mladek
2016-04-21 11:48   ` Petr Mladek
2016-04-27  9:31   ` Russell King - ARM Linux
2016-04-27  9:31     ` Russell King - ARM Linux
2016-04-27  9:31     ` Russell King - ARM Linux
2017-04-19 17:13   ` Steven Rostedt
2017-04-19 17:13     ` Steven Rostedt
2017-04-19 17:13     ` Steven Rostedt
2017-04-19 17:21     ` Peter Zijlstra
2017-04-19 17:21       ` Peter Zijlstra
2017-04-19 17:21       ` Peter Zijlstra
2017-04-20  3:31     ` Sergey Senozhatsky
2017-04-20  3:31       ` Sergey Senozhatsky
2017-04-20  3:31       ` Sergey Senozhatsky
2017-04-20 13:11       ` Petr Mladek
2017-04-20 13:11         ` Petr Mladek
2017-04-20 13:11         ` Petr Mladek
2017-04-20 13:11         ` Petr Mladek
2017-04-21  1:57         ` Sergey Senozhatsky
2017-04-21  1:57           ` Sergey Senozhatsky
2017-04-21  1:57           ` Sergey Senozhatsky
2017-04-21 12:06           ` Petr Mladek
2017-04-21 12:06             ` Petr Mladek
2017-04-21 12:06             ` Petr Mladek
2017-04-24  2:17             ` Sergey Senozhatsky
2017-04-24  2:17               ` Sergey Senozhatsky
2017-04-24  2:17               ` Sergey Senozhatsky
2017-04-27 13:38               ` Petr Mladek
2017-04-27 13:38                 ` Petr Mladek
2017-04-27 13:38                 ` Petr Mladek
2017-04-27 14:31                 ` Steven Rostedt
2017-04-27 14:31                   ` Steven Rostedt
2017-04-27 14:31                   ` Steven Rostedt
2017-04-27 15:28                   ` Petr Mladek
2017-04-27 15:28                     ` Petr Mladek
2017-04-27 15:28                     ` Petr Mladek
2017-04-27 15:42                     ` Steven Rostedt
2017-04-27 15:42                       ` Steven Rostedt
2017-04-27 15:42                       ` Steven Rostedt
2017-04-28  9:02                 ` Peter Zijlstra
2017-04-28  9:02                   ` Peter Zijlstra
2017-04-28  9:02                   ` Peter Zijlstra
2017-04-28 13:44                   ` Petr Mladek
2017-04-28 13:44                     ` Petr Mladek
2017-04-28 13:44                     ` Petr Mladek
2017-04-28 13:58                     ` Peter Zijlstra
2017-04-28 13:58                       ` Peter Zijlstra
2017-04-28 13:58                       ` Peter Zijlstra
2017-04-28 14:47                       ` Steven Rostedt
2017-04-28 14:47                         ` Steven Rostedt
2017-04-28 14:47                         ` Steven Rostedt
2017-04-27 16:14         ` Steven Rostedt
2017-04-27 16:14           ` Steven Rostedt
2017-04-27 16:14           ` Steven Rostedt
2017-04-28  1:35           ` Sergey Senozhatsky
2017-04-28  1:35             ` Sergey Senozhatsky
2017-04-28  1:35             ` Sergey Senozhatsky
2017-04-28 12:57             ` Petr Mladek
2017-04-28 12:57               ` Petr Mladek
2017-04-28 12:57               ` Petr Mladek
2017-04-28 14:16               ` Steven Rostedt
2017-04-28 14:16                 ` Steven Rostedt
2017-04-28 14:16                 ` Steven Rostedt
2017-04-28  1:25         ` Sergey Senozhatsky
2017-04-28  1:25           ` Sergey Senozhatsky
2017-04-28  1:25           ` Sergey Senozhatsky
2017-04-28 12:38           ` Petr Mladek
2017-04-28 12:38             ` Petr Mladek
2017-04-28 12:38             ` Petr Mladek
2016-04-21 11:48 ` [PATCH v5 2/4] printk/nmi: warn when some message has been lost in NMI context Petr Mladek
2016-04-21 11:48   ` Petr Mladek
2016-04-21 11:48   ` Petr Mladek
2016-04-27  9:34   ` Russell King - ARM Linux
2016-04-27  9:34     ` Russell King - ARM Linux
2016-04-27  9:34     ` Russell King - ARM Linux
2016-04-21 11:48 ` [PATCH v5 3/4] printk/nmi: increase the size of NMI buffer and make it configurable Petr Mladek
2016-04-21 11:48   ` Petr Mladek
2016-04-21 11:48   ` Petr Mladek
2016-04-21 11:48 ` [PATCH v5 4/4] printk/nmi: flush NMI messages on the system panic Petr Mladek
2016-04-21 11:48   ` Petr Mladek
2016-04-21 11:48   ` Petr Mladek
2016-04-23  3:49   ` Sergey Senozhatsky
2016-04-23  3:49     ` Sergey Senozhatsky
2016-04-23  3:49     ` Sergey Senozhatsky
2016-04-26 14:21     ` Petr Mladek
2016-04-26 14:21       ` Petr Mladek
2016-04-26 14:21       ` Petr Mladek
2016-04-27  0:34       ` Sergey Senozhatsky [this message]
2016-04-27  0:34         ` Sergey Senozhatsky
2016-04-27  0:34         ` Sergey Senozhatsky
2016-04-27  0:36 ` [PATCH v5 0/4] Cleaning printk stuff in NMI context Sergey Senozhatsky
2016-04-27  0:36   ` Sergey Senozhatsky
2016-04-27  0:36   ` Sergey Senozhatsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160427003409.GA4782@swordfish \
    --to=sergey.senozhatsky.work@gmail.com \
    --cc=adi-buildroot-devel@lists.sourceforge.net \
    --cc=akpm@linux-foundation.org \
    --cc=cmetcalf@ezchip.com \
    --cc=daniel.thompson@linaro.org \
    --cc=jkosina@suse.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-cris-kernel@axis.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=pmladek@suse.com \
    --cc=rmk+kernel@arm.linux.org.uk \
    --cc=rostedt@goodmis.org \
    --cc=sparclinux@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.