From: Beniamino Galvani <b.galvani@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5 3/4] arm: add initial support for Amlogic Meson and ODROID-C2
Date: Wed, 27 Apr 2016 12:58:32 +0200 [thread overview]
Message-ID: <20160427105832.GA2586@gmail.com> (raw)
In-Reply-To: <20160425205309.GB29322@bill-the-cat>
On Mon, Apr 25, 2016 at 04:53:09PM -0400, Tom Rini wrote:
> > +#if !defined(CONFIG_IDENT_STRING)
> > +# define CONFIG_IDENT_STRING " odroid-c2"
> > +#endif
>
> Would this ever already be set?
No, it shouldn't.
> > +/* Serial setup */
> > +#define CONFIG_CONS_INDEX 0
> > +#define CONFIG_BAUDRATE 115200
> > +#define CONFIG_SYS_BAUDRATE_TABLE \
> > + { 4800, 9600, 19200, 38400, 57600, 115200 }
>
> And I assume you could live with the default table really.
Right.
I will fix both and resubmit, thanks!
Beniamino
next prev parent reply other threads:[~2016-04-27 10:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-24 6:49 [U-Boot] [PATCH v5 0/4] Amlogic Meson GXBaby and ODROID-C2 support Beniamino Galvani
2016-04-24 6:49 ` [U-Boot] [PATCH v5 1/4] arm: implement generic PSCI reset call for armv8 Beniamino Galvani
2016-04-24 6:50 ` [U-Boot] [PATCH v5 2/4] net: designware: fix descriptor layout and warnings on 64-bit archs Beniamino Galvani
2016-04-25 18:01 ` Joe Hershberger
2016-04-25 20:17 ` Beniamino Galvani
2016-04-25 20:32 ` Joe Hershberger
2016-04-25 20:40 ` Marek Vasut
2016-04-25 20:43 ` Tom Rini
2016-04-24 6:50 ` [U-Boot] [PATCH v5 3/4] arm: add initial support for Amlogic Meson and ODROID-C2 Beniamino Galvani
2016-04-25 20:53 ` Tom Rini
2016-04-27 10:58 ` Beniamino Galvani [this message]
2016-05-01 18:56 ` Simon Glass
2016-05-01 18:58 ` Tom Rini
2016-05-08 6:35 ` Beniamino Galvani
2016-04-24 6:50 ` [U-Boot] [PATCH v5 4/4] arm: meson: implement calls to secure monitor Beniamino Galvani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160427105832.GA2586@gmail.com \
--to=b.galvani@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.