From: Mel Gorman <mgorman@techsingularity.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Vlastimil Babka <vbabka@suse.cz>,
Jesper Dangaard Brouer <brouer@redhat.com>,
Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] mm, page_alloc: inline the fast path of the zonelist iterator -fix
Date: Wed, 27 Apr 2016 13:30:09 +0100 [thread overview]
Message-ID: <20160427123009.GH2858@techsingularity.net> (raw)
In-Reply-To: <1461759885-17163-3-git-send-email-mgorman@techsingularity.net>
On Wed, Apr 27, 2016 at 01:24:43PM +0100, Mel Gorman wrote:
> Vlastimil Babka pointed out that the nodes allowed by a cpuset are not
> reread if the nodemask changes during an allocation. This potentially
> allows an unnecessary page allocation failure. Moving the retry_cpuset
> label is insufficient but rereading the nodemask before retrying addresses
> the problem.
>
> This is a fix to the mmotm patch
> mm-page_alloc-inline-the-fast-path-of-the-zonelist-iterator.patch .
>
> Suggested-by: Vlastimil Babka <vbabka@suse.cz>
> Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
And this is wrong :( . I'll think again.
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@techsingularity.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Vlastimil Babka <vbabka@suse.cz>,
Jesper Dangaard Brouer <brouer@redhat.com>,
Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] mm, page_alloc: inline the fast path of the zonelist iterator -fix
Date: Wed, 27 Apr 2016 13:30:09 +0100 [thread overview]
Message-ID: <20160427123009.GH2858@techsingularity.net> (raw)
In-Reply-To: <1461759885-17163-3-git-send-email-mgorman@techsingularity.net>
On Wed, Apr 27, 2016 at 01:24:43PM +0100, Mel Gorman wrote:
> Vlastimil Babka pointed out that the nodes allowed by a cpuset are not
> reread if the nodemask changes during an allocation. This potentially
> allows an unnecessary page allocation failure. Moving the retry_cpuset
> label is insufficient but rereading the nodemask before retrying addresses
> the problem.
>
> This is a fix to the mmotm patch
> mm-page_alloc-inline-the-fast-path-of-the-zonelist-iterator.patch .
>
> Suggested-by: Vlastimil Babka <vbabka@suse.cz>
> Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
And this is wrong :( . I'll think again.
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2016-04-27 12:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-27 12:24 [PATCH 0/4] Optimise page alloc/free fast paths followup v1 Mel Gorman
2016-04-27 12:24 ` Mel Gorman
2016-04-27 12:24 ` [PATCH 1/4] mm, page_alloc: Only check PageCompound for high-order pages -fix Mel Gorman
2016-04-27 12:24 ` Mel Gorman
2016-04-27 12:24 ` [PATCH 2/4] mm, page_alloc: inline the fast path of the zonelist iterator -fix Mel Gorman
2016-04-27 12:24 ` Mel Gorman
2016-04-27 12:30 ` Mel Gorman [this message]
2016-04-27 12:30 ` Mel Gorman
2016-04-27 12:24 ` [PATCH 3/4] mm, page_alloc: move might_sleep_if check to the allocator slowpath -revert Mel Gorman
2016-04-27 12:24 ` Mel Gorman
2016-04-27 12:24 ` [PATCH 4/4] mm, page_alloc: Check once if a zone has isolated pageblocks -fix Mel Gorman
2016-04-27 12:24 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160427123009.GH2858@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=akpm@linux-foundation.org \
--cc=brouer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.