From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/8] package/glmark2: gl support also depends on X.org
Date: Wed, 27 Apr 2016 21:32:30 +0200 [thread overview]
Message-ID: <20160427213230.0ee9fe71@free-electrons.com> (raw)
In-Reply-To: <1461586822-1003-2-git-send-email-bernd.kuhls@t-online.de>
Hello,
On Mon, 25 Apr 2016 14:20:16 +0200, Bernd Kuhls wrote:
> diff --git a/package/glmark2/Config.in b/package/glmark2/Config.in
> index 9167fc5..10c88ee 100644
> --- a/package/glmark2/Config.in
> +++ b/package/glmark2/Config.in
> @@ -7,7 +7,7 @@ config BR2_PACKAGE_GLMARK2_EGL_GLES
> config BR2_PACKAGE_GLMARK2_GL
> bool
> default y
> - depends on BR2_PACKAGE_MESA3D_DRI_DRIVER
> + depends on BR2_PACKAGE_MESA3D_OPENGL_GL
I know that may sound like a nitpicking debate, but I'm wondering if we
shouldn't keep BR2_PACKAGE_MESA3D_OPENGL_GL as an internal mesa3d
symbol, and instead use:
depends on BR2_PACKAGE_HAS_LIBGL && BR2_PACKAGE_MESA3D
which really expresses what we want: we want an OpenGL implementation,
and this OpenGL implementation has to be mesa3d.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-04-27 19:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 12:20 [Buildroot] [PATCH 1/8] package/mesa3d: introduce new Kconfig option to indicate full OpenGL support Bernd Kuhls
2016-04-25 12:20 ` [Buildroot] [PATCH 2/8] package/glmark2: gl support also depends on X.org Bernd Kuhls
2016-04-27 19:05 ` Gustavo Zacarias
2016-04-27 19:32 ` Thomas Petazzoni [this message]
2016-04-27 19:38 ` Gustavo Zacarias
2016-04-27 19:49 ` Thomas Petazzoni
2016-04-27 19:54 ` Gustavo Zacarias
2016-04-27 20:52 ` Bernd Kuhls
2016-04-25 12:20 ` [Buildroot] [PATCH 3/8] package/kodi: Update OpenGL check Bernd Kuhls
2016-04-27 19:05 ` Gustavo Zacarias
2016-04-25 12:20 ` [Buildroot] [PATCH 4/8] package/libva: " Bernd Kuhls
2016-04-27 19:06 ` Gustavo Zacarias
2016-04-25 12:20 ` [Buildroot] [PATCH 5/8] package/x11r7/xdriver_xf86-video-intel: " Bernd Kuhls
2016-04-27 19:06 ` Gustavo Zacarias
2016-04-25 12:20 ` [Buildroot] [PATCH 6/8] package/x11r7/xdriver_xf86-video-mach64: " Bernd Kuhls
2016-04-27 19:07 ` Gustavo Zacarias
2016-04-25 12:20 ` [Buildroot] [PATCH 7/8] package/x11r7/xdriver_xf86-video-r128: " Bernd Kuhls
2016-04-27 19:11 ` Gustavo Zacarias
2016-04-25 12:20 ` [Buildroot] [PATCH 8/8] package/x11r7/xserver_xorg-server: " Bernd Kuhls
2016-04-27 19:11 ` Gustavo Zacarias
2016-04-27 19:04 ` [Buildroot] [PATCH 1/8] package/mesa3d: introduce new Kconfig option to indicate full OpenGL support Gustavo Zacarias
2016-04-27 19:30 ` Thomas Petazzoni
2016-04-27 20:46 ` Bernd Kuhls
2016-04-27 20:56 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160427213230.0ee9fe71@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.