From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/8] package/mesa3d: introduce new Kconfig option to indicate full OpenGL support
Date: Wed, 27 Apr 2016 22:56:19 +0200 [thread overview]
Message-ID: <20160427225619.39a3c7e7@free-electrons.com> (raw)
In-Reply-To: <XnsA5F7E7BF5206DID313208userindividu@bernd-kuhls.de>
Hello,
On Wed, 27 Apr 2016 22:46:54 +0200, Bernd Kuhls wrote:
> the goal of my patch series was to make the presence of OpenGL support in
> mesa3d visible to the user, your proposal is technically also fine with me
> but it needs more technical experience by users to enable the correct
> options to enable OpenGL support because the OpenGL option is a blind one.
Right, but your implementation is really weird. Due to:
+ select BR2_PACKAGE_MESA3D_OPENGL_GL if BR2_PACKAGE_XORG7
even if the user does *NOT* enable BR2_PACKAGE_MESA3D_OPENGL_GL, it
will get forcefully selected as soon as the dependencies
(BR2_PACKAGE_XORG7 && BR2_PACKAGE_MESA3D_DRI_DRIVER) are enabled.
In the end, you're creating an option that is not an option!
If you really want, you can improve my proposal by doing:
config BR2_PACKAGE_MESA3D_OPENGL_GL
bool
default y
depends on BR2_PACKAGE_XORG7
depends on BR2_PACKAGE_MESA3D_DRI_DRIVER
comment "full OpenGL supports needs X.org and a DRI driver"
depends on !BR2_PACKAGE_MESA3D_OPENGL_GL
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2016-04-27 20:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 12:20 [Buildroot] [PATCH 1/8] package/mesa3d: introduce new Kconfig option to indicate full OpenGL support Bernd Kuhls
2016-04-25 12:20 ` [Buildroot] [PATCH 2/8] package/glmark2: gl support also depends on X.org Bernd Kuhls
2016-04-27 19:05 ` Gustavo Zacarias
2016-04-27 19:32 ` Thomas Petazzoni
2016-04-27 19:38 ` Gustavo Zacarias
2016-04-27 19:49 ` Thomas Petazzoni
2016-04-27 19:54 ` Gustavo Zacarias
2016-04-27 20:52 ` Bernd Kuhls
2016-04-25 12:20 ` [Buildroot] [PATCH 3/8] package/kodi: Update OpenGL check Bernd Kuhls
2016-04-27 19:05 ` Gustavo Zacarias
2016-04-25 12:20 ` [Buildroot] [PATCH 4/8] package/libva: " Bernd Kuhls
2016-04-27 19:06 ` Gustavo Zacarias
2016-04-25 12:20 ` [Buildroot] [PATCH 5/8] package/x11r7/xdriver_xf86-video-intel: " Bernd Kuhls
2016-04-27 19:06 ` Gustavo Zacarias
2016-04-25 12:20 ` [Buildroot] [PATCH 6/8] package/x11r7/xdriver_xf86-video-mach64: " Bernd Kuhls
2016-04-27 19:07 ` Gustavo Zacarias
2016-04-25 12:20 ` [Buildroot] [PATCH 7/8] package/x11r7/xdriver_xf86-video-r128: " Bernd Kuhls
2016-04-27 19:11 ` Gustavo Zacarias
2016-04-25 12:20 ` [Buildroot] [PATCH 8/8] package/x11r7/xserver_xorg-server: " Bernd Kuhls
2016-04-27 19:11 ` Gustavo Zacarias
2016-04-27 19:04 ` [Buildroot] [PATCH 1/8] package/mesa3d: introduce new Kconfig option to indicate full OpenGL support Gustavo Zacarias
2016-04-27 19:30 ` Thomas Petazzoni
2016-04-27 20:46 ` Bernd Kuhls
2016-04-27 20:56 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160427225619.39a3c7e7@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.