All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Michal Hocko <mhocko@suse.com>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-mm@kvack.org, dm-devel@redhat.com,
	Mikulas Patocka <mpatocka@redhat.com>,
	Shaohua Li <shli@kernel.org>
Subject: Re: [PATCH 19/20] md: simplify free_params for kmalloc vs vmalloc fallback
Date: Thu, 28 Apr 2016 11:37:31 -0400	[thread overview]
Message-ID: <20160428153730.GA14570@redhat.com> (raw)
In-Reply-To: <1461849846-27209-20-git-send-email-mhocko@kernel.org>

On Thu, Apr 28 2016 at  9:24am -0400,
Michal Hocko <mhocko@kernel.org> wrote:

> From: Michal Hocko <mhocko@suse.com>
> 
> Use kvfree rather than DM_PARAMS_[KV]MALLOC specific param flags.
> 
> Cc: Shaohua Li <shli@kernel.org>
> Cc: Mikulas Patocka <mpatocka@redhat.com>
> Cc: dm-devel@redhat.com
> Signed-off-by: Michal Hocko <mhocko@suse.com>

Nack, seriously, this is the 3rd time this patch has been attempted.
Did you actually test the change?  It'll crash very quickly, see:

https://www.redhat.com/archives/dm-devel/2016-April/msg00103.html

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Mike Snitzer <snitzer@redhat.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Michal Hocko <mhocko@suse.com>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-mm@kvack.org, dm-devel@redhat.com,
	Mikulas Patocka <mpatocka@redhat.com>,
	Shaohua Li <shli@kernel.org>
Subject: Re: [PATCH 19/20] md: simplify free_params for kmalloc vs vmalloc fallback
Date: Thu, 28 Apr 2016 11:37:31 -0400	[thread overview]
Message-ID: <20160428153730.GA14570@redhat.com> (raw)
In-Reply-To: <1461849846-27209-20-git-send-email-mhocko@kernel.org>

On Thu, Apr 28 2016 at  9:24am -0400,
Michal Hocko <mhocko@kernel.org> wrote:

> From: Michal Hocko <mhocko@suse.com>
> 
> Use kvfree rather than DM_PARAMS_[KV]MALLOC specific param flags.
> 
> Cc: Shaohua Li <shli@kernel.org>
> Cc: Mikulas Patocka <mpatocka@redhat.com>
> Cc: dm-devel@redhat.com
> Signed-off-by: Michal Hocko <mhocko@suse.com>

Nack, seriously, this is the 3rd time this patch has been attempted.
Did you actually test the change?  It'll crash very quickly, see:

https://www.redhat.com/archives/dm-devel/2016-April/msg00103.html

  parent reply	other threads:[~2016-04-28 15:37 UTC|newest]

Thread overview: 98+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-28 13:23 [PATCH 0/19] get rid of superfluous __GFP_REPEAT Michal Hocko
2016-04-28 13:23 ` Michal Hocko
2016-04-28 13:23 ` [PATCH 01/20] tree wide: get rid of __GFP_REPEAT for order-0 allocations part I Michal Hocko
2016-04-28 13:23   ` Michal Hocko
2016-04-28 13:23   ` Michal Hocko
2016-04-28 13:23 ` [PATCH 02/20] x86: get rid of superfluous __GFP_REPEAT Michal Hocko
2016-04-28 13:23   ` Michal Hocko
2016-04-28 13:23   ` Michal Hocko
2016-04-28 13:23 ` [PATCH 03/20] x86/efi: " Michal Hocko
2016-04-28 13:23   ` Michal Hocko
2016-04-28 13:23   ` Michal Hocko
2016-04-28 13:23 ` [PATCH 04/20] arm: " Michal Hocko
2016-04-28 13:23   ` Michal Hocko
2016-04-28 13:23   ` Michal Hocko
2016-04-28 14:55   ` Russell King - ARM Linux
2016-04-28 14:55     ` Russell King - ARM Linux
2016-04-28 15:08     ` Michal Hocko
2016-04-28 15:08       ` Michal Hocko
2016-04-29  9:41       ` Michal Hocko
2016-04-29  9:41         ` Michal Hocko
2016-04-28 13:23 ` [PATCH 05/20] arm64: " Michal Hocko
2016-04-28 13:23   ` Michal Hocko
2016-04-28 13:23   ` Michal Hocko
2016-04-28 13:23 ` [PATCH 06/20] arc: " Michal Hocko
2016-04-28 13:23   ` Michal Hocko
2016-04-28 13:23   ` Michal Hocko
2016-04-28 13:23 ` [PATCH 07/20] mips: " Michal Hocko
2016-04-28 13:23   ` Michal Hocko
2016-04-28 13:23   ` Michal Hocko
2016-04-28 13:23 ` [PATCH 08/20] nios2: " Michal Hocko
2016-04-28 13:23   ` Michal Hocko
2016-04-28 13:23   ` Michal Hocko
2016-04-28 13:23 ` [PATCH 09/20] parisc: " Michal Hocko
2016-04-28 13:23   ` Michal Hocko
2016-04-28 13:23   ` Michal Hocko
2016-04-28 13:23 ` [PATCH 10/20] score: " Michal Hocko
2016-04-28 13:23   ` Michal Hocko
2016-04-28 13:23   ` Michal Hocko
2016-04-28 13:23 ` [PATCH 11/20] powerpc: " Michal Hocko
2016-04-28 13:23   ` Michal Hocko
2016-04-28 13:23   ` Michal Hocko
2016-04-28 13:23 ` [PATCH 12/20] sparc: " Michal Hocko
2016-04-28 13:23   ` Michal Hocko
2016-04-28 13:23   ` Michal Hocko
2016-04-28 13:23 ` [PATCH 13/20] s390: " Michal Hocko
2016-04-28 13:23   ` Michal Hocko
2016-04-28 13:23   ` Michal Hocko
2016-04-28 13:24 ` [PATCH 14/20] sh: " Michal Hocko
2016-04-28 13:24   ` Michal Hocko
2016-04-28 13:24   ` Michal Hocko
2016-04-28 13:24 ` [PATCH 15/20] tile: " Michal Hocko
2016-04-28 13:24   ` Michal Hocko
2016-04-28 13:24   ` Michal Hocko
2016-04-28 16:21   ` Chris Metcalf
2016-04-28 16:21     ` Chris Metcalf
2016-04-28 16:21     ` Chris Metcalf
2016-04-28 13:24 ` [PATCH 16/20] unicore32: " Michal Hocko
2016-04-28 13:24   ` Michal Hocko
2016-04-28 13:24   ` Michal Hocko
2016-04-28 13:24 ` [PATCH 17/20] dm: get rid of superfluous gfp flags Michal Hocko
2016-04-28 13:24   ` Michal Hocko
2016-04-28 13:24   ` Michal Hocko
2016-04-29 18:54   ` Mike Snitzer
2016-04-29 18:54     ` Mike Snitzer
2016-05-02  7:31     ` Michal Hocko
2016-05-02  7:31       ` Michal Hocko
2016-04-28 13:24 ` [PATCH 18/20] dm: clean up GFP_NIO usage Michal Hocko
2016-04-28 13:24   ` Michal Hocko
2016-04-28 13:24   ` Michal Hocko
2016-04-28 14:20   ` Mikulas Patocka
2016-04-28 14:20     ` Mikulas Patocka
2016-04-28 14:41     ` Michal Hocko
2016-04-28 14:41       ` Michal Hocko
2016-04-28 13:24 ` [PATCH 19/20] md: simplify free_params for kmalloc vs vmalloc fallback Michal Hocko
2016-04-28 13:24   ` Michal Hocko
2016-04-28 13:24   ` Michal Hocko
2016-04-28 14:51   ` [PATCH] " Michal Hocko
2016-04-28 14:51     ` Michal Hocko
2016-04-28 15:04     ` Mikulas Patocka
2016-04-28 15:04       ` Mikulas Patocka
2016-04-28 15:28       ` Michal Hocko
2016-04-28 15:28         ` Michal Hocko
2016-04-28 15:40         ` Mikulas Patocka
2016-04-28 15:40           ` Mikulas Patocka
2016-04-28 16:59           ` Michal Hocko
2016-04-28 16:59             ` Michal Hocko
2016-04-28 15:37   ` Mike Snitzer [this message]
2016-04-28 15:37     ` [PATCH 19/20] " Mike Snitzer
2016-04-28 16:00     ` Michal Hocko
2016-04-28 16:00       ` Michal Hocko
2016-04-28 13:24 ` [PATCH 20/20] jbd2: get rid of superfluous __GFP_REPEAT Michal Hocko
2016-04-28 13:24   ` Michal Hocko
2016-05-12 16:53 ` [PATCH 0/19] " Michal Hocko
2016-05-12 16:53   ` Michal Hocko
2016-05-12 20:13   ` Andrew Morton
2016-05-12 20:13     ` Andrew Morton
2016-05-13  6:58     ` Michal Hocko
2016-05-13  6:58       ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160428153730.GA14570@redhat.com \
    --to=snitzer@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=dm-devel@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=mhocko@suse.com \
    --cc=mpatocka@redhat.com \
    --cc=shli@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.