From: Jisheng Zhang <jszhang-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
To: Douglas Anderson
<dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
jh80.chung-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org
Cc: shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
adrian.hunter-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
stefan-XLVq0VzYD2Y@public.gmane.org,
linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
vbyravarasu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
justin.wang-lxIno14LUO0EEoCn2XhGlw@public.gmane.org,
ksumrall-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org,
lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org,
dtor-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
huangtao-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
lporzio-AL4WhLSQfzjQT0dZR+AlfA@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
chuanxiao.dong-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
chaotian.jing-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
sudeep.holla-5wv7dgnIgG8@public.gmane.org
Subject: Re: [PATCH 0/3] Patches to allow consistent mmc / mmcblk numbering
Date: Fri, 29 Apr 2016 10:18:36 +0800 [thread overview]
Message-ID: <20160429101836.060ad087@xhacker> (raw)
In-Reply-To: <1461884805-29466-1-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Dear Douglas,
On Thu, 28 Apr 2016 16:06:42 -0700 Douglas Anderson wrote:
> This series picks patches from various different places to produce what
> I consider the best solution to getting consistent mmc and mmcblk
> ordering.
>
> Why consistent ordering and why not just use UUIDs? IMHO consistent
> ordering solves a few different problems:
>
> 1. For poor, feeble-minded humans like me, have sane numbering for
> devices helps a lot. When grepping through dmesg it's terribly handy
> if a given SDMMC device has a consistent number. I know that I can
> do "dmesg | grep mmc0" or "dmesg | grep mmcblk0" to find info about
> the eMMC. I know that I can do "dmesg | grep mmc1" to find info
> about the SD card slot. I don't want it to matter which one probed
> first, I don't want it to matter if I'm working on a variant of the
> hardware that has the SD card slot disabled, and I don't want to care
> what my boot device was. Worrying about what device number I got
> increases my cognitive load.
>
> 2. There are cases where it's not trivially easy during development to
> use the UUID. Specifically I work a lot with coreboot / depthcharge
> as a BIOS. When configured properly, that BIOS has a nice feature to
> allow you to fetch the kernel and kernel command line from TFTP by
> pressing Ctrl-N. In this particular case the BIOS doesn't actually
> know which disk I'd like for my root filesystem, so it's not so easy
> for it to put the right UUID into the command line. For this
> purpose, knowing that "mmcblk0" will always refer to eMMC is handy.
>
>
> Jaehoon Chung (1):
> Documentation: mmc: Document mmc aliases
>
> Stefan Agner (2):
> mmc: read mmc alias from device tree
> mmc: use SD/MMC host ID for block device name ID
We also need this feature.
Thanks so much for upstreaming the series.
Jisheng
>
> Documentation/devicetree/bindings/mmc/mmc.txt | 11 +++++++++++
> drivers/mmc/card/block.c | 3 ++-
> drivers/mmc/core/host.c | 25 ++++++++++++++++++++-----
> 3 files changed, 33 insertions(+), 6 deletions(-)
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Jisheng Zhang <jszhang@marvell.com>
To: Douglas Anderson <dianders@chromium.org>,
<ulf.hansson@linaro.org>, <jh80.chung@samsung.com>
Cc: <shawn.lin@rock-chips.com>, <adrian.hunter@intel.com>,
<stefan@agner.ch>, <linux-mmc@vger.kernel.org>,
<computersforpeace@gmail.com>, <dmitry.torokhov@gmail.com>,
<mark.rutland@arm.com>, <vbyravarasu@nvidia.com>,
<justin.wang@spreadtrum.com>, <ksumrall@android.com>,
<lars@metafoo.de>, <dtor@chromium.org>, <jonathanh@nvidia.com>,
<huangtao@rock-chips.com>, <devicetree@vger.kernel.org>,
<pawel.moll@arm.com>, <ijc+devicetree@hellion.org.uk>,
<galak@codeaurora.org>, <lporzio@micron.com>,
<robh+dt@kernel.org>, <chuanxiao.dong@intel.com>,
<chaotian.jing@mediatek.com>,
<sergei.shtylyov@cogentembedded.com>,
<linux-kernel@vger.kernel.org>, <sudeep.holla@arm.com>
Subject: Re: [PATCH 0/3] Patches to allow consistent mmc / mmcblk numbering
Date: Fri, 29 Apr 2016 10:18:36 +0800 [thread overview]
Message-ID: <20160429101836.060ad087@xhacker> (raw)
In-Reply-To: <1461884805-29466-1-git-send-email-dianders@chromium.org>
Dear Douglas,
On Thu, 28 Apr 2016 16:06:42 -0700 Douglas Anderson wrote:
> This series picks patches from various different places to produce what
> I consider the best solution to getting consistent mmc and mmcblk
> ordering.
>
> Why consistent ordering and why not just use UUIDs? IMHO consistent
> ordering solves a few different problems:
>
> 1. For poor, feeble-minded humans like me, have sane numbering for
> devices helps a lot. When grepping through dmesg it's terribly handy
> if a given SDMMC device has a consistent number. I know that I can
> do "dmesg | grep mmc0" or "dmesg | grep mmcblk0" to find info about
> the eMMC. I know that I can do "dmesg | grep mmc1" to find info
> about the SD card slot. I don't want it to matter which one probed
> first, I don't want it to matter if I'm working on a variant of the
> hardware that has the SD card slot disabled, and I don't want to care
> what my boot device was. Worrying about what device number I got
> increases my cognitive load.
>
> 2. There are cases where it's not trivially easy during development to
> use the UUID. Specifically I work a lot with coreboot / depthcharge
> as a BIOS. When configured properly, that BIOS has a nice feature to
> allow you to fetch the kernel and kernel command line from TFTP by
> pressing Ctrl-N. In this particular case the BIOS doesn't actually
> know which disk I'd like for my root filesystem, so it's not so easy
> for it to put the right UUID into the command line. For this
> purpose, knowing that "mmcblk0" will always refer to eMMC is handy.
>
>
> Jaehoon Chung (1):
> Documentation: mmc: Document mmc aliases
>
> Stefan Agner (2):
> mmc: read mmc alias from device tree
> mmc: use SD/MMC host ID for block device name ID
We also need this feature.
Thanks so much for upstreaming the series.
Jisheng
>
> Documentation/devicetree/bindings/mmc/mmc.txt | 11 +++++++++++
> drivers/mmc/card/block.c | 3 ++-
> drivers/mmc/core/host.c | 25 ++++++++++++++++++++-----
> 3 files changed, 33 insertions(+), 6 deletions(-)
>
next prev parent reply other threads:[~2016-04-29 2:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-28 23:06 [PATCH 0/3] Patches to allow consistent mmc / mmcblk numbering Douglas Anderson
2016-04-28 23:06 ` [PATCH 1/3] Documentation: mmc: Document mmc aliases Douglas Anderson
2016-04-28 23:06 ` [PATCH 2/3] mmc: read mmc alias from device tree Douglas Anderson
2016-04-28 23:06 ` [PATCH 3/3] mmc: use SD/MMC host ID for block device name ID Douglas Anderson
[not found] ` <1461884805-29466-1-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2016-04-29 2:18 ` Jisheng Zhang [this message]
2016-04-29 2:18 ` [PATCH 0/3] Patches to allow consistent mmc / mmcblk numbering Jisheng Zhang
2016-04-29 7:21 ` Ulf Hansson
2016-04-29 7:21 ` Ulf Hansson
2016-04-29 17:32 ` Doug Anderson
2016-04-29 17:32 ` Doug Anderson
2016-04-29 17:39 ` Arnd Bergmann
2016-05-10 11:09 ` Ulf Hansson
2016-05-10 11:09 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160429101836.060ad087@xhacker \
--to=jszhang-eyqppykdwxrbdgjk7y7tuq@public.gmane.org \
--cc=adrian.hunter-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=chaotian.jing-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=chuanxiao.dong-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=dtor-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=huangtao-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=jh80.chung-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=justin.wang-lxIno14LUO0EEoCn2XhGlw@public.gmane.org \
--cc=ksumrall-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org \
--cc=lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lporzio-AL4WhLSQfzjQT0dZR+AlfA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org \
--cc=shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
--cc=stefan-XLVq0VzYD2Y@public.gmane.org \
--cc=sudeep.holla-5wv7dgnIgG8@public.gmane.org \
--cc=ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=vbyravarasu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.