Re: [PATCH] Add LED driven by multiple gpio.

[Pavel Machek <pavel@ucw.cz>]

Hi!

> >I'm hoping that if the RGB LED framework comes to fruition, that there
> >will be some way to combine arbitrary single-color LED devices into a
> >logical RGB LED.
> 
> It turns out that rgb-pattern trigger, we were discussing some time ago,
> would be useful also for LEDs of arbitrary colors. It should be given
> more generic name then, e.g. three-led-composite or so. The "color"
> sysfs attribute exposed by the trigger could be replaced with
> "subled_id", that would accept values 0, 1 or 2.
> 
> Brightness of such a compound LED could be set with:
> 
> led_trigger_3led_event(sturct led_trigger *trig,
>                        enum led_brightness led1,
>                        enum led_brightness led2,
>                        enum led_brightness led3)
> 
> Maybe we should think about making this scalable using
> C ellipsis feature:
> 
> led_trigger_3led_event(sturct led_trigger *trig,
>                        enum led_brightness led1,
>                        ...)

You don't need (and should not need) elipsis.

led_trigger_many_leds_event(sturct led_trigger *trig,
			      int num_leds,
                              enum led_brightness *brightness)

...should be fine.
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html