All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jacek Anaszewski <j.anaszewski@samsung.com>
To: Dmitry Bondar <bond@simicon.com>
Cc: linux-leds@vger.kernel.org, Richard Purdie <rpurdie@rpsys.net>
Subject: Re: [PATCH] Add LED driven by multiple gpio.
Date: Wed, 27 Apr 2016 08:56:36 +0200	[thread overview]
Message-ID: <572062A4.6020601@samsung.com> (raw)
In-Reply-To: <571DE205.1000407@samsung.com>

On 04/25/2016 11:23 AM, Jacek Anaszewski wrote:
> Hi Dmitry,
>
> First of all, please don't send patches as attachments but use
> git send-email on each of them.
>
> Regarding the driver - if the LEDs are not driven by some LED controller
> device, then this patch fits better for GPIO subsystem IMO.

Of course the driver should register LED class device anyway, but
the main question is how the GPIO logic is implemented. Is it some
publicly available chip or a circuit composed of discrete elements?

> On 04/25/2016 10:14 AM, Dmitry Bondar wrote:
>> Hello, on our board we have one LED with 2 gpio connected to it:
>>   - when gpio0 is on and gpio1 on - LED is orange.
>>   - when gpio0 is on and gpio1 off - LED is green.
>>   - when gpio0 is off and gpio1 on - LED is red.
>>   - when gpio0 is off and gpio1 off - LED is off.
>> We want use led_trigger (nand-disk) on this LED.
>> Below patch which we use for get one LED on 2 gpios.
>> Can be this in mainline, or may be exist other - better way?
>>
>
>


-- 
Best regards,
Jacek Anaszewski

  reply	other threads:[~2016-04-27  6:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-25  8:14 [PATCH] Add LED driven by multiple gpio Dmitry Bondar
2016-04-25  9:23 ` Jacek Anaszewski
2016-04-27  6:56   ` Jacek Anaszewski [this message]
2016-04-26 20:26 ` David Rivshin (Allworx)
2016-04-29 12:42   ` Jacek Anaszewski
2016-04-29 12:58     ` Pavel Machek
2016-04-29 13:07       ` Jacek Anaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=572062A4.6020601@samsung.com \
    --to=j.anaszewski@samsung.com \
    --cc=bond@simicon.com \
    --cc=linux-leds@vger.kernel.org \
    --cc=rpurdie@rpsys.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.