From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 6/8] pci: provide sensible irq vector alloc/free routines
Date: Mon, 2 May 2016 16:42:03 +0200 [thread overview]
Message-ID: <20160502144203.GA32221@lst.de> (raw)
In-Reply-To: <20160502131124.GA18527@localhost>
On Mon, May 02, 2016@08:11:24AM -0500, Bjorn Helgaas wrote:
> On Sun, May 01, 2016@08:01:49PM +0200, Christoph Hellwig wrote:
> > FYI, I spent some time trying to convert more drivers to this, and
> > I think we'll need an additional flag to skip MSI or MSI-X as there
> > is plenty of hardware claiming support in the capabilities flag,
> > but not actually supporting one of them.
>
> Or maybe add a "pdev->msix_broken" bit and quirks to set it? Or if
> pci_fixup_final quirks merely cleared pdev->msix_cap, I think the PCI
> core would never try to enable MSI-X.
Can't say I'm excited about quirks - now we'd have to patch core
code for something that previously was entirely in the driver.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
tglx@linutronix.de, linux-block@vger.kernel.org,
linux-pci@vger.kernel.org, linux-nvme@lists.infradead.org,
linux-kernel@vger.kernel.org,
Alexander Gordeev <agordeev@redhat.com>
Subject: Re: [PATCH 6/8] pci: provide sensible irq vector alloc/free routines
Date: Mon, 2 May 2016 16:42:03 +0200 [thread overview]
Message-ID: <20160502144203.GA32221@lst.de> (raw)
In-Reply-To: <20160502131124.GA18527@localhost>
On Mon, May 02, 2016 at 08:11:24AM -0500, Bjorn Helgaas wrote:
> On Sun, May 01, 2016 at 08:01:49PM +0200, Christoph Hellwig wrote:
> > FYI, I spent some time trying to convert more drivers to this, and
> > I think we'll need an additional flag to skip MSI or MSI-X as there
> > is plenty of hardware claiming support in the capabilities flag,
> > but not actually supporting one of them.
>
> Or maybe add a "pdev->msix_broken" bit and quirks to set it? Or if
> pci_fixup_final quirks merely cleared pdev->msix_cap, I think the PCI
> core would never try to enable MSI-X.
Can't say I'm excited about quirks - now we'd have to patch core
code for something that previously was entirely in the driver.
next prev parent reply other threads:[~2016-05-02 14:42 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-16 1:35 RFC: automatic interrupt affinity for MSI/MSI-X capable devices Christoph Hellwig
2016-04-16 1:35 ` Christoph Hellwig
2016-04-16 1:35 ` [PATCH 1/8] device: Add irq affinity hint cpumask pointer Christoph Hellwig
2016-04-16 1:35 ` Christoph Hellwig
2016-04-16 1:35 ` [PATCH 2/8] genirq: Make use of dev->irq_affinity Christoph Hellwig
2016-04-16 1:35 ` Christoph Hellwig
2016-04-16 1:35 ` [PATCH 3/8] genirq: add a helper spread an affinity mask for MSI/MSI-X vectors Christoph Hellwig
2016-04-16 1:35 ` Christoph Hellwig
2016-04-16 1:35 ` [PATCH 4/8] genirq: add a helper to program the pre-set affinity mask into the controller Christoph Hellwig
2016-04-16 1:35 ` Christoph Hellwig
2016-04-16 1:35 ` [PATCH 5/8] blk-mq: allow the driver to pass in an affinity mask Christoph Hellwig
2016-04-16 1:35 ` Christoph Hellwig
2016-04-16 1:35 ` [PATCH 6/8] pci: provide sensible irq vector alloc/free routines Christoph Hellwig
2016-04-16 1:35 ` Christoph Hellwig
2016-04-29 21:16 ` Bjorn Helgaas
2016-04-29 21:16 ` Bjorn Helgaas
2016-05-01 18:01 ` Christoph Hellwig
2016-05-01 18:01 ` Christoph Hellwig
2016-05-02 13:11 ` Bjorn Helgaas
2016-05-02 13:11 ` Bjorn Helgaas
2016-05-02 14:42 ` Christoph Hellwig [this message]
2016-05-02 14:42 ` Christoph Hellwig
2016-05-02 15:29 ` Bjorn Helgaas
2016-05-02 15:29 ` Bjorn Helgaas
2016-05-03 21:19 ` Christoph Hellwig
2016-05-03 21:19 ` Christoph Hellwig
2016-05-03 21:37 ` Bjorn Helgaas
2016-05-03 21:37 ` Bjorn Helgaas
2016-04-16 1:35 ` [PATCH 7/8] pci: spread interrupt vectors in pci_alloc_irq_vectors Christoph Hellwig
2016-04-16 1:35 ` Christoph Hellwig
2016-04-18 8:30 ` Thomas Gleixner
2016-04-18 8:30 ` Thomas Gleixner
2016-04-16 1:35 ` [PATCH 8/8] nvme: switch to use pci_alloc_irq_vectors Christoph Hellwig
2016-04-16 1:35 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160502144203.GA32221@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.