From: hch@lst.de (Christoph Hellwig)
To: linux-arm-kernel@lists.infradead.org
Subject: [question] pread2, pwrite2 unistd symbols for compat
Date: Mon, 2 May 2016 17:22:48 +0200 [thread overview]
Message-ID: <20160502152248.GA716@lst.de> (raw)
In-Reply-To: <9552994.HgmuyIW9Ty@wuerfel>
On Mon, May 02, 2016 at 05:20:22PM +0200, Arnd Bergmann wrote:
> After I got the original patch from Andre and the same one from Christoph,
> I did not consider the possibility that they were both wrong and so I
> applied Andre's version.
It's because adding syscalls is simple a giant pain, full of pitfalls
that are completely non-obvious. When asked to add syscalls for
architectures I can't personally test I'll have to rely on the test
bot giving me some feedback - and it seems the wrong thing here will
just silently pass without any notice.
The change looks fine to me, but then again I just demonstrated a complete
lack of clue on asm-generic syscalls..
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
Christoph Hellwig <hch@lst.de>,
Yury Norov <ynorov@caviumnetworks.com>,
Andre Przywara <andre.przywara@arm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [question] pread2, pwrite2 unistd symbols for compat
Date: Mon, 2 May 2016 17:22:48 +0200 [thread overview]
Message-ID: <20160502152248.GA716@lst.de> (raw)
In-Reply-To: <9552994.HgmuyIW9Ty@wuerfel>
On Mon, May 02, 2016 at 05:20:22PM +0200, Arnd Bergmann wrote:
> After I got the original patch from Andre and the same one from Christoph,
> I did not consider the possibility that they were both wrong and so I
> applied Andre's version.
It's because adding syscalls is simple a giant pain, full of pitfalls
that are completely non-obvious. When asked to add syscalls for
architectures I can't personally test I'll have to rely on the test
bot giving me some feedback - and it seems the wrong thing here will
just silently pass without any notice.
The change looks fine to me, but then again I just demonstrated a complete
lack of clue on asm-generic syscalls..
next prev parent reply other threads:[~2016-05-02 15:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-02 13:47 [question] pread2, pwrite2 unistd symbols for compat Yury Norov
2016-05-02 13:47 ` Yury Norov
2016-05-02 15:20 ` Arnd Bergmann
2016-05-02 15:20 ` Arnd Bergmann
2016-05-02 15:22 ` Christoph Hellwig [this message]
2016-05-02 15:22 ` Christoph Hellwig
2016-05-02 15:40 ` Arnd Bergmann
2016-05-02 15:40 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160502152248.GA716@lst.de \
--to=hch@lst.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.