All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Jianfeng Tan <jianfeng.tan@intel.com>
Cc: dev@dpdk.org, huawei.xie@intel.com, david.marchand@6wind.com
Subject: Re: [PATCH v2] virtio: fix modify drv_flags for specific device
Date: Mon, 2 May 2016 10:55:30 -0700	[thread overview]
Message-ID: <20160502175530.GO5641@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <1461866939-38689-1-git-send-email-jianfeng.tan@intel.com>

On Thu, Apr 28, 2016 at 06:08:59PM +0000, Jianfeng Tan wrote:
> Issue: virtio's drv_flags are decided by devices types (modern vs legacy),
> and which kernel driver is used, and the negotiated features (especially
> VIRTIO_NET_STATUS) with backend, which makes it possible to multiple
> virtio devices have different versions of drv_flags, but this variable
> is currently shared by each virtio device.
> 
> How to fix: dev_flags is a device-specific variable to store this info.
> 
> Fixes: da978dfdc43 ("virtio: use port IO to get PCI resource")
> 
> Reported-by: David Marchand <david.marchand@6wind.com>
> Suggested-by: David Marchand <david.marchand@6wind.com>

Hi David,

May I ask your review on this and give ACK when no issue to you?

Thanks.

	--yliu

  reply	other threads:[~2016-05-02 17:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-26  2:24 [PATCH] virtio: fix modify drv_flags for specific device Jianfeng Tan
2016-04-26 11:53 ` David Marchand
2016-04-27  5:10   ` Tan, Jianfeng
2016-04-27  5:20     ` David Marchand
2016-04-28 18:08 ` [PATCH v2] " Jianfeng Tan
2016-05-02 17:55   ` Yuanhan Liu [this message]
2016-05-03  8:05   ` David Marchand
2016-05-04 23:18     ` Yuanhan Liu
2016-05-09  9:14       ` Tan, Jianfeng
2016-05-09 18:01         ` Yuanhan Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160502175530.GO5641@yliu-dev.sh.intel.com \
    --to=yuanhan.liu@linux.intel.com \
    --cc=david.marchand@6wind.com \
    --cc=dev@dpdk.org \
    --cc=huawei.xie@intel.com \
    --cc=jianfeng.tan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.