From: Johan Hedberg <johan.hedberg@gmail.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Marcel Holtmann <marcel@holtmann.org>,
kernel-janitors@vger.kernel.org,
Gustavo Padovan <gustavo@padovan.org>,
"David S. Miller" <davem@davemloft.net>,
linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: Use hci_conn_hash_lookup_le
Date: Mon, 02 May 2016 18:02:56 +0000 [thread overview]
Message-ID: <20160502180256.GA22757@t440s> (raw)
In-Reply-To: <1461957760-753-1-git-send-email-Julia.Lawall@lip6.fr>
Hi,
On Fri, Apr 29, 2016, Julia Lawall wrote:
> --- a/net/bluetooth/mgmt.c
> +++ b/net/bluetooth/mgmt.c
> @@ -4773,7 +4773,8 @@ static int get_conn_info(struct sock *sk, struct hci_dev *hdev, void *data,
> conn = hci_conn_hash_lookup_ba(hdev, ACL_LINK,
> &cp->addr.bdaddr);
> else
> - conn = hci_conn_hash_lookup_ba(hdev, LE_LINK, &cp->addr.bdaddr);
> + conn = hci_conn_hash_lookup_le(hdev, &cp->addr.bdaddr,
> + cp->addr.type);
I don't think is is correct. There are two possible domains for address
types: the user space-facing interface that has three values: BR/EDR, LE
public & LE random, and the internal one which maps to HCI that has two
values: random or public. You'd need to convert from the former to the
latter when making the lookup call, i.e:
conn = hci_conn_hash_lookup_le(hdev, &cp->addr.bdaddr,
le_addr_type(cp->addr.type));
Johan
WARNING: multiple messages have this Message-ID (diff)
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Marcel Holtmann <marcel@holtmann.org>,
kernel-janitors@vger.kernel.org,
Gustavo Padovan <gustavo@padovan.org>,
"David S. Miller" <davem@davemloft.net>,
linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: Use hci_conn_hash_lookup_le
Date: Mon, 2 May 2016 21:02:56 +0300 [thread overview]
Message-ID: <20160502180256.GA22757@t440s> (raw)
In-Reply-To: <1461957760-753-1-git-send-email-Julia.Lawall@lip6.fr>
Hi,
On Fri, Apr 29, 2016, Julia Lawall wrote:
> --- a/net/bluetooth/mgmt.c
> +++ b/net/bluetooth/mgmt.c
> @@ -4773,7 +4773,8 @@ static int get_conn_info(struct sock *sk, struct hci_dev *hdev, void *data,
> conn = hci_conn_hash_lookup_ba(hdev, ACL_LINK,
> &cp->addr.bdaddr);
> else
> - conn = hci_conn_hash_lookup_ba(hdev, LE_LINK, &cp->addr.bdaddr);
> + conn = hci_conn_hash_lookup_le(hdev, &cp->addr.bdaddr,
> + cp->addr.type);
I don't think is is correct. There are two possible domains for address
types: the user space-facing interface that has three values: BR/EDR, LE
public & LE random, and the internal one which maps to HCI that has two
values: random or public. You'd need to convert from the former to the
latter when making the lookup call, i.e:
conn = hci_conn_hash_lookup_le(hdev, &cp->addr.bdaddr,
le_addr_type(cp->addr.type));
Johan
next prev parent reply other threads:[~2016-05-02 18:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 19:22 [PATCH] Bluetooth: Use hci_conn_hash_lookup_le Julia Lawall
2016-04-29 19:22 ` Julia Lawall
2016-05-02 18:02 ` Johan Hedberg [this message]
2016-05-02 18:02 ` Johan Hedberg
2016-05-02 19:33 ` Julia Lawall
2016-05-02 19:33 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160502180256.GA22757@t440s \
--to=johan.hedberg@gmail.com \
--cc=Julia.Lawall@lip6.fr \
--cc=davem@davemloft.net \
--cc=gustavo@padovan.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.