All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, vyasevich@gmail.com,
	nhorman@tuxdriver.com, linux-sctp@vger.kernel.org,
	David.Laight@ACULAB.COM, alexander.duyck@gmail.com
Subject: Re: [PATCH 0/2] sctp: Add GSO support
Date: Tue, 03 May 2016 16:47:45 +0000	[thread overview]
Message-ID: <20160503164745.GE5676@localhost.localdomain> (raw)
In-Reply-To: <20160503.120915.2184693151751282220.davem@davemloft.net>

On Tue, May 03, 2016 at 12:09:15PM -0400, David Miller wrote:
> From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
> Date: Tue, 3 May 2016 08:49:18 -0300
> 
> > So this is just for pure tx path, no forwarding involved.
> 
> And if that GSO segment is looped back into the stack via the
> loopback interface, the packet classifier mirror action, or
> netfilter?
> 
> You cannot just GSO things and then not handle such packets
> properly on receive.

Good point. It will fail if one uses AUTH due to the reason I mentioned
for GRO. I have to split the GSO packet upon rx too and that should do
it. Will post a v2 when I have it.

Thanks,
Marcelo

WARNING: multiple messages have this Message-ID (diff)
From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, vyasevich@gmail.com,
	nhorman@tuxdriver.com, linux-sctp@vger.kernel.org,
	David.Laight@ACULAB.COM, alexander.duyck@gmail.com
Subject: Re: [PATCH 0/2] sctp: Add GSO support
Date: Tue, 3 May 2016 13:47:45 -0300	[thread overview]
Message-ID: <20160503164745.GE5676@localhost.localdomain> (raw)
In-Reply-To: <20160503.120915.2184693151751282220.davem@davemloft.net>

On Tue, May 03, 2016 at 12:09:15PM -0400, David Miller wrote:
> From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
> Date: Tue, 3 May 2016 08:49:18 -0300
> 
> > So this is just for pure tx path, no forwarding involved.
> 
> And if that GSO segment is looped back into the stack via the
> loopback interface, the packet classifier mirror action, or
> netfilter?
> 
> You cannot just GSO things and then not handle such packets
> properly on receive.

Good point. It will fail if one uses AUTH due to the reason I mentioned
for GRO. I have to split the GSO packet upon rx too and that should do
it. Will post a v2 when I have it.

Thanks,
Marcelo

  reply	other threads:[~2016-05-03 16:47 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-29 21:33 [PATCH 0/2] sctp: Add GSO support Marcelo Ricardo Leitner
2016-04-29 21:33 ` Marcelo Ricardo Leitner
2016-04-29 21:33 ` [PATCH 1/2] skbuff: export skb_gro_receive Marcelo Ricardo Leitner
2016-04-29 21:33   ` Marcelo Ricardo Leitner
2016-04-29 21:33 ` [PATCH 2/2] sctp: Add GSO support Marcelo Ricardo Leitner
2016-04-29 21:33   ` Marcelo Ricardo Leitner
2016-04-29 21:38 ` [PATCH 0/2] " Marcelo Ricardo Leitner
2016-04-29 21:38   ` Marcelo Ricardo Leitner
2016-05-02 23:16 ` David Miller
2016-05-02 23:16   ` David Miller
2016-05-03 11:49   ` Marcelo Ricardo Leitner
2016-05-03 11:49     ` Marcelo Ricardo Leitner
2016-05-03 16:09     ` David Miller
2016-05-03 16:09       ` David Miller
2016-05-03 16:47       ` Marcelo Ricardo Leitner [this message]
2016-05-03 16:47         ` Marcelo Ricardo Leitner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160503164745.GE5676@localhost.localdomain \
    --to=marcelo.leitner@gmail.com \
    --cc=David.Laight@ACULAB.COM \
    --cc=alexander.duyck@gmail.com \
    --cc=davem@davemloft.net \
    --cc=linux-sctp@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=vyasevich@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.