From: Greg KH <gregkh@linuxfoundation.org>
To: Daeseok Youn <daeseok.youn@gmail.com>
Cc: lidza.louina@gmail.com, markh@compro.net,
driverdev-devel@linuxdriverproject.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, dan.carpenter@oracle.com
Subject: Re: [PATCH] staging: dgnc: Fix a NULL pointer dereference
Date: Wed, 04 May 2016 05:57:10 +0000 [thread overview]
Message-ID: <20160504055710.GA3214@kroah.com> (raw)
In-Reply-To: <20160504055609.GA30446@kroah.com>
On Tue, May 03, 2016 at 10:56:09PM -0700, Greg KH wrote:
> On Wed, May 04, 2016 at 02:41:22PM +0900, Daeseok Youn wrote:
> > The error handling for print_drive after calling tty_alloc_driver()
> > was needed. But there was error handling but too late for this.
> > Error handling code moved after tty_alloc_driver() call.
> >
> > Fixes: 60b3109e5e2d ("staging: dgnc: use tty_alloc_driver instead of kcalloc")
> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> > Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
> > ---
> > drivers/staging/dgnc/dgnc_tty.c | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
>
> Patch doesn't apply at all, does it need something else to be merged
> first?
Oh nevermind, I tried applying it to the wrong git tree, my fault...
I need some sleep...
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Daeseok Youn <daeseok.youn@gmail.com>
Cc: lidza.louina@gmail.com, markh@compro.net,
driverdev-devel@linuxdriverproject.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, dan.carpenter@oracle.com
Subject: Re: [PATCH] staging: dgnc: Fix a NULL pointer dereference
Date: Tue, 3 May 2016 22:57:10 -0700 [thread overview]
Message-ID: <20160504055710.GA3214@kroah.com> (raw)
In-Reply-To: <20160504055609.GA30446@kroah.com>
On Tue, May 03, 2016 at 10:56:09PM -0700, Greg KH wrote:
> On Wed, May 04, 2016 at 02:41:22PM +0900, Daeseok Youn wrote:
> > The error handling for print_drive after calling tty_alloc_driver()
> > was needed. But there was error handling but too late for this.
> > Error handling code moved after tty_alloc_driver() call.
> >
> > Fixes: 60b3109e5e2d ("staging: dgnc: use tty_alloc_driver instead of kcalloc")
> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> > Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
> > ---
> > drivers/staging/dgnc/dgnc_tty.c | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
>
> Patch doesn't apply at all, does it need something else to be merged
> first?
Oh nevermind, I tried applying it to the wrong git tree, my fault...
I need some sleep...
greg k-h
next prev parent reply other threads:[~2016-05-04 5:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-04 5:41 [PATCH] staging: dgnc: Fix a NULL pointer dereference Daeseok Youn
2016-05-04 5:41 ` Daeseok Youn
2016-05-04 5:56 ` Greg KH
2016-05-04 5:56 ` Greg KH
2016-05-04 5:57 ` Greg KH [this message]
2016-05-04 5:57 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160504055710.GA3214@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=daeseok.youn@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markh@compro.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.