From: Brian Norris <briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
To: "Heiko Stübner" <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] ARM: dts: rockchip: move rk3288 edp phy under the GRF
Date: Wed, 4 May 2016 18:16:21 -0700 [thread overview]
Message-ID: <20160505011621.GA44327@google.com> (raw)
In-Reply-To: <20160505011112.GA131923-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
On Wed, May 04, 2016 at 06:11:12PM -0700, Brian Norris wrote:
> On Fri, Apr 22, 2016 at 03:56:27PM +0200, Heiko Stuebner wrote:
> > Am Samstag, 16. April 2016, 02:49:14 schrieb Heiko Stübner:
> > > The edp-phy control is a part of the General Register Files and
> > > with a recent patch in 4.6 the phy driver can now also handle this
> > > correctly, so move the dts node under the GRF as well.
> > >
> > > Signed-off-by: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
> >
> > the change in the phy-driver has made it into Greg's usb tree as fix for 4.6,
> > so I've picked this patch for 4.7 now.
>
> Not sure if it's intentional, but the phy binding change (which is in
> 4.6) broke the DP support in 4.6/rk3288.dtsi, and this patch is
> necessary to bring it back. Shouldn't this DTS change have gone to 4.7
> too? Or (when convincing ourselves we're not breaking the DT ABI here),
> could we just claim that eDP wasn't supported in 4.6, and 4.7 will just
> be bug-fixing the rk3288 DTS?
Oops, my bad. The eDP PHY didn't show up at all in the v4.6/rk3288.dtsi.
So no breakage. Sorry for the false alarm.
Brian
WARNING: multiple messages have this Message-ID (diff)
From: briannorris@chromium.org (Brian Norris)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: rockchip: move rk3288 edp phy under the GRF
Date: Wed, 4 May 2016 18:16:21 -0700 [thread overview]
Message-ID: <20160505011621.GA44327@google.com> (raw)
In-Reply-To: <20160505011112.GA131923@google.com>
On Wed, May 04, 2016 at 06:11:12PM -0700, Brian Norris wrote:
> On Fri, Apr 22, 2016 at 03:56:27PM +0200, Heiko Stuebner wrote:
> > Am Samstag, 16. April 2016, 02:49:14 schrieb Heiko St?bner:
> > > The edp-phy control is a part of the General Register Files and
> > > with a recent patch in 4.6 the phy driver can now also handle this
> > > correctly, so move the dts node under the GRF as well.
> > >
> > > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> >
> > the change in the phy-driver has made it into Greg's usb tree as fix for 4.6,
> > so I've picked this patch for 4.7 now.
>
> Not sure if it's intentional, but the phy binding change (which is in
> 4.6) broke the DP support in 4.6/rk3288.dtsi, and this patch is
> necessary to bring it back. Shouldn't this DTS change have gone to 4.7
> too? Or (when convincing ourselves we're not breaking the DT ABI here),
> could we just claim that eDP wasn't supported in 4.6, and 4.7 will just
> be bug-fixing the rk3288 DTS?
Oops, my bad. The eDP PHY didn't show up at all in the v4.6/rk3288.dtsi.
So no breakage. Sorry for the false alarm.
Brian
next prev parent reply other threads:[~2016-05-05 1:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-16 0:49 [PATCH] ARM: dts: rockchip: move rk3288 edp phy under the GRF Heiko Stübner
2016-04-16 0:49 ` Heiko Stübner
2016-04-22 13:56 ` Heiko Stübner
2016-04-22 13:56 ` Heiko Stübner
2016-05-05 1:11 ` Brian Norris
2016-05-05 1:11 ` Brian Norris
[not found] ` <20160505011112.GA131923-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2016-05-05 1:16 ` Brian Norris [this message]
2016-05-05 1:16 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160505011621.GA44327@google.com \
--to=briannorris-f7+t8e8rja9g9huczpvpmw@public.gmane.org \
--cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.