From: Baoquan He <bhe@redhat.com>
To: Corey Minyard <minyard@acm.org>
Cc: Corey Minyard <cminyard@mvista.com>,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
Haren Myneni <hbabu@us.ibm.com>,
dyoung@redhat.com, Vivek Goyal <vgoyal@redhat.com>
Subject: Re: [PATCH] kdump: Fix gdb macros work work with newer and 64-bit kernels
Date: Thu, 5 May 2016 10:37:58 +0800 [thread overview]
Message-ID: <20160505023758.GA2558@x1.redhat.com> (raw)
In-Reply-To: <5720AEDC.3080409@acm.org>
On 04/27/16 at 07:21am, Corey Minyard wrote:
> Any comments on this? If no one else cares I'd be willing to take over
> maintenance of this.
Vivek is busy with some other issues. He asked Dave and me to test and
review this patch. Will check this recently.
Thanks
Baoquan
>
> -corey
>
> On 02/25/2016 07:51 AM, minyard@acm.org wrote:
> >From: Corey Minyard <cminyard@mvista.com>
> >
> >Lots of little changes needed to be made to clean these up, remove the
> >four byte pointer assumption and traverse the pid queue properly.
> >Also consolidate the traceback code into a single function instead
> >of having three copies of it.
> >
> >Signed-off-by: Corey Minyard <cminyard@mvista.com>
> >---
> > Documentation/kdump/gdbmacros.txt | 90 +++++++++++++++++----------------------
> > 1 file changed, 40 insertions(+), 50 deletions(-)
> >
> >I sent this earlier, but I didn't get a response. These are clearly
> >wrong. I'd be happy to take over maintenance of these macros. It
> >might be better to move them someplace else, too, since they are also
> >useful for kgdb.
> >
> >diff --git a/Documentation/kdump/gdbmacros.txt b/Documentation/kdump/gdbmacros.txt
> >index 9b9b454..e5bbd8d 100644
> >--- a/Documentation/kdump/gdbmacros.txt
> >+++ b/Documentation/kdump/gdbmacros.txt
> >@@ -15,14 +15,14 @@
> > define bttnobp
> > set $tasks_off=((size_t)&((struct task_struct *)0)->tasks)
> >- set $pid_off=((size_t)&((struct task_struct *)0)->pids[1].pid_list.next)
> >+ set $pid_off=((size_t)&((struct task_struct *)0)->thread_group.next)
> > set $init_t=&init_task
> > set $next_t=(((char *)($init_t->tasks).next) - $tasks_off)
> > while ($next_t != $init_t)
> > set $next_t=(struct task_struct *)$next_t
> > printf "\npid %d; comm %s:\n", $next_t.pid, $next_t.comm
> > printf "===================\n"
> >- set var $stackp = $next_t.thread.esp
> >+ set var $stackp = $next_t.thread.sp
> > set var $stack_top = ($stackp & ~4095) + 4096
> > while ($stackp < $stack_top)
> >@@ -31,12 +31,12 @@ define bttnobp
> > end
> > set $stackp += 4
> > end
> >- set $next_th=(((char *)$next_t->pids[1].pid_list.next) - $pid_off)
> >+ set $next_th=(((char *)$next_t->thread_group.next) - $pid_off)
> > while ($next_th != $next_t)
> > set $next_th=(struct task_struct *)$next_th
> > printf "\npid %d; comm %s:\n", $next_t.pid, $next_t.comm
> > printf "===================\n"
> >- set var $stackp = $next_t.thread.esp
> >+ set var $stackp = $next_t.thread.sp
> > set var $stack_top = ($stackp & ~4095) + 4096
> > while ($stackp < $stack_top)
> >@@ -45,7 +45,7 @@ define bttnobp
> > end
> > set $stackp += 4
> > end
> >- set $next_th=(((char *)$next_th->pids[1].pid_list.next) - $pid_off)
> >+ set $next_th=(((char *)$next_th->thread_group.next) - $pid_off)
> > end
> > set $next_t=(char *)($next_t->tasks.next) - $tasks_off
> > end
> >@@ -54,42 +54,43 @@ document bttnobp
> > dump all thread stack traces on a kernel compiled with !CONFIG_FRAME_POINTER
> > end
> >+define btthreadstruct
> >+ set var $pid_task = $arg0
> >+
> >+ printf "\npid %d; comm %s:\n", $pid_task.pid, $pid_task.comm
> >+ printf "task struct: "
> >+ print $pid_task
> >+ printf "===================\n"
> >+ set var $stackp = $pid_task.thread.sp
> >+ set var $stack_top = ($stackp & ~4095) + 4096
> >+ set var $stack_bot = ($stackp & ~4095)
> >+
> >+ set $stackp = *((unsigned long *) $stackp)
> >+ while (($stackp < $stack_top) && ($stackp > $stack_bot))
> >+ set var $addr = *(((unsigned long *) $stackp) + 1)
> >+ info symbol $addr
> >+ set $stackp = *((unsigned long *) $stackp)
> >+ end
> >+end
> >+document btthreadstruct
> >+ dump a thread stack using the given task structure pointer
> >+end
> >+
> >+
> > define btt
> > set $tasks_off=((size_t)&((struct task_struct *)0)->tasks)
> >- set $pid_off=((size_t)&((struct task_struct *)0)->pids[1].pid_list.next)
> >+ set $pid_off=((size_t)&((struct task_struct *)0)->thread_group.next)
> > set $init_t=&init_task
> > set $next_t=(((char *)($init_t->tasks).next) - $tasks_off)
> > while ($next_t != $init_t)
> > set $next_t=(struct task_struct *)$next_t
> >- printf "\npid %d; comm %s:\n", $next_t.pid, $next_t.comm
> >- printf "===================\n"
> >- set var $stackp = $next_t.thread.esp
> >- set var $stack_top = ($stackp & ~4095) + 4096
> >- set var $stack_bot = ($stackp & ~4095)
> >+ btthreadstruct $next_t
> >- set $stackp = *($stackp)
> >- while (($stackp < $stack_top) && ($stackp > $stack_bot))
> >- set var $addr = *($stackp + 4)
> >- info symbol $addr
> >- set $stackp = *($stackp)
> >- end
> >-
> >- set $next_th=(((char *)$next_t->pids[1].pid_list.next) - $pid_off)
> >+ set $next_th=(((char *)$next_t->thread_group.next) - $pid_off)
> > while ($next_th != $next_t)
> > set $next_th=(struct task_struct *)$next_th
> >- printf "\npid %d; comm %s:\n", $next_t.pid, $next_t.comm
> >- printf "===================\n"
> >- set var $stackp = $next_t.thread.esp
> >- set var $stack_top = ($stackp & ~4095) + 4096
> >- set var $stack_bot = ($stackp & ~4095)
> >-
> >- set $stackp = *($stackp)
> >- while (($stackp < $stack_top) && ($stackp > $stack_bot))
> >- set var $addr = *($stackp + 4)
> >- info symbol $addr
> >- set $stackp = *($stackp)
> >- end
> >- set $next_th=(((char *)$next_th->pids[1].pid_list.next) - $pid_off)
> >+ btthreadstruct $next_th
> >+ set $next_th=(((char *)$next_th->thread_group.next) - $pid_off)
> > end
> > set $next_t=(char *)($next_t->tasks.next) - $tasks_off
> > end
> >@@ -101,7 +102,7 @@ end
> > define btpid
> > set var $pid = $arg0
> > set $tasks_off=((size_t)&((struct task_struct *)0)->tasks)
> >- set $pid_off=((size_t)&((struct task_struct *)0)->pids[1].pid_list.next)
> >+ set $pid_off=((size_t)&((struct task_struct *)0)->thread_group.next)
> > set $init_t=&init_task
> > set $next_t=(((char *)($init_t->tasks).next) - $tasks_off)
> > set var $pid_task = 0
> >@@ -113,29 +114,18 @@ define btpid
> > set $pid_task = $next_t
> > end
> >- set $next_th=(((char *)$next_t->pids[1].pid_list.next) - $pid_off)
> >+ set $next_th=(((char *)$next_t->thread_group.next) - $pid_off)
> > while ($next_th != $next_t)
> > set $next_th=(struct task_struct *)$next_th
> > if ($next_th.pid == $pid)
> > set $pid_task = $next_th
> > end
> >- set $next_th=(((char *)$next_th->pids[1].pid_list.next) - $pid_off)
> >+ set $next_th=(((char *)$next_th->thread_group.next) - $pid_off)
> > end
> > set $next_t=(char *)($next_t->tasks.next) - $tasks_off
> > end
> >- printf "\npid %d; comm %s:\n", $pid_task.pid, $pid_task.comm
> >- printf "===================\n"
> >- set var $stackp = $pid_task.thread.esp
> >- set var $stack_top = ($stackp & ~4095) + 4096
> >- set var $stack_bot = ($stackp & ~4095)
> >-
> >- set $stackp = *($stackp)
> >- while (($stackp < $stack_top) && ($stackp > $stack_bot))
> >- set var $addr = *($stackp + 4)
> >- info symbol $addr
> >- set $stackp = *($stackp)
> >- end
> >+ btthreadstruct $pid_task
> > end
> > document btpid
> > backtrace of pid
> >@@ -145,7 +135,7 @@ end
> > define trapinfo
> > set var $pid = $arg0
> > set $tasks_off=((size_t)&((struct task_struct *)0)->tasks)
> >- set $pid_off=((size_t)&((struct task_struct *)0)->pids[1].pid_list.next)
> >+ set $pid_off=((size_t)&((struct task_struct *)0)->thread_group.next)
> > set $init_t=&init_task
> > set $next_t=(((char *)($init_t->tasks).next) - $tasks_off)
> > set var $pid_task = 0
> >@@ -157,13 +147,13 @@ define trapinfo
> > set $pid_task = $next_t
> > end
> >- set $next_th=(((char *)$next_t->pids[1].pid_list.next) - $pid_off)
> >+ set $next_th=(((char *)$next_t->thread_group.next) - $pid_off)
> > while ($next_th != $next_t)
> > set $next_th=(struct task_struct *)$next_th
> > if ($next_th.pid == $pid)
> > set $pid_task = $next_th
> > end
> >- set $next_th=(((char *)$next_th->pids[1].pid_list.next) - $pid_off)
> >+ set $next_th=(((char *)$next_th->thread_group.next) - $pid_off)
> > end
> > set $next_t=(char *)($next_t->tasks.next) - $tasks_off
> > end
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: Baoquan He <bhe@redhat.com>
To: Corey Minyard <minyard@acm.org>
Cc: kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
Vivek Goyal <vgoyal@redhat.com>, Haren Myneni <hbabu@us.ibm.com>,
Corey Minyard <cminyard@mvista.com>,
dyoung@redhat.com
Subject: Re: [PATCH] kdump: Fix gdb macros work work with newer and 64-bit kernels
Date: Thu, 5 May 2016 10:37:58 +0800 [thread overview]
Message-ID: <20160505023758.GA2558@x1.redhat.com> (raw)
In-Reply-To: <5720AEDC.3080409@acm.org>
On 04/27/16 at 07:21am, Corey Minyard wrote:
> Any comments on this? If no one else cares I'd be willing to take over
> maintenance of this.
Vivek is busy with some other issues. He asked Dave and me to test and
review this patch. Will check this recently.
Thanks
Baoquan
>
> -corey
>
> On 02/25/2016 07:51 AM, minyard@acm.org wrote:
> >From: Corey Minyard <cminyard@mvista.com>
> >
> >Lots of little changes needed to be made to clean these up, remove the
> >four byte pointer assumption and traverse the pid queue properly.
> >Also consolidate the traceback code into a single function instead
> >of having three copies of it.
> >
> >Signed-off-by: Corey Minyard <cminyard@mvista.com>
> >---
> > Documentation/kdump/gdbmacros.txt | 90 +++++++++++++++++----------------------
> > 1 file changed, 40 insertions(+), 50 deletions(-)
> >
> >I sent this earlier, but I didn't get a response. These are clearly
> >wrong. I'd be happy to take over maintenance of these macros. It
> >might be better to move them someplace else, too, since they are also
> >useful for kgdb.
> >
> >diff --git a/Documentation/kdump/gdbmacros.txt b/Documentation/kdump/gdbmacros.txt
> >index 9b9b454..e5bbd8d 100644
> >--- a/Documentation/kdump/gdbmacros.txt
> >+++ b/Documentation/kdump/gdbmacros.txt
> >@@ -15,14 +15,14 @@
> > define bttnobp
> > set $tasks_off=((size_t)&((struct task_struct *)0)->tasks)
> >- set $pid_off=((size_t)&((struct task_struct *)0)->pids[1].pid_list.next)
> >+ set $pid_off=((size_t)&((struct task_struct *)0)->thread_group.next)
> > set $init_t=&init_task
> > set $next_t=(((char *)($init_t->tasks).next) - $tasks_off)
> > while ($next_t != $init_t)
> > set $next_t=(struct task_struct *)$next_t
> > printf "\npid %d; comm %s:\n", $next_t.pid, $next_t.comm
> > printf "===================\n"
> >- set var $stackp = $next_t.thread.esp
> >+ set var $stackp = $next_t.thread.sp
> > set var $stack_top = ($stackp & ~4095) + 4096
> > while ($stackp < $stack_top)
> >@@ -31,12 +31,12 @@ define bttnobp
> > end
> > set $stackp += 4
> > end
> >- set $next_th=(((char *)$next_t->pids[1].pid_list.next) - $pid_off)
> >+ set $next_th=(((char *)$next_t->thread_group.next) - $pid_off)
> > while ($next_th != $next_t)
> > set $next_th=(struct task_struct *)$next_th
> > printf "\npid %d; comm %s:\n", $next_t.pid, $next_t.comm
> > printf "===================\n"
> >- set var $stackp = $next_t.thread.esp
> >+ set var $stackp = $next_t.thread.sp
> > set var $stack_top = ($stackp & ~4095) + 4096
> > while ($stackp < $stack_top)
> >@@ -45,7 +45,7 @@ define bttnobp
> > end
> > set $stackp += 4
> > end
> >- set $next_th=(((char *)$next_th->pids[1].pid_list.next) - $pid_off)
> >+ set $next_th=(((char *)$next_th->thread_group.next) - $pid_off)
> > end
> > set $next_t=(char *)($next_t->tasks.next) - $tasks_off
> > end
> >@@ -54,42 +54,43 @@ document bttnobp
> > dump all thread stack traces on a kernel compiled with !CONFIG_FRAME_POINTER
> > end
> >+define btthreadstruct
> >+ set var $pid_task = $arg0
> >+
> >+ printf "\npid %d; comm %s:\n", $pid_task.pid, $pid_task.comm
> >+ printf "task struct: "
> >+ print $pid_task
> >+ printf "===================\n"
> >+ set var $stackp = $pid_task.thread.sp
> >+ set var $stack_top = ($stackp & ~4095) + 4096
> >+ set var $stack_bot = ($stackp & ~4095)
> >+
> >+ set $stackp = *((unsigned long *) $stackp)
> >+ while (($stackp < $stack_top) && ($stackp > $stack_bot))
> >+ set var $addr = *(((unsigned long *) $stackp) + 1)
> >+ info symbol $addr
> >+ set $stackp = *((unsigned long *) $stackp)
> >+ end
> >+end
> >+document btthreadstruct
> >+ dump a thread stack using the given task structure pointer
> >+end
> >+
> >+
> > define btt
> > set $tasks_off=((size_t)&((struct task_struct *)0)->tasks)
> >- set $pid_off=((size_t)&((struct task_struct *)0)->pids[1].pid_list.next)
> >+ set $pid_off=((size_t)&((struct task_struct *)0)->thread_group.next)
> > set $init_t=&init_task
> > set $next_t=(((char *)($init_t->tasks).next) - $tasks_off)
> > while ($next_t != $init_t)
> > set $next_t=(struct task_struct *)$next_t
> >- printf "\npid %d; comm %s:\n", $next_t.pid, $next_t.comm
> >- printf "===================\n"
> >- set var $stackp = $next_t.thread.esp
> >- set var $stack_top = ($stackp & ~4095) + 4096
> >- set var $stack_bot = ($stackp & ~4095)
> >+ btthreadstruct $next_t
> >- set $stackp = *($stackp)
> >- while (($stackp < $stack_top) && ($stackp > $stack_bot))
> >- set var $addr = *($stackp + 4)
> >- info symbol $addr
> >- set $stackp = *($stackp)
> >- end
> >-
> >- set $next_th=(((char *)$next_t->pids[1].pid_list.next) - $pid_off)
> >+ set $next_th=(((char *)$next_t->thread_group.next) - $pid_off)
> > while ($next_th != $next_t)
> > set $next_th=(struct task_struct *)$next_th
> >- printf "\npid %d; comm %s:\n", $next_t.pid, $next_t.comm
> >- printf "===================\n"
> >- set var $stackp = $next_t.thread.esp
> >- set var $stack_top = ($stackp & ~4095) + 4096
> >- set var $stack_bot = ($stackp & ~4095)
> >-
> >- set $stackp = *($stackp)
> >- while (($stackp < $stack_top) && ($stackp > $stack_bot))
> >- set var $addr = *($stackp + 4)
> >- info symbol $addr
> >- set $stackp = *($stackp)
> >- end
> >- set $next_th=(((char *)$next_th->pids[1].pid_list.next) - $pid_off)
> >+ btthreadstruct $next_th
> >+ set $next_th=(((char *)$next_th->thread_group.next) - $pid_off)
> > end
> > set $next_t=(char *)($next_t->tasks.next) - $tasks_off
> > end
> >@@ -101,7 +102,7 @@ end
> > define btpid
> > set var $pid = $arg0
> > set $tasks_off=((size_t)&((struct task_struct *)0)->tasks)
> >- set $pid_off=((size_t)&((struct task_struct *)0)->pids[1].pid_list.next)
> >+ set $pid_off=((size_t)&((struct task_struct *)0)->thread_group.next)
> > set $init_t=&init_task
> > set $next_t=(((char *)($init_t->tasks).next) - $tasks_off)
> > set var $pid_task = 0
> >@@ -113,29 +114,18 @@ define btpid
> > set $pid_task = $next_t
> > end
> >- set $next_th=(((char *)$next_t->pids[1].pid_list.next) - $pid_off)
> >+ set $next_th=(((char *)$next_t->thread_group.next) - $pid_off)
> > while ($next_th != $next_t)
> > set $next_th=(struct task_struct *)$next_th
> > if ($next_th.pid == $pid)
> > set $pid_task = $next_th
> > end
> >- set $next_th=(((char *)$next_th->pids[1].pid_list.next) - $pid_off)
> >+ set $next_th=(((char *)$next_th->thread_group.next) - $pid_off)
> > end
> > set $next_t=(char *)($next_t->tasks.next) - $tasks_off
> > end
> >- printf "\npid %d; comm %s:\n", $pid_task.pid, $pid_task.comm
> >- printf "===================\n"
> >- set var $stackp = $pid_task.thread.esp
> >- set var $stack_top = ($stackp & ~4095) + 4096
> >- set var $stack_bot = ($stackp & ~4095)
> >-
> >- set $stackp = *($stackp)
> >- while (($stackp < $stack_top) && ($stackp > $stack_bot))
> >- set var $addr = *($stackp + 4)
> >- info symbol $addr
> >- set $stackp = *($stackp)
> >- end
> >+ btthreadstruct $pid_task
> > end
> > document btpid
> > backtrace of pid
> >@@ -145,7 +135,7 @@ end
> > define trapinfo
> > set var $pid = $arg0
> > set $tasks_off=((size_t)&((struct task_struct *)0)->tasks)
> >- set $pid_off=((size_t)&((struct task_struct *)0)->pids[1].pid_list.next)
> >+ set $pid_off=((size_t)&((struct task_struct *)0)->thread_group.next)
> > set $init_t=&init_task
> > set $next_t=(((char *)($init_t->tasks).next) - $tasks_off)
> > set var $pid_task = 0
> >@@ -157,13 +147,13 @@ define trapinfo
> > set $pid_task = $next_t
> > end
> >- set $next_th=(((char *)$next_t->pids[1].pid_list.next) - $pid_off)
> >+ set $next_th=(((char *)$next_t->thread_group.next) - $pid_off)
> > while ($next_th != $next_t)
> > set $next_th=(struct task_struct *)$next_th
> > if ($next_th.pid == $pid)
> > set $pid_task = $next_th
> > end
> >- set $next_th=(((char *)$next_th->pids[1].pid_list.next) - $pid_off)
> >+ set $next_th=(((char *)$next_th->thread_group.next) - $pid_off)
> > end
> > set $next_t=(char *)($next_t->tasks.next) - $tasks_off
> > end
next prev parent reply other threads:[~2016-05-05 2:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 13:51 [PATCH] kdump: Fix gdb macros work work with newer and 64-bit kernels minyard
2016-02-25 13:51 ` minyard
2016-04-27 12:21 ` Corey Minyard
2016-04-27 12:21 ` Corey Minyard
2016-05-05 2:37 ` Baoquan He [this message]
2016-05-05 2:37 ` Baoquan He
2016-05-09 5:18 ` Baoquan He
2016-05-09 5:18 ` Baoquan He
2016-05-09 12:10 ` Corey Minyard
2016-05-09 12:10 ` Corey Minyard
2016-05-09 14:29 ` Baoquan He
2016-05-09 14:29 ` Baoquan He
2016-05-09 15:40 ` Corey Minyard
2016-05-09 15:40 ` Corey Minyard
2016-05-10 1:37 ` Baoquan He
2016-05-10 1:37 ` Baoquan He
2016-05-10 1:48 ` Baoquan He
2016-05-10 1:48 ` Baoquan He
-- strict thread matches above, loose matches on Subject: below --
2016-01-19 16:57 minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160505023758.GA2558@x1.redhat.com \
--to=bhe@redhat.com \
--cc=cminyard@mvista.com \
--cc=dyoung@redhat.com \
--cc=hbabu@us.ibm.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.