From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Jean Delvare <jdelvare@suse.com>,
Wolfram Sang <wsa@the-dreams.de>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Mario Limonciello <mario_limonciello@dell.com>,
pali.rohar@gmail.com, linux-i2c@vger.kernel.org,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH v2] i2c: i801: Allow ACPI SystemIO OpRegion to conflict with PCI BAR
Date: Fri, 6 May 2016 11:55:07 +0300 [thread overview]
Message-ID: <20160506085507.GD15974@lahna.fi.intel.com> (raw)
In-Reply-To: <2682382.6cA2VZCBS9@vostro.rjw.lan>
On Wed, May 04, 2016 at 10:04:40PM +0200, Rafael J. Wysocki wrote:
> > + mutex_lock(&priv->acpi_lock);
> > + if (priv->acpi_reserved) {
> > + mutex_unlock(&priv->acpi_lock);
> > + return -EPERM;
>
> I'd return -EIO from here as that's what it looks like from the caller's perspective.
I can change that in v3 as I need to add reported-by and bugzilla links,
which I forgot, to the patch as well.
> That's not a big deal, though, so
>
> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Thanks!
next prev parent reply other threads:[~2016-05-06 8:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-04 9:27 [PATCH v2] i2c: i801: Allow ACPI SystemIO OpRegion to conflict with PCI BAR Mika Westerberg
2016-05-04 9:40 ` Mika Westerberg
2016-05-04 20:04 ` Rafael J. Wysocki
2016-05-06 8:55 ` Mika Westerberg [this message]
2016-05-06 12:12 ` Matt Fleming
2016-05-06 12:20 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160506085507.GD15974@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jdelvare@suse.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mario_limonciello@dell.com \
--cc=pali.rohar@gmail.com \
--cc=rjw@rjwysocki.net \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.